Description: Allow the PE timestamp to be specified Author: Stephen Kitt Index: binutils-mingw-w64/upstream/bfd/peXXigen.c =================================================================== --- binutils-mingw-w64.orig/upstream/bfd/peXXigen.c 2020-07-09 14:54:20.836479103 +0200 +++ binutils-mingw-w64/upstream/bfd/peXXigen.c 2020-07-09 14:55:49.842218292 +0200 @@ -77,6 +77,9 @@ #include #endif +#include +#include + /* NOTE: it's strange to be including an architecture specific header in what's supposed to be general (to PE/PEI) code. However, that's where the definitions are, and they don't vary per architecture @@ -876,9 +879,36 @@ /* Use a real timestamp by default, unless the no-insert-timestamp option was chosen. */ - if ((pe_data (abfd)->timestamp) == -1) - H_PUT_32 (abfd, time (0), filehdr_out->f_timdat); - else + if ((pe_data (abfd)->timestamp) == -1) { + time_t now; + char *source_date_epoch; + unsigned long long epoch; + char *endptr; + + now = time (NULL); + source_date_epoch = getenv("SOURCE_DATE_EPOCH"); + if (source_date_epoch) { + errno = 0; + epoch = strtoull(source_date_epoch, &endptr, 10); + if ((errno == ERANGE && (epoch == ULLONG_MAX || epoch == 0)) + || (errno != 0 && epoch == 0)) { + _bfd_error_handler("Environment variable $SOURCE_DATE_EPOCH: strtoull: %s\n", + strerror(errno)); + } else if (endptr == source_date_epoch) { + _bfd_error_handler("Environment variable $SOURCE_DATE_EPOCH: No digits were found: %s\n", + endptr); + } else if (*endptr != '\0') { + _bfd_error_handler("Environment variable $SOURCE_DATE_EPOCH: Trailing garbage: %s\n", + endptr); + } else if (epoch > ULONG_MAX) { + _bfd_error_handler("Environment variable $SOURCE_DATE_EPOCH: value must be smaller than or equal to: %lu but was found to be: %llu\n", + ULONG_MAX, epoch); + } else { + now = epoch; + } + } + H_PUT_32 (abfd, now, filehdr_out->f_timdat); + } else H_PUT_32 (abfd, pe_data (abfd)->timestamp, filehdr_out->f_timdat); PUT_FILEHDR_SYMPTR (abfd, filehdr_in->f_symptr, Index: binutils-mingw-w64/upstream/ld/pe-dll.c =================================================================== --- binutils-mingw-w64.orig/upstream/ld/pe-dll.c 2020-07-09 14:54:20.836479103 +0200 +++ binutils-mingw-w64/upstream/ld/pe-dll.c 2020-07-09 14:55:21.745669536 +0200 @@ -27,6 +27,8 @@ #include "safe-ctype.h" #include "ctf-api.h" +#include +#include #include #include "ld.h" @@ -1218,9 +1220,36 @@ memset (edata_d, 0, edata_sz); - if (pe_data (abfd)->timestamp == -1) - H_PUT_32 (abfd, time (0), edata_d + 4); - else + if (pe_data (abfd)->timestamp == -1) { + time_t now; + char *source_date_epoch; + unsigned long long epoch; + char *endptr; + + now = time(NULL); + source_date_epoch = getenv("SOURCE_DATE_EPOCH"); + if (source_date_epoch) { + errno = 0; + epoch = strtoull(source_date_epoch, &endptr, 10); + if ((errno == ERANGE && (epoch == ULLONG_MAX || epoch == 0)) + || (errno != 0 && epoch == 0)) { + einfo("Environment variable $SOURCE_DATE_EPOCH: strtoull: %s\n", + strerror(errno)); + } else if (endptr == source_date_epoch) { + einfo("Environment variable $SOURCE_DATE_EPOCH: No digits were found: %s\n", + endptr); + } else if (*endptr != '\0') { + einfo("Environment variable $SOURCE_DATE_EPOCH: Trailing garbage: %s\n", + endptr); + } else if (epoch > ULONG_MAX) { + einfo("Environment variable $SOURCE_DATE_EPOCH: value must be smaller than or equal to: %lu but was found to be: %llu\n", + ULONG_MAX, epoch); + } else { + now = epoch; + } + } + H_PUT_32 (abfd, now, edata_d + 4); + } else H_PUT_32 (abfd, pe_data (abfd)->timestamp, edata_d + 4); if (pe_def_file->version_major != -1) Index: binutils-mingw-w64/upstream/ld/emultempl/pe.em =================================================================== --- binutils-mingw-w64.orig/upstream/ld/emultempl/pe.em 2020-07-09 14:54:20.836479103 +0200 +++ binutils-mingw-w64/upstream/ld/emultempl/pe.em 2020-07-09 14:54:37.000000000 +0200 @@ -304,7 +304,7 @@ OPTION_USE_NUL_PREFIXED_IMPORT_TABLES}, {"no-leading-underscore", no_argument, NULL, OPTION_NO_LEADING_UNDERSCORE}, {"leading-underscore", no_argument, NULL, OPTION_LEADING_UNDERSCORE}, - {"insert-timestamp", no_argument, NULL, OPTION_INSERT_TIMESTAMP}, + {"insert-timestamp", optional_argument, NULL, OPTION_INSERT_TIMESTAMP}, {"no-insert-timestamp", no_argument, NULL, OPTION_NO_INSERT_TIMESTAMP}, #ifdef DLL_SUPPORT /* getopt allows abbreviations, so we do this to stop it Index: binutils-mingw-w64/upstream/ld/emultempl/pep.em =================================================================== --- binutils-mingw-w64.orig/upstream/ld/emultempl/pep.em 2020-07-09 14:54:20.836479103 +0200 +++ binutils-mingw-w64/upstream/ld/emultempl/pep.em 2020-07-09 14:54:37.000000000 +0200 @@ -323,7 +323,7 @@ {"no-bind", no_argument, NULL, OPTION_NO_BIND}, {"wdmdriver", no_argument, NULL, OPTION_WDM_DRIVER}, {"tsaware", no_argument, NULL, OPTION_TERMINAL_SERVER_AWARE}, - {"insert-timestamp", no_argument, NULL, OPTION_INSERT_TIMESTAMP}, + {"insert-timestamp", optional_argument, NULL, OPTION_INSERT_TIMESTAMP}, {"no-insert-timestamp", no_argument, NULL, OPTION_NO_INSERT_TIMESTAMP}, {"build-id", optional_argument, NULL, OPTION_BUILD_ID}, {"enable-reloc-section", no_argument, NULL, OPTION_ENABLE_RELOC_SECTION},