486 lines
15 KiB
Diff
486 lines
15 KiB
Diff
From 3e5da55bf9558ae489126396cf9c6a71ca9ff8ad Mon Sep 17 00:00:00 2001
|
|
From: Christoph Reiter <reiter.christoph@gmail.com>
|
|
Date: Thu, 17 Jun 2021 18:52:14 +0530
|
|
Subject: [PATCH 039/N] Use cygpty while using isatty
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
so that msys shells are detected as interactive ones
|
|
|
|
Co-authored-by: Алексей <alexey.pawlow@gmail.com>
|
|
Co-authored-by: Naveen M K <naveen521kk@gmail.com>
|
|
---
|
|
Include/iscygpty.h | 41 ++++++++++
|
|
Makefile.pre.in | 2 +
|
|
Modules/_io/fileio.c | 3 +-
|
|
Modules/main.c | 3 +-
|
|
Modules/posixmodule.c | 3 +-
|
|
Objects/fileobject.c | 3 +-
|
|
Python/bltinmodule.c | 5 +-
|
|
Python/fileutils.c | 7 +-
|
|
Python/frozenmain.c | 3 +-
|
|
Python/iscygpty.c | 185 ++++++++++++++++++++++++++++++++++++++++++
|
|
Python/pylifecycle.c | 5 +-
|
|
11 files changed, 248 insertions(+), 12 deletions(-)
|
|
create mode 100644 Include/iscygpty.h
|
|
create mode 100644 Python/iscygpty.c
|
|
|
|
diff --git a/Include/iscygpty.h b/Include/iscygpty.h
|
|
new file mode 100644
|
|
index 0000000..82fd0af
|
|
--- /dev/null
|
|
+++ b/Include/iscygpty.h
|
|
@@ -0,0 +1,41 @@
|
|
+/*
|
|
+ * iscygpty.h -- part of ptycheck
|
|
+ * https://github.com/k-takata/ptycheck
|
|
+ *
|
|
+ * Copyright (c) 2015-2017 K.Takata
|
|
+ *
|
|
+ * You can redistribute it and/or modify it under the terms of either
|
|
+ * the MIT license (as described below) or the Vim license.
|
|
+ *
|
|
+ * Permission is hereby granted, free of charge, to any person obtaining
|
|
+ * a copy of this software and associated documentation files (the
|
|
+ * "Software"), to deal in the Software without restriction, including
|
|
+ * without limitation the rights to use, copy, modify, merge, publish,
|
|
+ * distribute, sublicense, and/or sell copies of the Software, and to
|
|
+ * permit persons to whom the Software is furnished to do so, subject to
|
|
+ * the following conditions:
|
|
+ *
|
|
+ * The above copyright notice and this permission notice shall be
|
|
+ * included in all copies or substantial portions of the Software.
|
|
+ *
|
|
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
|
|
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
|
|
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
|
|
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
+ */
|
|
+
|
|
+#ifndef _ISCYGPTY_H
|
|
+#define _ISCYGPTY_H
|
|
+
|
|
+#ifdef _WIN32
|
|
+int is_cygpty(int fd);
|
|
+int is_cygpty_used(void);
|
|
+#else
|
|
+#define is_cygpty(fd) 0
|
|
+#define is_cygpty_used() 0
|
|
+#endif
|
|
+
|
|
+#endif /* _ISCYGPTY_H */
|
|
diff --git a/Makefile.pre.in b/Makefile.pre.in
|
|
index 5cc3d6d..2af2bee 100644
|
|
--- a/Makefile.pre.in
|
|
+++ b/Makefile.pre.in
|
|
@@ -406,6 +406,7 @@ PYTHON_OBJS= \
|
|
Python/instrumentation.o \
|
|
Python/intrinsics.o \
|
|
Python/legacy_tracing.o \
|
|
+ Python/iscygpty.o \
|
|
Python/marshal.o \
|
|
Python/modsupport.o \
|
|
Python/mysnprintf.o \
|
|
@@ -1636,6 +1637,7 @@ PYTHON_HEADERS= \
|
|
$(srcdir)/Include/import.h \
|
|
$(srcdir)/Include/interpreteridobject.h \
|
|
$(srcdir)/Include/intrcheck.h \
|
|
+ $(srcdir)/Include/iscygpty.h \
|
|
$(srcdir)/Include/iterobject.h \
|
|
$(srcdir)/Include/listobject.h \
|
|
$(srcdir)/Include/longobject.h \
|
|
diff --git a/Modules/_io/fileio.c b/Modules/_io/fileio.c
|
|
index bab6807..919b8b0 100644
|
|
--- a/Modules/_io/fileio.c
|
|
+++ b/Modules/_io/fileio.c
|
|
@@ -20,6 +20,7 @@
|
|
#endif
|
|
#include <stddef.h> /* For offsetof */
|
|
#include "_iomodule.h"
|
|
+#include "iscygpty.h"
|
|
|
|
/*
|
|
* Known likely problems:
|
|
@@ -1143,7 +1144,7 @@ _io_FileIO_isatty_impl(fileio *self)
|
|
return err_closed();
|
|
Py_BEGIN_ALLOW_THREADS
|
|
_Py_BEGIN_SUPPRESS_IPH
|
|
- res = isatty(self->fd);
|
|
+ res = isatty(self->fd) || is_cygpty(self->fd);
|
|
_Py_END_SUPPRESS_IPH
|
|
Py_END_ALLOW_THREADS
|
|
return PyBool_FromLong(res);
|
|
diff --git a/Modules/main.c b/Modules/main.c
|
|
index f4e4018..fbdccdd 100644
|
|
--- a/Modules/main.c
|
|
+++ b/Modules/main.c
|
|
@@ -7,6 +7,7 @@
|
|
#include "pycore_pathconfig.h" // _PyPathConfig_ComputeSysPath0()
|
|
#include "pycore_pylifecycle.h" // _Py_PreInitializeFromPyArgv()
|
|
#include "pycore_pystate.h" // _PyInterpreterState_GET()
|
|
+#include "iscygpty.h"
|
|
|
|
/* Includes for exit_sigint() */
|
|
#include <stdio.h> // perror()
|
|
@@ -92,7 +93,7 @@ static inline int config_run_code(const PyConfig *config)
|
|
static int
|
|
stdin_is_interactive(const PyConfig *config)
|
|
{
|
|
- return (isatty(fileno(stdin)) || config->interactive);
|
|
+ return (isatty(fileno(stdin)) || config->interactive || is_cygpty(fileno(stdin)));
|
|
}
|
|
|
|
|
|
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
|
|
index 2cb0c5b..51b3e52 100644
|
|
--- a/Modules/posixmodule.c
|
|
+++ b/Modules/posixmodule.c
|
|
@@ -54,6 +54,7 @@
|
|
#ifdef __ANDROID__
|
|
# undef HAVE_FACCESSAT
|
|
#endif
|
|
+#include "iscygpty.h"
|
|
|
|
#include <stdio.h> // ctermid()
|
|
#include <stdlib.h> // system()
|
|
@@ -11235,7 +11236,7 @@ os_isatty_impl(PyObject *module, int fd)
|
|
int return_value;
|
|
Py_BEGIN_ALLOW_THREADS
|
|
_Py_BEGIN_SUPPRESS_IPH
|
|
- return_value = isatty(fd);
|
|
+ return_value = isatty(fd) || is_cygpty(fd);
|
|
_Py_END_SUPPRESS_IPH
|
|
Py_END_ALLOW_THREADS
|
|
return return_value;
|
|
diff --git a/Objects/fileobject.c b/Objects/fileobject.c
|
|
index e99e155..c74d2af 100644
|
|
--- a/Objects/fileobject.c
|
|
+++ b/Objects/fileobject.c
|
|
@@ -3,6 +3,7 @@
|
|
#define PY_SSIZE_T_CLEAN
|
|
#include "Python.h"
|
|
#include "pycore_call.h" // _PyObject_CallNoArgs()
|
|
+#include "iscygpty.h"
|
|
#include "pycore_runtime.h" // _PyRuntime
|
|
|
|
#if defined(HAVE_GETC_UNLOCKED) && !defined(_Py_MEMORY_SANITIZER)
|
|
@@ -382,7 +383,7 @@ stdprinter_isatty(PyStdPrinter_Object *self, PyObject *Py_UNUSED(ignored))
|
|
}
|
|
|
|
Py_BEGIN_ALLOW_THREADS
|
|
- res = isatty(self->fd);
|
|
+ res = isatty(self->fd) || is_cygpty(self->fd);
|
|
Py_END_ALLOW_THREADS
|
|
|
|
return PyBool_FromLong(res);
|
|
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
|
|
index 2ae2869..d918964 100644
|
|
--- a/Python/bltinmodule.c
|
|
+++ b/Python/bltinmodule.c
|
|
@@ -1,6 +1,7 @@
|
|
/* Built-in functions */
|
|
|
|
#include "Python.h"
|
|
+#include "iscygpty.h"
|
|
#include <ctype.h>
|
|
#include "pycore_ast.h" // _PyAST_Validate()
|
|
#include "pycore_call.h" // _PyObject_CallNoArgs()
|
|
@@ -2163,7 +2164,7 @@ builtin_input_impl(PyObject *module, PyObject *prompt)
|
|
if (fd < 0 && PyErr_Occurred()) {
|
|
goto error;
|
|
}
|
|
- tty = fd == fileno(stdin) && isatty(fd);
|
|
+ tty = fd == fileno(stdin) && (isatty(fd) || is_cygpty(fd));
|
|
}
|
|
if (tty) {
|
|
tmp = PyObject_CallMethodNoArgs(fout, &_Py_ID(fileno));
|
|
@@ -2176,7 +2177,7 @@ builtin_input_impl(PyObject *module, PyObject *prompt)
|
|
Py_DECREF(tmp);
|
|
if (fd < 0 && PyErr_Occurred())
|
|
goto error;
|
|
- tty = fd == fileno(stdout) && isatty(fd);
|
|
+ tty = fd == fileno(stdout) && (isatty(fd) || is_cygpty(fd));
|
|
}
|
|
}
|
|
|
|
diff --git a/Python/fileutils.c b/Python/fileutils.c
|
|
index c752175..6d3b04f 100644
|
|
--- a/Python/fileutils.c
|
|
+++ b/Python/fileutils.c
|
|
@@ -1,4 +1,5 @@
|
|
#include "Python.h"
|
|
+#include "iscygpty.h"
|
|
#include "pycore_fileutils.h" // fileutils definitions
|
|
#include "pycore_runtime.h" // _PyRuntime
|
|
#include "osdefs.h" // SEP
|
|
@@ -77,7 +78,7 @@ _Py_device_encoding(int fd)
|
|
int valid;
|
|
Py_BEGIN_ALLOW_THREADS
|
|
_Py_BEGIN_SUPPRESS_IPH
|
|
- valid = isatty(fd);
|
|
+ valid = isatty(fd) || is_cygpty(fd);
|
|
_Py_END_SUPPRESS_IPH
|
|
Py_END_ALLOW_THREADS
|
|
if (!valid)
|
|
@@ -1925,12 +1926,12 @@ _Py_write_impl(int fd, const void *buf, size_t count, int gil_held)
|
|
depending on heap usage). */
|
|
if (gil_held) {
|
|
Py_BEGIN_ALLOW_THREADS
|
|
- if (isatty(fd)) {
|
|
+ if (isatty(fd) || is_cygpty(fd)) {
|
|
count = 32767;
|
|
}
|
|
Py_END_ALLOW_THREADS
|
|
} else {
|
|
- if (isatty(fd)) {
|
|
+ if (isatty(fd) || is_cygpty(fd)) {
|
|
count = 32767;
|
|
}
|
|
}
|
|
diff --git a/Python/frozenmain.c b/Python/frozenmain.c
|
|
index f8be165..d18c7b3 100644
|
|
--- a/Python/frozenmain.c
|
|
+++ b/Python/frozenmain.c
|
|
@@ -3,6 +3,7 @@
|
|
#include "Python.h"
|
|
#include "pycore_runtime.h" // _PyRuntime_Initialize()
|
|
#include <locale.h>
|
|
+#include "iscygpty.h"
|
|
|
|
#ifdef MS_WINDOWS
|
|
extern void PyWinFreeze_ExeInit(void);
|
|
@@ -71,7 +72,7 @@ Py_FrozenMain(int argc, char **argv)
|
|
sts = 0;
|
|
}
|
|
|
|
- if (inspect && isatty((int)fileno(stdin))) {
|
|
+ if (inspect && (isatty((int)fileno(stdin)) || is_cygpty((int)fileno(stdin))))
|
|
sts = PyRun_AnyFile(stdin, "<stdin>") != 0;
|
|
}
|
|
|
|
diff --git a/Python/iscygpty.c b/Python/iscygpty.c
|
|
new file mode 100644
|
|
index 0000000..722f88f
|
|
--- /dev/null
|
|
+++ b/Python/iscygpty.c
|
|
@@ -0,0 +1,185 @@
|
|
+/*
|
|
+ * iscygpty.c -- part of ptycheck
|
|
+ * https://github.com/k-takata/ptycheck
|
|
+ *
|
|
+ * Copyright (c) 2015-2017 K.Takata
|
|
+ *
|
|
+ * You can redistribute it and/or modify it under the terms of either
|
|
+ * the MIT license (as described below) or the Vim license.
|
|
+ *
|
|
+ * Permission is hereby granted, free of charge, to any person obtaining
|
|
+ * a copy of this software and associated documentation files (the
|
|
+ * "Software"), to deal in the Software without restriction, including
|
|
+ * without limitation the rights to use, copy, modify, merge, publish,
|
|
+ * distribute, sublicense, and/or sell copies of the Software, and to
|
|
+ * permit persons to whom the Software is furnished to do so, subject to
|
|
+ * the following conditions:
|
|
+ *
|
|
+ * The above copyright notice and this permission notice shall be
|
|
+ * included in all copies or substantial portions of the Software.
|
|
+ *
|
|
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
+ * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
|
|
+ * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
|
|
+ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
|
|
+ * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
+ */
|
|
+
|
|
+#ifdef _WIN32
|
|
+
|
|
+#include <ctype.h>
|
|
+#include <io.h>
|
|
+#include <wchar.h>
|
|
+#include <windows.h>
|
|
+
|
|
+#ifdef USE_FILEEXTD
|
|
+/* VC 7.1 or earlier doesn't support SAL. */
|
|
+# if !defined(_MSC_VER) || (_MSC_VER < 1400)
|
|
+# define __out
|
|
+# define __in
|
|
+# define __in_opt
|
|
+# endif
|
|
+/* Win32 FileID API Library:
|
|
+ * http://www.microsoft.com/en-us/download/details.aspx?id=22599
|
|
+ * Needed for WinXP. */
|
|
+# include <fileextd.h>
|
|
+#else /* USE_FILEEXTD */
|
|
+/* VC 8 or earlier. */
|
|
+# if defined(_MSC_VER) && (_MSC_VER < 1500)
|
|
+# ifdef ENABLE_STUB_IMPL
|
|
+# define STUB_IMPL
|
|
+# else
|
|
+# error "Win32 FileID API Library is required for VC2005 or earlier."
|
|
+# endif
|
|
+# endif
|
|
+#endif /* USE_FILEEXTD */
|
|
+
|
|
+
|
|
+#include "iscygpty.h"
|
|
+
|
|
+//#define USE_DYNFILEID
|
|
+#ifdef USE_DYNFILEID
|
|
+typedef BOOL (WINAPI *pfnGetFileInformationByHandleEx)(
|
|
+ HANDLE hFile,
|
|
+ FILE_INFO_BY_HANDLE_CLASS FileInformationClass,
|
|
+ LPVOID lpFileInformation,
|
|
+ DWORD dwBufferSize
|
|
+);
|
|
+static pfnGetFileInformationByHandleEx pGetFileInformationByHandleEx = NULL;
|
|
+
|
|
+# ifndef USE_FILEEXTD
|
|
+static BOOL WINAPI stub_GetFileInformationByHandleEx(
|
|
+ HANDLE hFile,
|
|
+ FILE_INFO_BY_HANDLE_CLASS FileInformationClass,
|
|
+ LPVOID lpFileInformation,
|
|
+ DWORD dwBufferSize
|
|
+ )
|
|
+{
|
|
+ return FALSE;
|
|
+}
|
|
+# endif
|
|
+
|
|
+static void setup_fileid_api(void)
|
|
+{
|
|
+ if (pGetFileInformationByHandleEx != NULL) {
|
|
+ return;
|
|
+ }
|
|
+ pGetFileInformationByHandleEx = (pfnGetFileInformationByHandleEx)
|
|
+ GetProcAddress(GetModuleHandle(TEXT("kernel32.dll")),
|
|
+ "GetFileInformationByHandleEx");
|
|
+ if (pGetFileInformationByHandleEx == NULL) {
|
|
+# ifdef USE_FILEEXTD
|
|
+ pGetFileInformationByHandleEx = GetFileInformationByHandleEx;
|
|
+# else
|
|
+ pGetFileInformationByHandleEx = stub_GetFileInformationByHandleEx;
|
|
+# endif
|
|
+ }
|
|
+}
|
|
+#else
|
|
+# define pGetFileInformationByHandleEx GetFileInformationByHandleEx
|
|
+# define setup_fileid_api()
|
|
+#endif
|
|
+
|
|
+
|
|
+#define is_wprefix(s, prefix) \
|
|
+ (wcsncmp((s), (prefix), sizeof(prefix) / sizeof(WCHAR) - 1) == 0)
|
|
+
|
|
+/* Check if the fd is a cygwin/msys's pty. */
|
|
+int is_cygpty(int fd)
|
|
+{
|
|
+#ifdef STUB_IMPL
|
|
+ return 0;
|
|
+#else
|
|
+ HANDLE h;
|
|
+ int size = sizeof(FILE_NAME_INFO) + sizeof(WCHAR) * (MAX_PATH - 1);
|
|
+ FILE_NAME_INFO *nameinfo;
|
|
+ WCHAR *p = NULL;
|
|
+
|
|
+ setup_fileid_api();
|
|
+
|
|
+ h = (HANDLE) _get_osfhandle(fd);
|
|
+ if (h == INVALID_HANDLE_VALUE) {
|
|
+ return 0;
|
|
+ }
|
|
+ /* Cygwin/msys's pty is a pipe. */
|
|
+ if (GetFileType(h) != FILE_TYPE_PIPE) {
|
|
+ return 0;
|
|
+ }
|
|
+ nameinfo = malloc(size + sizeof(WCHAR));
|
|
+ if (nameinfo == NULL) {
|
|
+ return 0;
|
|
+ }
|
|
+ /* Check the name of the pipe:
|
|
+ * '\{cygwin,msys}-XXXXXXXXXXXXXXXX-ptyN-{from,to}-master' */
|
|
+ if (pGetFileInformationByHandleEx(h, FileNameInfo, nameinfo, size)) {
|
|
+ nameinfo->FileName[nameinfo->FileNameLength / sizeof(WCHAR)] = L'\0';
|
|
+ p = nameinfo->FileName;
|
|
+ if (is_wprefix(p, L"\\cygwin-")) { /* Cygwin */
|
|
+ p += 8;
|
|
+ } else if (is_wprefix(p, L"\\msys-")) { /* MSYS and MSYS2 */
|
|
+ p += 6;
|
|
+ } else {
|
|
+ p = NULL;
|
|
+ }
|
|
+ if (p != NULL) {
|
|
+ while (*p && isxdigit(*p)) /* Skip 16-digit hexadecimal. */
|
|
+ ++p;
|
|
+ if (is_wprefix(p, L"-pty")) {
|
|
+ p += 4;
|
|
+ } else {
|
|
+ p = NULL;
|
|
+ }
|
|
+ }
|
|
+ if (p != NULL) {
|
|
+ while (*p && isdigit(*p)) /* Skip pty number. */
|
|
+ ++p;
|
|
+ if (is_wprefix(p, L"-from-master")) {
|
|
+ //p += 12;
|
|
+ } else if (is_wprefix(p, L"-to-master")) {
|
|
+ //p += 10;
|
|
+ } else {
|
|
+ p = NULL;
|
|
+ }
|
|
+ }
|
|
+ }
|
|
+ free(nameinfo);
|
|
+ return (p != NULL);
|
|
+#endif /* STUB_IMPL */
|
|
+}
|
|
+
|
|
+/* Check if at least one cygwin/msys pty is used. */
|
|
+int is_cygpty_used(void)
|
|
+{
|
|
+ int fd, ret = 0;
|
|
+
|
|
+ for (fd = 0; fd < 3; fd++) {
|
|
+ ret |= is_cygpty(fd);
|
|
+ }
|
|
+ return ret;
|
|
+}
|
|
+
|
|
+#endif /* _WIN32 */
|
|
+
|
|
+/* vim: set ts=4 sw=4: */
|
|
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
|
|
index f5bea14..0bbb279 100644
|
|
--- a/Python/pylifecycle.c
|
|
+++ b/Python/pylifecycle.c
|
|
@@ -30,6 +30,7 @@
|
|
#include "pycore_unicodeobject.h" // _PyUnicode_InitTypes()
|
|
#include "opcode.h"
|
|
|
|
+#include "iscygpty.h"
|
|
#include <locale.h> // setlocale()
|
|
#include <stdlib.h> // getenv()
|
|
|
|
@@ -3113,7 +3114,7 @@ Py_Exit(int sts)
|
|
int
|
|
Py_FdIsInteractive(FILE *fp, const char *filename)
|
|
{
|
|
- if (isatty(fileno(fp))) {
|
|
+ if (isatty(fileno(fp)) || is_cygpty(fileno(fp))) {
|
|
return 1;
|
|
}
|
|
if (!_Py_GetConfig()->interactive) {
|
|
@@ -3128,7 +3129,7 @@ Py_FdIsInteractive(FILE *fp, const char *filename)
|
|
int
|
|
_Py_FdIsInteractive(FILE *fp, PyObject *filename)
|
|
{
|
|
- if (isatty(fileno(fp))) {
|
|
+ if (isatty(fileno(fp)) || is_cygpty(fileno(fp))) {
|
|
return 1;
|
|
}
|
|
if (!_Py_GetConfig()->interactive) {
|