tcl: build for cygwin; drop unused patch

tcl/8.5.10-tea-m4.patch

@@ -1,12 +0,0 @@
-For backwards compatibility
-
---- origsrc/tcl8.5.10/tcl.m4	2011-10-24 20:47:16.878248200 -0500
-+++ src/tcl8.5.10/tcl.m4	2011-10-24 20:50:38.013444700 -0500
-@@ -3106,6 +3106,7 @@ AC_DEFUN([TEA_SETUP_COMPILER_CC], [
- 
-     AC_PROG_CC
-     AC_PROG_CPP
-+    AC_PROG_INSTALL
- 
-     #--------------------------------------------------------------------
-     # Checks to see if the make program sets the $MAKE variable.

tcl/PKGBUILD

@@ -3,7 +3,7 @@
 
 pkgname=tcl
 pkgver=8.6.10
-pkgrel=2
+pkgrel=3
 pkgdesc="The Tcl scripting language"
 arch=('i686' 'x86_64')
 url="https://tcl.sourceforge.io/"
@@ -25,6 +25,8 @@ prepare() {
   # we build the tcl sqlite interface in sqlite-tcl package
   rm -rf pkgs/sqlite3*
   patch -p2 -i ${srcdir}/8.6.6-cygwin-unix.patch
+
+  # The patched file gets installed, so we have to support an MSYS uname there
   patch -p1 -i ${srcdir}/tcl-8.5.18-msysize.patch
 
   for _dd in itcl4.2.0 tdbc1.1.1 tdbcmysql1.1.1 tdbcodbc1.1.1 tdbcpostgres1.1.1 tdbcsqlite3-1.1.1 thread2.8.5; do
@@ -39,14 +41,18 @@ prepare() {
 
 build() {
   cd tcl${pkgver}/unix
+
+  export MSYSTEM=CYGWIN
+  local CYGWIN_CHOST="${CHOST/-msys/-cygwin}"
   local BIT=
   [[ $CARCH == "x86_64" ]] && BIT="--enable-64bit"
   ./configure \
+    --build="${CYGWIN_CHOST}" \
     --prefix=/usr \
     --mandir=/usr/share/man \
     --enable-threads \
     tcl_cv_strtod_buggy=no \
-    tcl_cv_sys_version=MSYS_NT \
+    tcl_cv_sys_version=CYGWIN_NT \
     $BIT
   make
 }
@@ -61,7 +67,6 @@ package() {
   make INSTALL_ROOT="${pkgdir}" install
 
   install -Dm644 libtcl${pkgver%.*}.dll.a "${pkgdir}"/usr/lib/libtcl${pkgver%.*}.dll.a
-  #mv ${pkgdir}/usr/lib/libtcl${pkgver%.*}.dll ${pkgdir}/usr/bin/
 
   install -Dm644 ../license.terms "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"