Commit Graph

2 Commits

Author SHA1 Message Date
Ray Donnelly
c1b58eb8c7 msys2-runtime: Fix mingw-w64-emacs -> msys2/git with MSYS=noglob 2015-09-13 01:18:24 +01:00
Ray Donnelly
7388276a41 msys2-runtime: Various fixes for argv[] determination
When Windows programs called MSYS2/Cygwin programs argv[] handling
was something of a mess. It's still a bit of a mess, but at least
it works for the more common use-cases [*].

Mainly, if globify () detected an argument that looked like a dos
path ('C:', '"C:' or \\) then it wouldn't handle proceeding literal,
escaped quotes correctly (the " got dumped, while the \ remained).

Also, strace was setting env. var MSYS="noglob" and I can't figure
out why. This made investigating the globify () problem a lot more
difficult than it should've been.

Finally, build_argv conflated winshell with (winshell && allow_glob)
when they should be orthogonal.

Also added a bunch of debug_printf () calls.

[*] It's possible that I broke the corner-case of:
    '"C:\some\quoted\\"folder with spaces\"\may\not\work"'
    .. in order to support:
    "C:/some/quoted/\"folder with spaces\"/now/does/work"'
    .. so I might revisit this soon.
2015-08-24 01:54:40 +01:00