Befator-Inc-Firmen-Netzwerk/msys2-autobuild
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 10 Wiki Activity

clean-assets: only re-create releases if there are many assets

Browse Source 
re-creating causes notifications for users. While users can disable them
let's just limit it to larger rebuilds, like the Python rebuilds

Fixes #77
This commit is contained in:
Christoph Reiter 2023-08-01 08:06:13 +02:00
parent 4db4e22d09
commit 1f1fabade2
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
msys2_autobuild/cmd_clean_assets.py
View File

@ -34,7 +34,13 @@ def get_assets_to_delete() -> Tuple[List[GitRelease], List[GitReleaseAsset]]:
# Deleting and re-creating a release requires two write calls, so delete # Deleting and re-creating a release requires two write calls, so delete
# the release if all assets should be deleted and there are more than 2. # the release if all assets should be deleted and there are more than 2.
if len(to_delete) > 2 and len(assets) == len(to_delete): # min_to_delete = 3
# XXX: re-creating releases causes notifications, so avoid unless possible
# https://github.com/msys2/msys2-autobuild/issues/77#issuecomment-1657231719
min_to_delete = 400
if len(to_delete) >= min_to_delete and len(assets) == len(to_delete):
return [release], [] return [release], []
else: else:
return [], to_delete return [], to_delete