Befator-Inc-Firmen-Netzwerk/msys2-autobuild
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 10 Wiki Activity

Drop BUILD_TYPES_WIP

Browse Source 
This wasn't complete as it would only ignore broken builds
for direct deps and not indirect ones, but kinda worked in ignoring
some arm64 errors.

But it also causes problems if an error is ignored and the other arches
get uploaded. Then it's hard to roll back the update because lots of
packages with the new version are already in the repo.

With the new autobuild controller we can also restart flaky builds instead
of ignoring them and waiting for jeremy to fix them later.

Let's try removing that special case.
This commit is contained in:
Christoph Reiter 2022-09-19 20:19:32 +02:00
parent 253f8b8c4c
commit b40229daa6
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
autobuild.py
View File

@ -102,9 +102,6 @@ class Config:
} }
"""XXX: In case of cycles we mark these deps as optional""" """XXX: In case of cycles we mark these deps as optional"""
BUILD_TYPES_WIP: List[BuildType] = ["clangarm64"]
"""XXX: These build types don't block other things, even if they fail/don't get built"""
_PathLike = Union[os.PathLike, AnyStr] _PathLike = Union[os.PathLike, AnyStr]
@ -923,8 +920,7 @@ def get_buildqueue_with_status(full_details: bool = False) -> List[Package]:
for dep_type, deps in pkg.get_rdepends(build_type).items(): for dep_type, deps in pkg.get_rdepends(build_type).items():
for dep in deps: for dep in deps:
if dep["name"] in Config.IGNORE_RDEP_PACKAGES or \ if dep["name"] in Config.IGNORE_RDEP_PACKAGES:
(build_type != dep_type and dep_type in Config.BUILD_TYPES_WIP):
continue continue
dep_status = dep.get_status(dep_type) dep_status = dep.get_status(dep_type)
dep_new = dep.is_new(dep_type) dep_new = dep.is_new(dep_type)
@ -946,8 +942,7 @@ def get_buildqueue_with_status(full_details: bool = False) -> List[Package]:
blocked.append(build_type) blocked.append(build_type)
# if the package isn't in the repo better not block on it # if the package isn't in the repo better not block on it
elif not pkg.is_new(build_type): elif not pkg.is_new(build_type):
if build_type not in Config.BUILD_TYPES_WIP: unfinished.append(build_type)
unfinished.append(build_type)
else: else:
finished.append(build_type) finished.append(build_type)