From fd3925efa058bd1d7f96d40dc0f4d245ae89b54e Mon Sep 17 00:00:00 2001
From: Christoph Reiter <reiter.christoph@gmail.com>
Date: Tue, 23 Jul 2024 00:13:36 +0200
Subject: [PATCH] Only show an outdated banner if the git version is too old

And not the version in the repo.
If the new version is in git, there is usually nothing to do, except
waiting for it to reach the repo.
---
 app/appstate.py             | 4 ++--
 app/templates/base.html     | 2 +-
 app/templates/security.html | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/appstate.py b/app/appstate.py
index b2ee763..145203d 100644
--- a/app/appstate.py
+++ b/app/appstate.py
@@ -593,10 +593,10 @@ class Source:
         return sorted(ext)
 
     @property
-    def is_outdated(self) -> bool:
+    def is_outdated_in_git(self) -> bool:
         if self.upstream_version is None:
             return False
-        msys_version = extract_upstream_version(self.version)
+        msys_version = extract_upstream_version(self.git_version)
         return version_is_newer_than(self.upstream_version, msys_version)
 
     @property
diff --git a/app/templates/base.html b/app/templates/base.html
index 43cc906..000d099 100644
--- a/app/templates/base.html
+++ b/app/templates/base.html
@@ -25,7 +25,7 @@
   </div>
   <div class="card-body overflow-auto">
 
-    {% if s.is_outdated %}
+    {% if s.is_outdated_in_git %}
     <small><div class="alert alert-secondary" role="alert">
       A <strong>newer upstream version ({{ s.upstream_version }})</strong>
       is available.<br>Consider packaging the new version for
diff --git a/app/templates/security.html b/app/templates/security.html
index 4d78975..d20acc0 100644
--- a/app/templates/security.html
+++ b/app/templates/security.html
@@ -34,7 +34,7 @@
         <tr>
           <td><a href="{{ url_for('base', base_name=s.name) }}">{{ s.name }}</a></td>
           <td>{{ s.version }}</td>
-          <td>{{ s.upstream_version if s.is_outdated else '' }}</td>
+          <td>{{ s.upstream_version if s.is_outdated_in_git else '' }}</td>
           <td class="mytooltip-onclick">
               <span role="button" class="text-{{vulnerability_color(s.worst_active_vulnerability)}}">⚠</span>
               <template class="mytooltip-content">