From 7c8f40f29dbad70dbb10e6ae6e2bd12b1dd5f9ca Mon Sep 17 00:00:00 2001 From: Sergei Zimmerman Date: Sun, 28 Dec 2025 05:18:43 +0300 Subject: [PATCH 1/2] ci: Run flake-regressions also with the newly built daemon Runs the tests against the new daemon as well as the cli. This more reliably shares the artifact (not relying directly on github actions cache). We've seen github evict our caches super fast, so it would be nice to move away from it entirely if possible. (cherry picked from commit 6eebfe62743140462af50e25a2a558c2850534eb) --- .github/workflows/ci.yml | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fe9d94248..0d70af6f6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -287,13 +287,21 @@ jobs: with: repository: NixOS/flake-regressions-data path: flake-regressions/tests - - uses: ./.github/actions/install-nix-action + - name: Download installer tarball + uses: actions/download-artifact@v7 with: - dogfood: ${{ github.event_name == 'workflow_dispatch' && inputs.dogfood || github.event_name != 'workflow_dispatch' }} - extra_nix_config: - experimental-features = nix-command flakes - github_token: ${{ secrets.GITHUB_TOKEN }} - - run: nix build -L --out-link ./new-nix && PATH=$(pwd)/new-nix/bin:$PATH MAX_FLAKES=25 flake-regressions/eval-all.sh + name: installer-linux + path: out + - name: Looking up the installer tarball URL + id: installer-tarball-url + run: | + echo "installer-url=file://$GITHUB_WORKSPACE/out" >> "$GITHUB_OUTPUT" + - uses: cachix/install-nix-action@4e002c8ec80594ecd40e759629461e26c8abed15 # v31.9.0 + with: + install_url: ${{ format('{0}/install', steps.installer-tarball-url.outputs.installer-url) }} + install_options: ${{ format('--tarball-url-prefix {0}', steps.installer-tarball-url.outputs.installer-url) }} + - name: Run flake regressions tests + run: MAX_FLAKES=25 flake-regressions/eval-all.sh profile_build: needs: tests From c9ec76276df005b18def93a30fa7b3e4379be390 Mon Sep 17 00:00:00 2001 From: Sergei Zimmerman Date: Sun, 28 Dec 2025 18:19:42 +0300 Subject: [PATCH 2/2] ci: Pin download-artifact actions sha Also bumps download-artifact to v7.0.0. (cherry picked from commit c54af23b4109252513bd90a302f111571c532e14) --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0d70af6f6..5d681a0f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -164,7 +164,7 @@ jobs: steps: - uses: actions/checkout@v6 - name: Download installer tarball - uses: actions/download-artifact@v6 + uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0 with: name: installer-${{matrix.os}} path: out @@ -288,7 +288,7 @@ jobs: repository: NixOS/flake-regressions-data path: flake-regressions/tests - name: Download installer tarball - uses: actions/download-artifact@v7 + uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0 with: name: installer-linux path: out