Files
nix/tests
John Ericson c11836126b Harden tests' bash
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.

 - `set -u` catches the use of undefined variables
 - `set -o pipefail` catches failures (like `set -e`) earlier in the
   pipeline.

This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.

There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.

To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.

`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.

`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.

`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-03-08 10:26:30 -05:00
..
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2020-04-14 18:45:06 +02:00
2023-03-08 10:26:30 -05:00
2021-07-07 10:48:47 +02:00
2019-12-13 19:05:26 +01:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2022-12-08 16:03:20 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2014-08-21 21:50:19 +02:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2022-12-06 16:36:42 +01:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2021-07-07 11:30:35 +02:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2018-02-13 14:26:19 +00:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-02-07 22:46:25 +01:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2020-07-30 16:38:04 -05:00
2023-03-08 10:26:30 -05:00
2022-03-11 10:00:19 -05:00
2023-03-08 10:26:30 -05:00
2006-07-21 13:21:43 +00:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2020-07-30 16:38:04 -05:00
2023-03-08 10:26:30 -05:00
2018-01-16 19:23:18 +01:00
2023-03-08 10:26:30 -05:00
2021-10-15 16:58:21 +02:00
2023-03-08 10:26:30 -05:00
2018-01-16 19:23:18 +01:00
2023-03-08 10:26:30 -05:00
2018-02-25 16:40:05 -06:00
2023-03-08 10:26:30 -05:00
2016-04-11 16:20:15 +02:00
2021-12-07 21:45:09 +01:00
2007-08-13 13:15:02 +00:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2012-12-04 14:47:50 +01:00
2023-03-08 10:26:30 -05:00
2023-03-08 10:26:30 -05:00
2021-04-09 23:13:08 +02:00