From 2f1aa95f4c13d23976106c9a661879d8bf92564a Mon Sep 17 00:00:00 2001 From: Prospector Date: Wed, 15 Nov 2023 17:08:55 -0800 Subject: [PATCH 1/3] Allow links in overflow menus --- docs/components/overflow-menu.md | 3 ++- lib/assets/styles/classes.scss | 3 +-- lib/components/base/Button.vue | 31 +++++++++++++++++++++++++++- lib/components/base/OverflowMenu.vue | 15 ++++++++++++-- 4 files changed, 46 insertions(+), 6 deletions(-) diff --git a/docs/components/overflow-menu.md b/docs/components/overflow-menu.md index bd80ad59c..6d8ba9967 100644 --- a/docs/components/overflow-menu.md +++ b/docs/components/overflow-menu.md @@ -14,7 +14,8 @@ }, { 'id': 'report', - 'action': () => {} + 'link': 'https://example.com/report', + 'external': true, }, { 'id': 'remain', diff --git a/lib/assets/styles/classes.scss b/lib/assets/styles/classes.scss index 00b08e624..9bf5b0d4d 100644 --- a/lib/assets/styles/classes.scss +++ b/lib/assets/styles/classes.scss @@ -447,11 +447,10 @@ a, height: 1.25rem; } - :deep(.external-icon) { + .external-icon { width: 0.75rem; height: 0.75rem; margin-bottom: auto; - margin-left: 0.25rem; margin-right: 0; } diff --git a/lib/components/base/Button.vue b/lib/components/base/Button.vue index b7f870926..de2da5ec0 100644 --- a/lib/components/base/Button.vue +++ b/lib/components/base/Button.vue @@ -53,7 +53,7 @@ const accentedButton = computed(() =>