From 21df0e32c4d592ce9f65869c06aedc8187e7e158 Mon Sep 17 00:00:00 2001
From: "Emma C. Pointer-Null" <emmaffle@modrinth.com>
Date: Tue, 24 May 2022 00:38:08 -0400
Subject: [PATCH] Fix #485 by removing default loader from version filters
 (#487)

* Fix #485 by removing default loader from version filters

It's really not our place to be imposing a default loader on people, especially as we start adding more loaders

* Fix Clear Filters button and capitalise loaders
---
 components/ui/VersionFilterControl.vue | 25 ++++++++-----------------
 1 file changed, 8 insertions(+), 17 deletions(-)

diff --git a/components/ui/VersionFilterControl.vue b/components/ui/VersionFilterControl.vue
index e9b027784..9d3770e65 100644
--- a/components/ui/VersionFilterControl.vue
+++ b/components/ui/VersionFilterControl.vue
@@ -6,7 +6,9 @@
     <Multiselect
       v-if="getValidLoaders().length > 1"
       v-model="selectedLoader"
-      :options="getValidLoaders()"
+      :options="
+        getValidLoaders().map((x) => x.charAt(0).toUpperCase() + x.slice(1))
+      "
       :multiple="false"
       :searchable="false"
       :show-no-results="false"
@@ -50,13 +52,10 @@
     />
     <button
       title="Clear filters"
-      :disabled="
-        selectedLoader === getDefaultLoader() &&
-        selectedGameVersions.length === 0
-      "
+      :disabled="selectedLoader === null && selectedGameVersions.length === 0"
       class="iconified-button"
       @click="
-        selectedLoader = getDefaultLoader()
+        selectedLoader = null
         selectedGameVersions = []
         updateVersionFilters()
       "
@@ -92,18 +91,10 @@ export default {
       cachedValidVersions: null,
       cachedValidLoaders: null,
       selectedGameVersions: [],
-      selectedLoader: this.getDefaultLoader(),
+      selectedLoader: null,
     }
   },
   methods: {
-    getDefaultLoader() {
-      const loaders = this.getValidLoaders()
-      if (loaders.includes('fabric')) {
-        return 'fabric'
-      } else {
-        return loaders[0]
-      }
-    },
     getValidVersions() {
       if (!this.cachedValidVersions) {
         this.cachedValidVersions = this.$tag.gameVersions.filter((gameVer) =>
@@ -132,9 +123,9 @@ export default {
         (projectVersion) =>
           (this.selectedGameVersions.length === 0 ||
             this.selectedGameVersions.some((gameVersion) =>
-              projectVersion.game_versions.includes(gameVersion)
+              projectVersion.game_versions.includes(gameVersion.toLowerCase())
             )) &&
-          projectVersion.loaders.includes(this.selectedLoader)
+          projectVersion.loaders.includes(this.selectedLoader.toLowerCase())
       )
       this.$emit('updateVersions', temp)
     },