From 72cbe7f90581d58b262ad5ec511bdc90eee3311a Mon Sep 17 00:00:00 2001
From: Evan Song <52982404+ferothefox@users.noreply.github.com>
Date: Tue, 5 Nov 2024 15:53:14 -0700
Subject: [PATCH] fix: unnecessary refetch of server modules on first mount
 (#2918)

Signed-off-by: Evan Song <theevansong@gmail.com>
---
 apps/frontend/src/pages/servers/manage/[id].vue | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/apps/frontend/src/pages/servers/manage/[id].vue b/apps/frontend/src/pages/servers/manage/[id].vue
index c22ff889b..5dc51646d 100644
--- a/apps/frontend/src/pages/servers/manage/[id].vue
+++ b/apps/frontend/src/pages/servers/manage/[id].vue
@@ -271,6 +271,7 @@ const socket = ref<WebSocket | null>(null);
 const isReconnecting = ref(false);
 const isLoading = ref(true);
 const reconnectInterval = ref<ReturnType<typeof setInterval> | null>(null);
+const isFirstMount = ref(true);
 const isMounted = ref(true);
 
 const route = useNativeRoute();
@@ -515,9 +516,13 @@ const newMCVersion = ref<string | null>(null);
 const handleInstallationResult = async (data: WSInstallationResultEvent) => {
   switch (data.result) {
     case "ok":
-      await server.refresh();
       if (!serverData.value) break;
       serverData.value.status = "available";
+
+      if (!isFirstMount.value) {
+        await server.refresh();
+      }
+
       if (server.general) {
         if (newLoader.value) server.general.loader = newLoader.value;
         if (newLoaderVersion.value) server.general.loader_version = newLoaderVersion.value;
@@ -575,7 +580,9 @@ const onReinstall = (potentialArgs: any) => {
     newMCVersion.value = potentialArgs.mVersion;
   }
 
-  server.refresh();
+  if (!isFirstMount.value) {
+    server.refresh();
+  }
 
   error.value = null;
   errorTitle.value = "Error";
@@ -768,6 +775,11 @@ onUnmounted(() => {
 watch(
   () => serverData.value?.status,
   (newStatus) => {
+    if (isFirstMount.value) {
+      isFirstMount.value = false;
+      return;
+    }
+
     if (newStatus === "installing") {
       startPolling();
     } else {