Allow Youtube through iframes + using image syntax in markdown (#294)

* Allow iframes in markdown from acceptable sources

* Remove Discord from allowed sources

* Make youtube regex more specific

* Fix prettier not wanting new line for regex

* Extend image syntax to autodetect youtube links

* Fix image rendering to support normal images
This commit is contained in:
venashial 2021-08-23 05:34:04 -07:00 committed by GitHub
parent e8d2959350
commit 8798340d48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -12,12 +12,50 @@ const options = {
h4: ['id'],
h5: ['id'],
h6: ['id'],
iframe: ['width', 'height', 'allowfullscreen', 'frameborder'],
},
onIgnoreTagAttr: (tag, name, value) => {
// Allow iframes from acceptable sources
if (tag === 'iframe' && name === 'src') {
const allowedSources = [
{
regex: /^https?:\/\/(www\.)?youtube\.com\/embed\/[a-zA-Z0-9_]{11}(\?&autoplay=[0-1]{1})?$/,
remove: ['&autoplay=1'], // Prevents autoplay
},
]
for (const source of allowedSources) {
if (source.regex.test(value)) {
for (const remove of source.remove) {
value = value.replace(remove, '')
}
return name + '="' + xss.escapeAttrValue(value) + '"'
}
}
}
},
}
const configuredXss = new xss.FilterXSS(options)
const headerPrefix = 'user-defined-'
const renderer = {
image(href, text) {
if (
/^https?:\/\/(www\.)?youtube\.com\/watch\?v=[a-zA-Z0-9_]{11}$/.test(href)
) {
return `<iframe width="560" height="315" src="https://www.youtube.com/embed/${href.substring(
32,
43
)}" frameborder="0" allowfullscreen></iframe>`
} else {
return `<img src="${href}" alt="${text}">`
}
},
}
marked.use({ renderer })
function compileMarkdown(target, markdown) {
target.innerHTML = configuredXss.process(marked(markdown, { headerPrefix }))
}