From 8b5db12e1d90c807c588a3fc46f225a82502d83e Mon Sep 17 00:00:00 2001
From: Emma Pointer-Null <emmaffle@modrinth.com>
Date: Sun, 6 Mar 2022 16:35:11 -0500
Subject: [PATCH] Make links on project pages more consistent, fix some
 selectors showing when they shouldn't (#391)

* Make links on project pages more consistent, fix some selectors showing when they shouldn't

* Update components/ui/VersionFilterControl.vue

Co-authored-by: Prospector <6166773+Prospector@users.noreply.github.com>

Co-authored-by: Prospector <6166773+Prospector@users.noreply.github.com>
---
 assets/styles/components.scss          |  7 +++++++
 components/ui/VersionFilterControl.vue | 11 ++++++++++-
 pages/_type/_id.vue                    |  8 +++++---
 pages/_type/_id/changelog.vue          |  2 +-
 pages/_type/_id/gallery.vue            |  3 +--
 pages/_type/_id/versions.vue           |  2 +-
 6 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/assets/styles/components.scss b/assets/styles/components.scss
index 2385be166..28cfad7e8 100644
--- a/assets/styles/components.scss
+++ b/assets/styles/components.scss
@@ -81,6 +81,13 @@
   text-decoration: underline;
 }
 
+.title-link {
+  &:hover {
+    color: var(--color-link);
+  }
+  text-decoration: underline;
+}
+
 .markdown-body {
   blockquote,
   details,
diff --git a/components/ui/VersionFilterControl.vue b/components/ui/VersionFilterControl.vue
index b71d04d8f..0df58c167 100644
--- a/components/ui/VersionFilterControl.vue
+++ b/components/ui/VersionFilterControl.vue
@@ -1,6 +1,10 @@
 <template>
-  <div class="card search-controls">
+  <div
+    v-if="getValidLoaders().length > 1 || getValidVersions().length > 1"
+    class="card search-controls"
+  >
     <Multiselect
+      v-if="getValidLoaders().length > 1"
       v-model="selectedLoaders"
       :options="getValidLoaders()"
       :multiple="true"
@@ -14,6 +18,7 @@
       @input="updateVersionFilters()"
     ></Multiselect>
     <Multiselect
+      v-if="getValidVersions().length > 1"
       v-model="selectedGameVersions"
       :options="getValidVersions()"
       :multiple="true"
@@ -27,6 +32,10 @@
       @input="updateVersionFilters()"
     ></Multiselect>
     <Checkbox
+      v-if="
+        getValidVersions().length > 1 &&
+        getValidVersions().some((v) => v.version_type !== 'release')
+      "
       v-model="showSnapshots"
       label="Include snapshots"
       description="Include snapshots"
diff --git a/pages/_type/_id.vue b/pages/_type/_id.vue
index b29459cd3..81f3de959 100644
--- a/pages/_type/_id.vue
+++ b/pages/_type/_id.vue
@@ -340,7 +340,7 @@
                 :to="`/${project.project_type}/${
                   project.slug ? project.slug : project.id
                 }/version/${encodeURIComponent(version.version_number)}`"
-                class="top"
+                class="top title-link"
               >
                 {{ version.name }}
               </nuxt-link>
@@ -380,10 +380,12 @@
           :key="member.user.id"
           class="team-member columns"
         >
-          <img :src="member.avatar_url" alt="profile-picture" />
+          <nuxt-link :to="'/user/' + member.user.username" class="name">
+            <img :src="member.avatar_url" alt="profile-picture" />
+          </nuxt-link>
           <div class="member-info">
             <nuxt-link :to="'/user/' + member.user.username" class="name">
-              <p>{{ member.name }}</p>
+              <p class="title-link">{{ member.name }}</p>
             </nuxt-link>
             <p class="role">{{ member.role }}</p>
           </div>
diff --git a/pages/_type/_id/changelog.vue b/pages/_type/_id/changelog.vue
index ad9859439..2e09daec9 100644
--- a/pages/_type/_id/changelog.vue
+++ b/pages/_type/_id/changelog.vue
@@ -10,7 +10,7 @@
         <div class="version-header">
           <span :class="'circle ' + version.version_type" />
           <div class="version-header-text">
-            <h2 class="name">
+            <h2 class="name title-link">
               <nuxt-link
                 :to="`/${project.project_type}/${
                   project.slug ? project.slug : project.id
diff --git a/pages/_type/_id/gallery.vue b/pages/_type/_id/gallery.vue
index 4e255eddd..28ccf7402 100644
--- a/pages/_type/_id/gallery.vue
+++ b/pages/_type/_id/gallery.vue
@@ -45,9 +45,8 @@
         </div>
       </div>
     </div>
-    <div class="card buttons">
+    <div v-if="currentMember" class="card buttons">
       <button
-        v-if="currentMember"
         class="iconified-button"
         @click="
           newGalleryItems.push({
diff --git a/pages/_type/_id/versions.vue b/pages/_type/_id/versions.vue
index 174ce81cd..699e1faa0 100644
--- a/pages/_type/_id/versions.vue
+++ b/pages/_type/_id/versions.vue
@@ -35,7 +35,7 @@
             </td>
             <td>
               <div class="info">
-                <div class="top">
+                <div class="top title-link">
                   <nuxt-link
                     :to="`/${project.project_type}/${
                       project.slug ? project.slug : project.id