From b83eb10fa3c2d1742eeaa7a06145b11b2f00f752 Mon Sep 17 00:00:00 2001 From: "Calum H." Date: Sat, 24 May 2025 16:50:48 +0100 Subject: [PATCH] fix: lint issues --- ...SkinRenderer.ts => batch-skin-renderer.ts} | 12 ++---------- apps/app-frontend/src/pages/Skins.vue | 4 ++-- .../components/skin/SkinPreviewRenderer.vue | 19 ++++++++----------- packages/utils/three/skin-rendering.ts | 13 +++++-------- 4 files changed, 17 insertions(+), 31 deletions(-) rename apps/app-frontend/src/helpers/rendering/{batchSkinRenderer.ts => batch-skin-renderer.ts} (96%) diff --git a/apps/app-frontend/src/helpers/rendering/batchSkinRenderer.ts b/apps/app-frontend/src/helpers/rendering/batch-skin-renderer.ts similarity index 96% rename from apps/app-frontend/src/helpers/rendering/batchSkinRenderer.ts rename to apps/app-frontend/src/helpers/rendering/batch-skin-renderer.ts index 9f8f3d952..540043cd0 100644 --- a/apps/app-frontend/src/helpers/rendering/batchSkinRenderer.ts +++ b/apps/app-frontend/src/helpers/rendering/batch-skin-renderer.ts @@ -2,10 +2,7 @@ import * as THREE from 'three' import type { Skin, Cape } from '../skins' import { determineModelType } from '../skins' import { reactive } from 'vue' -import { - setupSkinModel, - disposeCaches -} from '@modrinth/utils' +import { setupSkinModel, disposeCaches } from '@modrinth/utils' export interface RenderResult { forwards: string @@ -102,12 +99,7 @@ class BatchSkinRenderer { } // Use the utility function to setup the skin model - const { model } = await setupSkinModel( - modelUrl, - textureUrl, - capeModelUrl, - capeUrl - ) + const { model } = await setupSkinModel(modelUrl, textureUrl, capeModelUrl, capeUrl) const group = new THREE.Group() group.add(model) diff --git a/apps/app-frontend/src/pages/Skins.vue b/apps/app-frontend/src/pages/Skins.vue index 348c97d3c..f59255aeb 100644 --- a/apps/app-frontend/src/pages/Skins.vue +++ b/apps/app-frontend/src/pages/Skins.vue @@ -34,8 +34,8 @@ import { import { get as getSettings } from '@/helpers/settings.ts' import type { Cape, Skin } from '@/helpers/skins.ts' import { get_default_user, users, login as login_flow } from '@/helpers/auth' -import type { RenderResult } from '@/helpers/rendering/batchSkinRenderer.ts' -import { generateSkinPreviews, map } from '@/helpers/rendering/batchSkinRenderer.ts' +import type { RenderResult } from '@/helpers/rendering/batch-skin-renderer.ts' +import { generateSkinPreviews, map } from '@/helpers/rendering/batch-skin-renderer.ts' import { handleSevereError } from '@/store/error' import { trackEvent } from '@/helpers/analytics' import type AccountsCard from '@/components/ui/AccountsCard.vue' diff --git a/packages/ui/src/components/skin/SkinPreviewRenderer.vue b/packages/ui/src/components/skin/SkinPreviewRenderer.vue index 9f44640ed..fa0cdb5de 100644 --- a/packages/ui/src/components/skin/SkinPreviewRenderer.vue +++ b/packages/ui/src/components/skin/SkinPreviewRenderer.vue @@ -70,7 +70,7 @@ { - if (newCapeScene && bodyNode.value && isModelLoaded.value && !capeAttached.value) { - attachCapeToBodyWrapper() - } +watch(capeScene, (newCapeScene) => { + if (newCapeScene && bodyNode.value && isModelLoaded.value && !capeAttached.value) { + attachCapeToBodyWrapper() } -) +}) watch(selectedModelSrc, (src) => loadModel(src)) watch( @@ -358,7 +355,7 @@ onBeforeMount(async () => {