Bommels05/Modrinth
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tweak links nags adding project type checking for source publication check, make description nag tonally consistent.

Browse Source
This commit is contained in:
coolbot100s 2025-07-29 00:44:59 -07:00
parent 9dbc9607f7
commit ba0b09d9e3
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/moderation/data/nags/description.ts
View File

@ -81,7 +81,7 @@ export const descriptionNags: Nag[] = [
defineMessage({ defineMessage({
id: 'nags.description-too-short.description', id: 'nags.description-too-short.description',
defaultMessage: defaultMessage:
"Your description is {length} characters. It's recommended to have at least {minChars} characters to provide users with enough information about your project.", 'Your description is {length} characters. At least {minChars} characters is recommended to create a clear and informative Description.',
}), }),
{ {
length: context.project.body?.length || 0, length: context.project.body?.length || 0,

17
packages/moderation/data/nags/links.ts
View File

@ -1,10 +1,10 @@
import type { Nag, NagContext } from '../../types/nags' import type { Nag, NagContext } from '../../types/nags'
import { formatProjectType } from '@modrinth/utils' import { formatProjectType, type Project } from '@modrinth/utils'
import { useVIntl, defineMessage } from '@vintl/vintl' import { useVIntl, defineMessage } from '@vintl/vintl'
export const commonLinkDomains = { export const commonLinkDomains = {
source: ['github.com', 'gitlab.com', 'bitbucket.org', 'codeberg.org', 'git.sr.ht'], source: ['github.com', 'gitlab.com', 'bitbucket.org', 'codeberg.org', 'git.sr.ht'],
issues: ['github.com', 'gitlab.com', 'bitbucket.org', 'codeberg.org'], issues: ['github.com', 'gitlab.com', 'bitbucket.org', 'codeberg.org', 'docs.google.com'],
discord: ['discord.gg', 'discord.com'], discord: ['discord.gg', 'discord.com'],
licenseBlocklist: [ licenseBlocklist: [
'youtube.com', 'youtube.com',
@ -101,7 +101,7 @@ export const linksNags: Nag[] = [
defineMessage({ defineMessage({
id: 'nags.invalid-license-url.description.domain', id: 'nags.invalid-license-url.description.domain',
defaultMessage: defaultMessage:
'Your license URL points to {domain}, which is not appropriate for license information. License URLs should link to the actual license text or legal documentation, not social media, gaming platforms etc.', 'Your license URL points to {domain}, which is not appropriate for license information. License URLs should link directly to your license file, not social media, gaming platforms etc.',
}), }),
{ domain }, { domain },
) )
@ -142,7 +142,7 @@ export const linksNags: Nag[] = [
id: 'gpl-license-source-required', id: 'gpl-license-source-required',
title: defineMessage({ title: defineMessage({
id: 'nags.gpl-license-source-required.title', id: 'nags.gpl-license-source-required.title',
defaultMessage: 'GPL license requires source', defaultMessage: 'License requires source',
}), }),
description: (context: NagContext) => { description: (context: NagContext) => {
const { formatMessage } = useVIntl() const { formatMessage } = useVIntl()
@ -151,7 +151,7 @@ export const linksNags: Nag[] = [
defineMessage({ defineMessage({
id: 'nags.gpl-license-source-required.description', id: 'nags.gpl-license-source-required.description',
defaultMessage: defaultMessage:
'Your {projectType} uses a GPL license which requires source code to be available. Please provide a source code link or consider using a different license.', 'Your {projectType} uses a license which requires source code to be available. Please provide a source code link or sources file, or consider using a different license.',
}), }),
{ {
projectType: formatProjectType(context.project.project_type).toLowerCase(), projectType: formatProjectType(context.project.project_type).toLowerCase(),
@ -181,12 +181,17 @@ export const linksNags: Nag[] = [
'AGPL-3.0+', 'AGPL-3.0+',
'AGPL-3.0-only', 'AGPL-3.0-only',
'AGPL-3.0-or-later', 'AGPL-3.0-or-later',
'MPL-2.0',
] ]
const isGplLicense = gplLicenses.includes(context.project.license.id) const isGplLicense = gplLicenses.includes(context.project.license.id)
const hasSourceUrl = !!context.project.source_url const hasSourceUrl = !!context.project.source_url
const notSourceAsDistributed = (context) => {
let project = context.project as Project & { actualProjectType: string }
return context.project.project_type === 'mod' || project.actualProjectType === 'plugin'
}
return isGplLicense && !hasSourceUrl return isGplLicense && notSourceAsDistributed(context) && !hasSourceUrl
}, },
link: { link: {
path: 'settings/links', path: 'settings/links',