From dda469d10e38a17007a4095413d0668aded26669 Mon Sep 17 00:00:00 2001 From: Prospector <6166773+Prospector@users.noreply.github.com> Date: Mon, 29 Jan 2024 18:55:54 -0800 Subject: [PATCH] Add translations for the default page layout (#1616) * Convert default.vue to composition API * Add translations to default page layout * Generate index.json * Fix sign up page * Generate index.json * Fix atUserLabel * Fix composition API port * Follow-up fixes for #1616 (#1618) * Re-organize default layout messages - Group some of the messages by their appearance (like banners) Grouping makes avoids having to think too much about the property names, keeps declarations clean, and also can be minified better, since variable names, unlike property names, can be easily mangled. - Remove needless type specification in property name[^1] It's already clear from where the message is formatted what it does, and if you need clarification, you can Ctrl+hover and see the type in the key. - Change some keys to conform to conventions We generally follow the pattern location > kind?. Things like 'label' are unnecessary, as everything is assumed to be label by default; the same applies to things like 'button', which are also often unnecessary as they're part of the location compound. - Remove message for handle, which should not be translatable It's very unlikely user handle format changes between any of the locales. [^1]: Common messages are pending restructuring that would fix this * Fix navRoutes not being computed in default layout * Fix untranslated Get Modrinth App buttons in default layout * Make legal disclaimer in the default layout translatable It wouldn't make much sense to leave it untranslated since it is meant for the end users too. It is also so small that it's unlikely to be mistranslated. * Extract missed legal disclaimer message from default layout * Make SEO strings in default layout translatable --------- Co-authored-by: Sasha Sorokin <10401817+brawaru@users.noreply.github.com> --- layouts/default.vue | 498 ++++++++++++------ locales/en-US/index.json | 111 +++- pages/auth/sign-in.vue | 8 +- pages/auth/sign-up.vue | 6 +- pages/dashboard/projects.vue | 6 +- pages/organization/[id]/settings/projects.vue | 4 +- utils/common-messages.ts | 28 + 7 files changed, 469 insertions(+), 192 deletions(-) diff --git a/layouts/default.vue b/layouts/default.vue index 236c58ae6..b346c9e80 100644 --- a/layouts/default.vue +++ b/layouts/default.vue @@ -5,14 +5,16 @@ class="email-nag" > @@ -25,12 +27,10 @@ >
- You’re viewing Modrinth’s staging environment + {{ formatMessage(stagingBannerMessages.title) }}
- The staging environment is running on a copy of the production Modrinth database. This is - used for testing and debugging purposes, and may be running in-development versions of the - Modrinth backend or frontend newer than the production instance. + {{ formatMessage(stagingBannerMessages.description) }}
@@ -53,13 +53,13 @@ v-if="auth.user" to="/dashboard/notifications" class="control-button button-transparent" - title="Notifications" + :title="formatMessage(commonMessages.notificationsLabel)" >
- Sign in + {{ formatMessage(commonMessages.signInButton) }} - Get Modrinth App + {{ formatMessage(messages.getModrinthApp) }}
@@ -185,32 +193,32 @@