chore(clippy): enable and fix many stricter lints (#3783)

* chore(clippy): enable and fix many stricter lints

These ensure that the codebase uses more idiomatic, performant, and
concise language constructions.

* chore: make non-Clippy compiler warnings also deny by default

Cargo.toml

@@ -174,15 +174,42 @@ zip = { version = "4.0.0", default-features = false, features = [
 zxcvbn = "3.1.0"
 
 [workspace.lints.clippy]
-# Turn most warnings into errors by default
-all = { level = "deny", priority = -1 }
-clear_with_drain = "deny"
-large_stack_arrays = "deny"
-negative_feature_names = "deny"
-non_std_lazy_statics = "deny"
-read_zero_byte_vec = "deny"
-redundant_feature_names = "deny"
-wildcard_dependencies = "deny"
+bool_to_int_with_if = "warn"
+borrow_as_ptr = "warn"
+cfg_not_test = "warn"
+clear_with_drain = "warn"
+cloned_instead_of_copied = "warn"
+collection_is_never_read = "warn"
+dbg_macro = "warn"
+default_trait_access = "warn"
+explicit_iter_loop = "warn"
+filter_map_next = "warn"
+flat_map_option = "warn"
+format_push_string = "warn"
+get_unwrap = "warn"
+large_include_file = "warn"
+large_stack_arrays = "warn"
+manual_assert = "warn"
+manual_instant_elapsed = "warn"
+manual_is_variant_and = "warn"
+manual_let_else = "warn"
+map_unwrap_or = "warn"
+match_bool = "warn"
+needless_collect = "warn"
+negative_feature_names = "warn"
+non_std_lazy_statics = "warn"
+pathbuf_init_then_push = "warn"
+read_zero_byte_vec = "warn"
+redundant_clone = "warn"
+redundant_feature_names = "warn"
+redundant_type_annotations = "warn"
+todo = "warn"
+unnested_or_patterns = "warn"
+wildcard_dependencies = "warn"
+
+[workspace.lints.rust]
+# Turn warnings into errors by default
+warnings = "deny"
 
 [patch.crates-io]
 wry = { git = "https://github.com/modrinth/wry", rev = "cafdaa9" }

apps/app/src/api/utils.rs

@@ -37,6 +37,7 @@ pub fn get_os() -> OS {
     let os = OS::MacOS;
     os
 }
+
 #[derive(Debug, Clone, Serialize, Deserialize)]
 #[allow(clippy::enum_variant_names)]
 pub enum OS {

apps/app/src/api/worlds.rs

@@ -43,7 +43,7 @@ pub async fn get_recent_worlds<R: Runtime>(
         display_statuses.unwrap_or(EnumSet::all()),
     )
     .await?;
-    for world in result.iter_mut() {
+    for world in &mut result {
         adapt_world_icon(&app_handle, &mut world.world);
     }
     Ok(result)
@@ -55,7 +55,7 @@ pub async fn get_profile_worlds<R: Runtime>(
     path: &str,
 ) -> Result<Vec<World>> {
     let mut result = worlds::get_profile_worlds(path).await?;
-    for world in result.iter_mut() {
+    for world in &mut result {
         adapt_world_icon(&app_handle, world);
     }
     Ok(result)

apps/app/src/main.rs

@@ -229,7 +229,6 @@ fn main() {
                 tauri::async_runtime::spawn(api::utils::handle_command(
                     payload,
                 ));
-                dbg!(url);
             });
 
             #[cfg(not(target_os = "linux"))]
@@ -273,8 +272,9 @@ fn main() {
 
     match app {
         Ok(app) => {
-            #[allow(unused_variables)]
             app.run(|app, event| {
+                #[cfg(not(target_os = "macos"))]
+                drop((app, event));
                 #[cfg(target_os = "macos")]
                 if let tauri::RunEvent::Opened { urls } = event {
                     tracing::info!("Handling webview open {urls:?}");

apps/daedalus_client/src/minecraft.rs

@@ -52,8 +52,7 @@ pub async fn fetch(
                     if modrinth_version
                         .original_sha1
                         .as_ref()
-                        .map(|x| x == &version.sha1)
-                        .unwrap_or(false)
+                        .is_some_and(|x| x == &version.sha1)
                     {
                         existing_versions.push(modrinth_version);
                     } else {

apps/labrinth/src/auth/checks.rs

@@ -100,10 +100,7 @@ pub async fn filter_visible_project_ids(
             project.status.is_searchable()
         } else {
             !project.status.is_hidden()
-        }) || user_option
-            .as_ref()
-            .map(|x| x.role.is_mod())
-            .unwrap_or(false)
+        }) || user_option.as_ref().is_some_and(|x| x.role.is_mod())
         {
             return_projects.push(project.id);
         } else if user_option.is_some() {
@@ -158,7 +155,7 @@ pub async fn filter_enlisted_projects_ids(
         )
         .fetch(pool)
         .map_ok(|row| {
-            for x in projects.iter() {
+            for x in &projects {
                 let bool =
                     Some(x.id.0) == row.id && Some(x.team_id.0) == row.team_id;
                 if bool {
@@ -238,7 +235,6 @@ pub async fn filter_visible_version_ids(
     redis: &RedisPool,
 ) -> Result<Vec<crate::database::models::DBVersionId>, ApiError> {
     let mut return_versions = Vec::new();
-    let mut check_versions = Vec::new();
 
     // First, filter out versions belonging to projects we can't see
     // (ie: a hidden project, but public version, should still be hidden)
@@ -271,15 +267,10 @@ pub async fn filter_visible_version_ids(
         // - we are enlisted on the team of the mod
         if (!version.status.is_hidden()
             && visible_project_ids.contains(&version.project_id))
-            || user_option
-                .as_ref()
-                .map(|x| x.role.is_mod())
-                .unwrap_or(false)
+            || user_option.as_ref().is_some_and(|x| x.role.is_mod())
             || enlisted_version_ids.contains(&version.id)
         {
             return_versions.push(version.id);
-        } else if user_option.is_some() {
-            check_versions.push(version);
         }
     }
 
@@ -310,10 +301,7 @@ pub async fn filter_enlisted_version_ids(
     .await?;
 
     for version in versions {
-        if user_option
-            .as_ref()
-            .map(|x| x.role.is_mod())
-            .unwrap_or(false)
+        if user_option.as_ref().is_some_and(|x| x.role.is_mod())
             || (user_option.is_some()
                 && authorized_project_ids.contains(&version.project_id))
         {
@@ -349,10 +337,7 @@ pub async fn filter_visible_collections(
 
     for collection in collections {
         if !collection.status.is_hidden()
-            || user_option
-                .as_ref()
-                .map(|x| x.role.is_mod())
-                .unwrap_or(false)
+            || user_option.as_ref().is_some_and(|x| x.role.is_mod())
         {
             return_collections.push(collection.into());
         } else if user_option.is_some() {

apps/labrinth/src/auth/oauth/mod.rs

@@ -1,3 +1,5 @@
+use std::fmt::Write;
+
 use crate::auth::get_user_from_headers;
 use crate::auth::oauth::uris::{OAuthRedirectUris, ValidatedRedirectUri};
 use crate::auth::validate::extract_authorization_header;
@@ -17,7 +19,7 @@ use crate::queue::session::AuthQueue;
 use actix_web::http::header::{CACHE_CONTROL, LOCATION, PRAGMA};
 use actix_web::web::{Data, Query, ServiceConfig};
 use actix_web::{HttpRequest, HttpResponse, get, post, web};
-use chrono::Duration;
+use chrono::{DateTime, Duration};
 use rand::distributions::Alphanumeric;
 use rand::{Rng, SeedableRng};
 use rand_chacha::ChaCha20Rng;
@@ -280,8 +282,8 @@ pub async fn request_token(
                 authorization_id,
                 token_hash,
                 scopes,
-                created: Default::default(),
-                expires: Default::default(),
+                created: DateTime::default(),
+                expires: DateTime::default(),
                 last_used: None,
                 client_id,
                 user_id,
@@ -456,7 +458,7 @@ fn append_params_to_uri(uri: &str, params: &[impl AsRef<str>]) -> String {
     let mut uri = uri.to_string();
     let mut connector = if uri.contains('?') { "&" } else { "?" };
     for param in params {
-        uri.push_str(&format!("{}{}", connector, param.as_ref()));
+        write!(&mut uri, "{connector}{}", param.as_ref()).unwrap();
         connector = "&";
     }
 

apps/labrinth/src/auth/validate.rs

@@ -93,12 +93,11 @@ where
                     .await?;
 
             let rate_limit_ignore = dotenvy::var("RATE_LIMIT_IGNORE_KEY")?;
-            if !req
+            if req
                 .headers()
                 .get("x-ratelimit-key")
                 .and_then(|x| x.to_str().ok())
-                .map(|x| x == rate_limit_ignore)
-                .unwrap_or(false)
+                .is_none_or(|x| x != rate_limit_ignore)
             {
                 let metadata = get_session_metadata(req).await?;
                 session_queue.add_session(session.id, metadata).await;
@@ -130,7 +129,7 @@ where
 
             user.map(|u| (access_token.scopes, u))
         }
-        Some(("github", _)) | Some(("gho", _)) | Some(("ghp", _)) => {
+        Some(("github" | "gho" | "ghp", _)) => {
             let user = AuthProvider::GitHub.get_user(token).await?;
             let id =
                 AuthProvider::GitHub.get_user_id(&user.id, executor).await?;

apps/labrinth/src/database/models/friend_item.rs

@@ -105,7 +105,7 @@ impl DBFriend {
             created: row.created,
             accepted: row.accepted,
         })
-        .filter(|x| accepted.map(|y| y == x.accepted).unwrap_or(true))
+        .filter(|x| accepted.is_none_or(|y| y == x.accepted))
         .collect::<Vec<_>>();
 
         Ok(friends)

apps/labrinth/src/database/models/loader_fields.rs

@@ -675,7 +675,7 @@ impl LoaderFieldEnumValue {
             .into_iter()
             .filter(|x| {
                 let mut bool = true;
-                for (key, value) in filter.iter() {
+                for (key, value) in &filter {
                     if let Some(metadata_value) = x.metadata.get(key) {
                         bool &= metadata_value == value;
                     } else {
@@ -713,7 +713,7 @@ impl VersionField {
                     query_version_fields.push(base.clone().with_string_value(s))
                 }
                 VersionFieldValue::Boolean(b) => query_version_fields
-                    .push(base.clone().with_int_value(if b { 1 } else { 0 })),
+                    .push(base.clone().with_int_value(b as i32)),
                 VersionFieldValue::ArrayInteger(v) => {
                     for i in v {
                         query_version_fields
@@ -728,9 +728,8 @@ impl VersionField {
                 }
                 VersionFieldValue::ArrayBoolean(v) => {
                     for b in v {
-                        query_version_fields.push(
-                            base.clone().with_int_value(if b { 1 } else { 0 }),
-                        );
+                        query_version_fields
+                            .push(base.clone().with_int_value(b as i32));
                     }
                 }
                 VersionFieldValue::Enum(_, v) => query_version_fields
@@ -757,7 +756,7 @@ impl VersionField {
                     l.field_id.0,
                     l.version_id.0,
                     l.int_value,
-                    l.enum_value.as_ref().map(|e| e.0).unwrap_or(-1),
+                    l.enum_value.as_ref().map_or(-1, |e| e.0),
                     l.string_value.clone(),
                 )
             })
@@ -849,12 +848,11 @@ impl VersionField {
         query_loader_fields
             .iter()
             .flat_map(|q| {
-                let loader_field_type = match LoaderFieldType::build(
+                let Some(loader_field_type) = LoaderFieldType::build(
                     &q.field_type,
                     q.enum_type.map(|l| l.0),
-                ) {
-                    Some(lft) => lft,
-                    None => return vec![],
+                ) else {
+                    return vec![];
                 };
                 let loader_field = LoaderField {
                     id: q.id,
@@ -1085,23 +1083,17 @@ impl VersionFieldValue {
         };
 
         // Check errors- version_id must all be the same
+        // If the field type is a non-array, then the reason for multiple version ids is that there are multiple versions being aggregated, and those version ids are contained within.
+        // If the field type is an array, then the reason for multiple version ids is that there are multiple values for a single version
+        // (or a greater aggregation between multiple arrays, in which case the per-field version is lost, so we just take the first one and use it for that)
         let version_id = qvfs
             .iter()
             .map(|qvf| qvf.version_id)
             .unique()
-            .collect::<Vec<_>>();
-        // If the field type is a non-array, then the reason for multiple version ids is that there are multiple versions being aggregated, and those version ids are contained within.
-        // If the field type is an array, then the reason for multiple version ids is that there are multiple values for a single version
-        // (or a greater aggregation between multiple arrays, in which case the per-field version is lost, so we just take the first one and use it for that)
-        let version_id =
-            version_id.into_iter().next().unwrap_or(DBVersionId(0));
+            .next()
+            .unwrap_or(DBVersionId(0));
 
-        let field_id = qvfs
-            .iter()
-            .map(|qvf| qvf.field_id)
-            .unique()
-            .collect::<Vec<_>>();
-        if field_id.len() > 1 {
+        if qvfs.iter().map(|qvf| qvf.field_id).unique().count() > 1 {
             return Err(DatabaseError::SchemaError(format!(
                 "Multiple field ids for field {field_name}"
             )));
@@ -1274,7 +1266,7 @@ impl VersionFieldValue {
         };
 
         // Sort arrayenums by ordering, then by created
-        for (_, v) in value.iter_mut() {
+        for (_, v) in &mut value {
             if let VersionFieldValue::ArrayEnum(_, v) = v {
                 v.sort_by(|a, b| {
                     a.ordering.cmp(&b.ordering).then(a.created.cmp(&b.created))
@@ -1317,8 +1309,8 @@ impl VersionFieldValue {
         }
     }
 
-    // For conversion to an interanl string(s), such as for search facets, filtering, or direct hardcoding
-    // No matter the type, it will be converted to a Vec<String>, whre the non-array types will have a single element
+    // For conversion to an internal string(s), such as for search facets, filtering, or direct hardcoding
+    // No matter the type, it will be converted to a Vec<String>, where the non-array types will have a single element
     pub fn as_strings(&self) -> Vec<String> {
         match self {
             VersionFieldValue::Integer(i) => vec![i.to_string()],
@@ -1343,22 +1335,19 @@ impl VersionFieldValue {
             VersionFieldValue::Integer(i) => value.as_i64() == Some(*i as i64),
             VersionFieldValue::Text(s) => value.as_str() == Some(s),
             VersionFieldValue::Boolean(b) => value.as_bool() == Some(*b),
-            VersionFieldValue::ArrayInteger(v) => value
-                .as_i64()
-                .map(|i| v.contains(&(i as i32)))
-                .unwrap_or(false),
-            VersionFieldValue::ArrayText(v) => value
-                .as_str()
-                .map(|s| v.contains(&s.to_string()))
-                .unwrap_or(false),
+            VersionFieldValue::ArrayInteger(v) => {
+                value.as_i64().is_some_and(|i| v.contains(&(i as i32)))
+            }
+            VersionFieldValue::ArrayText(v) => {
+                value.as_str().is_some_and(|s| v.contains(&s.to_string()))
+            }
             VersionFieldValue::ArrayBoolean(v) => {
-                value.as_bool().map(|b| v.contains(&b)).unwrap_or(false)
+                value.as_bool().is_some_and(|b| v.contains(&b))
             }
             VersionFieldValue::Enum(_, v) => value.as_str() == Some(&v.value),
             VersionFieldValue::ArrayEnum(_, v) => value
                 .as_str()
-                .map(|s| v.iter().any(|v| v.value == s))
-                .unwrap_or(false),
+                .is_some_and(|s| v.iter().any(|v| v.value == s)),
         }
     }
 }

apps/labrinth/src/database/models/organization_item.rs

@@ -122,7 +122,7 @@ impl DBOrganization {
                 |ids| async move {
                     let org_ids: Vec<i64> = ids
                         .iter()
-                        .flat_map(|x| parse_base62(&x.to_string()).ok())
+                        .filter_map(|x| parse_base62(&x.to_string()).ok())
                         .map(|x| x as i64)
                         .collect();
                     let slugs = ids

apps/labrinth/src/database/models/pat_item.rs

@@ -108,7 +108,7 @@ impl DBPersonalAccessToken {
                 |ids| async move {
                     let pat_ids: Vec<i64> = ids
                         .iter()
-                        .flat_map(|x| parse_base62(&x.to_string()).ok())
+                        .filter_map(|x| parse_base62(&x.to_string()).ok())
                         .map(|x| x as i64)
                         .collect();
                     let slugs = ids.into_iter().map(|x| x.to_string()).collect::<Vec<_>>();

apps/labrinth/src/database/models/project_item.rs

@@ -545,7 +545,7 @@ impl DBProject {
                 let mut exec = exec.acquire().await?;
                 let project_ids_parsed: Vec<i64> = ids
                     .iter()
-                    .flat_map(|x| parse_base62(&x.to_string()).ok())
+                    .filter_map(|x| parse_base62(&x.to_string()).ok())
                     .map(|x| x as i64)
                     .collect();
                 let slugs = ids
@@ -723,7 +723,7 @@ impl DBProject {
 
                         // Add loader fields to the set we need to fetch
                         let loader_loader_field_ids = m.loader_fields.unwrap_or_default().into_iter().map(LoaderFieldId).collect::<Vec<_>>();
-                        for loader_field_id in loader_loader_field_ids.iter() {
+                        for loader_field_id in &loader_loader_field_ids {
                             loader_field_ids.insert(*loader_field_id);
                         }
 

apps/labrinth/src/database/models/session_item.rs

@@ -153,7 +153,7 @@ impl DBSession {
             |ids| async move {
                 let session_ids: Vec<i64> = ids
                     .iter()
-                    .flat_map(|x| parse_base62(&x.to_string()).ok())
+                    .filter_map(|x| parse_base62(&x.to_string()).ok())
                     .map(|x| x as i64)
                     .collect();
                 let slugs = ids

apps/labrinth/src/database/models/team_item.rs

@@ -45,7 +45,7 @@ impl TeamBuilder {
         .await?;
 
         let mut team_member_ids = Vec::new();
-        for _ in self.members.iter() {
+        for _ in &self.members {
             team_member_ids.push(generate_team_member_id(transaction).await?.0);
         }
         let TeamBuilder { members } = self;

apps/labrinth/src/database/models/user_item.rs

@@ -163,7 +163,7 @@ impl DBUser {
             |ids| async move {
                 let user_ids: Vec<i64> = ids
                     .iter()
-                    .flat_map(|x| parse_base62(&x.to_string()).ok())
+                    .filter_map(|x| parse_base62(&x.to_string()).ok())
                     .map(|x| x as i64)
                     .collect();
                 let slugs = ids

apps/labrinth/src/database/models/version_item.rs

@@ -52,7 +52,7 @@ impl DependencyBuilder {
         transaction: &mut sqlx::Transaction<'_, sqlx::Postgres>,
     ) -> Result<(), DatabaseError> {
         let mut project_ids = Vec::new();
-        for dependency in builders.iter() {
+        for dependency in &builders {
             project_ids.push(
                 dependency
                     .try_get_project_id(transaction)
@@ -333,9 +333,7 @@ impl DBVersion {
     ) -> Result<Option<()>, DatabaseError> {
         let result = Self::get(id, &mut **transaction, redis).await?;
 
-        let result = if let Some(result) = result {
-            result
-        } else {
+        let Some(result) = result else {
             return Ok(None);
         };
 
@@ -550,7 +548,7 @@ impl DBVersion {
 
                         // Add loader fields to the set we need to fetch
                         let loader_loader_field_ids = m.loader_fields.unwrap_or_default().into_iter().map(LoaderFieldId).collect::<Vec<_>>();
-                        for loader_field_id in loader_loader_field_ids.iter() {
+                        for loader_field_id in &loader_loader_field_ids {
                             loader_field_ids.insert(*loader_field_id);
                         }
 
@@ -756,7 +754,7 @@ impl DBVersion {
                                 let mut files = files.into_iter().map(|x| {
                                     let mut file_hashes = HashMap::new();
 
-                                    for hash in hashes.iter() {
+                                    for hash in &hashes {
                                         if hash.file_id == x.id {
                                             file_hashes.insert(
                                                 hash.algorithm.clone(),
@@ -852,7 +850,7 @@ impl DBVersion {
                     ORDER BY v.date_published
                     ",
                     algorithm,
-                    &file_ids.into_iter().flat_map(|x| x.split('_').last().map(|x| x.as_bytes().to_vec())).collect::<Vec<_>>(),
+                    &file_ids.into_iter().filter_map(|x| x.split('_').last().map(|x| x.as_bytes().to_vec())).collect::<Vec<_>>(),
                 )
                     .fetch(executor)
                     .try_fold(DashMap::new(), |acc, f| {
@@ -1042,14 +1040,14 @@ mod tests {
             date_published,
             project_id: DBProjectId(0),
             author_id: DBUserId(0),
-            name: Default::default(),
-            version_number: Default::default(),
-            changelog: Default::default(),
-            downloads: Default::default(),
-            version_type: Default::default(),
-            featured: Default::default(),
+            name: String::new(),
+            version_number: String::new(),
+            changelog: String::new(),
+            downloads: 0,
+            version_type: String::new(),
+            featured: false,
             status: VersionStatus::Listed,
-            requested_status: Default::default(),
+            requested_status: None,
         }
     }
 }

apps/labrinth/src/database/redis.rs

@@ -3,6 +3,7 @@ use ariadne::ids::base62_impl::{parse_base62, to_base62};
 use chrono::{TimeZone, Utc};
 use dashmap::DashMap;
 use deadpool_redis::{Config, Runtime};
+use futures::future::Either;
 use prometheus::{IntGauge, Registry};
 use redis::{Cmd, ExistenceCheck, SetExpiry, SetOptions, cmd};
 use serde::de::DeserializeOwned;
@@ -11,7 +12,6 @@ use std::collections::HashMap;
 use std::fmt::{Debug, Display};
 use std::future::Future;
 use std::hash::Hash;
-use std::pin::Pin;
 use std::time::Duration;
 
 const DEFAULT_EXPIRY: i64 = 60 * 60 * 12; // 12 hours
@@ -378,22 +378,10 @@ impl RedisPool {
             }
         }
 
-        #[allow(clippy::type_complexity)]
-        let mut fetch_tasks: Vec<
-            Pin<
-                Box<
-                    dyn Future<
-                        Output = Result<
-                            HashMap<K, RedisValue<T, K, S>>,
-                            DatabaseError,
-                        >,
-                    >,
-                >,
-            >,
-        > = Vec::new();
+        let mut fetch_tasks = Vec::new();
 
         if !ids.is_empty() {
-            fetch_tasks.push(Box::pin(async {
+            fetch_tasks.push(Either::Left(async {
                 let fetch_ids =
                     ids.iter().map(|x| x.value().clone()).collect::<Vec<_>>();
 
@@ -491,7 +479,7 @@ impl RedisPool {
         }
 
         if !subscribe_ids.is_empty() {
-            fetch_tasks.push(Box::pin(async {
+            fetch_tasks.push(Either::Right(async {
                 let mut interval =
                     tokio::time::interval(Duration::from_millis(100));
                 let start = Utc::now();

apps/labrinth/src/lib.rs

@@ -313,13 +313,16 @@ pub fn app_config(
     .app_data(labrinth_config.automated_moderation_queue.clone())
     .app_data(web::Data::new(labrinth_config.stripe_client.clone()))
     .app_data(labrinth_config.rate_limiter.clone())
-    .configure(
-        #[allow(unused_variables)]
-        |cfg| {
-            #[cfg(target_os = "linux")]
-            routes::debug::config(cfg)
-        },
-    )
+    .configure({
+        #[cfg(target_os = "linux")]
+        {
+            |cfg| routes::debug::config(cfg)
+        }
+        #[cfg(not(target_os = "linux"))]
+        {
+            |_cfg| ()
+        }
+    })
     .configure(routes::v2::config)
     .configure(routes::v3::config)
     .configure(routes::internal::config)

apps/labrinth/src/main.rs

@@ -8,6 +8,7 @@ use labrinth::file_hosting::S3Host;
 use labrinth::search;
 use labrinth::util::ratelimit::rate_limit_middleware;
 use labrinth::{check_env_vars, clickhouse, database, file_hosting, queue};
+use std::ffi::CStr;
 use std::sync::Arc;
 use tracing::{error, info};
 use tracing_actix_web::TracingLogger;
@@ -16,10 +17,8 @@ use tracing_actix_web::TracingLogger;
 #[global_allocator]
 static ALLOC: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;
 
-#[allow(non_upper_case_globals)]
 #[unsafe(export_name = "malloc_conf")]
-pub static malloc_conf: &[u8] =
-    b"prof:true,prof_active:true,lg_prof_sample:19\0";
+pub static MALLOC_CONF: &CStr = c"prof:true,prof_active:true,lg_prof_sample:19";
 
 #[derive(Clone)]
 pub struct Pepper {

apps/labrinth/src/models/v3/projects.rs

@@ -122,7 +122,7 @@ pub fn from_duplicate_version_fields(
     }
 
     // Remove duplicates
-    for (_, v) in fields.iter_mut() {
+    for v in fields.values_mut() {
         *v = mem::take(v).into_iter().unique().collect_vec();
     }
     fields

apps/labrinth/src/queue/moderation.rs

@@ -16,6 +16,7 @@ use serde::{Deserialize, Serialize};
 use sha1::Digest;
 use sqlx::PgPool;
 use std::collections::HashMap;
+use std::fmt::Write;
 use std::io::{Cursor, Read};
 use std::time::Duration;
 use zip::ZipArchive;
@@ -33,29 +34,31 @@ impl ModerationMessages {
     }
 
     pub fn markdown(&self, auto_mod: bool) -> String {
-        let mut str = "".to_string();
+        let mut str = String::new();
 
         for message in &self.messages {
-            str.push_str(&format!("## {}\n", message.header()));
-            str.push_str(&format!("{}\n", message.body()));
-            str.push('\n');
+            write!(&mut str, "## {}\n{}\n\n", message.header(), message.body())
+                .unwrap();
         }
 
         for (version_num, messages) in &self.version_specific {
             for message in messages {
-                str.push_str(&format!(
-                    "## Version {}: {}\n",
+                write!(
+                    &mut str,
+                    "### Version {}: {}\n{}\n\n",
                     version_num,
-                    message.header()
-                ));
-                str.push_str(&format!("{}\n", message.body()));
-                str.push('\n');
+                    message.header(),
+                    message.body()
+                )
+                .unwrap();
             }
         }
 
         if auto_mod {
-            str.push_str("<hr />\n\n");
-            str.push_str("🤖 This is an automated message generated by AutoMod (BETA). If you are facing issues, please [contact support](https://support.modrinth.com).");
+            str.push_str(
+                "<hr />\n\n\
+                🤖 This is an automated message generated by AutoMod (BETA). If you are facing issues, please [contact support](https://support.modrinth.com)."
+            );
         }
 
         str
@@ -146,14 +149,13 @@ impl ModerationMessage {
         match self {
             ModerationMessage::NoPrimaryFile => "Please attach a file to this version. All files on Modrinth must have files associated with their versions.\n".to_string(),
             ModerationMessage::PackFilesNotAllowed { files, .. } => {
-                let mut str = "".to_string();
-                str.push_str("This pack redistributes copyrighted material. Please refer to [Modrinth's guide on obtaining modpack permissions](https://support.modrinth.com/en/articles/8797527-obtaining-modpack-permissions) for more information.\n\n");
+                let mut str = String::from("This pack redistributes copyrighted material. Please refer to [Modrinth's guide on obtaining modpack permissions](https://support.modrinth.com/en/articles/8797527-obtaining-modpack-permissions) for more information.\n\n");
 
                 let mut attribute_mods = Vec::new();
                 let mut no_mods = Vec::new();
                 let mut permanent_no_mods = Vec::new();
                 let mut unidentified_mods = Vec::new();
-                for (_, approval) in files.iter() {
+                for approval in files.values() {
                     match approval.status {
                         ApprovalType::Yes | ApprovalType::WithAttributionAndSource  => {}
                         ApprovalType::WithAttribution => attribute_mods.push(&approval.file_name),
@@ -166,7 +168,7 @@ impl ModerationMessage {
                 fn print_mods(projects: Vec<&String>, headline: &str, val: &mut String) {
                     if projects.is_empty() { return }
 
-                    val.push_str(&format!("{headline}\n\n"));
+                    write!(val, "{headline}\n\n").unwrap();
 
                     for project in &projects {
                         let additional_text = if project.contains("ftb-quests") {
@@ -181,11 +183,11 @@ impl ModerationMessage {
                             None
                         };
 
-                        val.push_str(&if let Some(additional_text) = additional_text {
-                            format!("- {project} (consider using [{}](https://modrinth.com/project/{}) instead)\n", additional_text.0, additional_text.1)
+                        if let Some(additional_text) = additional_text {
+                            writeln!(val, "- {project} (consider using [{}](https://modrinth.com/project/{}) instead)", additional_text.0, additional_text.1).unwrap();
                         } else {
-                            format!("- {project}\n")
-                        })
+                            writeln!(val, "- {project}").unwrap();
+                        }
                     }
 
                     if !projects.is_empty() {
@@ -278,10 +280,7 @@ impl AutomatedModerationQueue {
                                     let mut zip = ZipArchive::new(reader)?;
 
                                     let pack: PackFormat = {
-                                        let mut file =
-                                            if let Ok(file) = zip.by_name("modrinth.index.json") {
-                                                file
-                                            } else {
+                                        let Ok(mut file) = zip.by_name("modrinth.index.json") else {
                                                 continue;
                                             };
 
@@ -301,7 +300,7 @@ impl AutomatedModerationQueue {
                                         .files
                                         .clone()
                                         .into_iter()
-                                        .flat_map(|x| {
+                                        .filter_map(|x| {
                                             let hash = x.hashes.get(&PackFileHash::Sha1);
 
                                             if let Some(hash) = hash {
@@ -397,8 +396,8 @@ impl AutomatedModerationQueue {
                                             ",
                                             serde_json::to_value(&MissingMetadata {
                                                 identified: final_hashes,
-                                                flame_files: Default::default(),
-                                                unknown_files: Default::default(),
+                                                flame_files: HashMap::new(),
+                                                unknown_files: HashMap::new(),
                                             })?,
                                             primary_file.id.0
                                         )
@@ -432,8 +431,8 @@ impl AutomatedModerationQueue {
                                     if hashes.is_empty() {
                                         let metadata = MissingMetadata {
                                             identified: final_hashes,
-                                            flame_files: Default::default(),
-                                            unknown_files: Default::default(),
+                                            flame_files: HashMap::new(),
+                                            unknown_files: HashMap::new(),
                                         };
 
                                         sqlx::query!(
@@ -533,8 +532,8 @@ impl AutomatedModerationQueue {
                                     if hashes.is_empty() {
                                         let metadata = MissingMetadata {
                                             identified: final_hashes,
-                                            flame_files: Default::default(),
-                                            unknown_files: Default::default(),
+                                            flame_files: HashMap::new(),
+                                            unknown_files: HashMap::new(),
                                         };
 
                                         sqlx::query!(
@@ -622,8 +621,7 @@ impl AutomatedModerationQueue {
 
                             if !mod_messages.is_empty() {
                                 let first_time = database::models::DBThread::get(project.thread_id, &pool).await?
-                                    .map(|x| x.messages.iter().all(|x| x.author_id == Some(database::models::DBUserId(AUTOMOD_ID)) || x.hide_identity))
-                                    .unwrap_or(true);
+                                    .is_none_or(|x| x.messages.iter().all(|x| x.author_id == Some(database::models::DBUserId(AUTOMOD_ID)) || x.hide_identity));
 
                                 let mut transaction = pool.begin().await?;
                                 let id = ThreadMessageBuilder {
@@ -733,10 +731,12 @@ impl AutomatedModerationQueue {
                         if let Err(err) = res {
                             let err = err.as_api_error();
 
-                            let mut str = String::new();
-                            str.push_str("## Internal AutoMod Error\n\n");
-                            str.push_str(&format!("Error code: {}\n\n", err.error));
-                            str.push_str(&format!("Error description: {}\n\n", err.description));
+                            let str = format!(
+                                "## Internal AutoMod Error\n\n\
+                                Error code: {}\n\n\
+                                Error description: {}\n\n",
+                                err.error, err.description
+                            );
 
                             let mut transaction = pool.begin().await?;
                             ThreadMessageBuilder {

apps/labrinth/src/queue/payouts.rs

@@ -441,8 +441,8 @@ impl PayoutsQueue {
                         }
                     } else {
                         PayoutMethodFee {
-                            percentage: Default::default(),
-                            min: Default::default(),
+                            percentage: Decimal::default(),
+                            min: Decimal::default(),
                             max: None,
                         }
                     },
@@ -833,7 +833,7 @@ pub async fn process_payout(
         .map(|x| (x.project_id, x.page_views))
         .collect::<HashMap<u64, u64>>();
 
-    for (key, value) in downloads_values.iter() {
+    for (key, value) in &downloads_values {
         let counter = views_values.entry(*key).or_insert(0);
         *counter += *value;
     }

apps/labrinth/src/routes/analytics.rs

@@ -216,7 +216,7 @@ pub async fn playtime_ingest(
                 version_id: version.inner.id.0 as u64,
                 loader: playtime.loader,
                 game_version: playtime.game_version,
-                parent: playtime.parent.map(|x| x.0).unwrap_or(0),
+                parent: playtime.parent.map_or(0, |x| x.0),
             });
         }
     }

apps/labrinth/src/routes/internal/admin.rs

@@ -18,6 +18,7 @@ use actix_web::{HttpRequest, HttpResponse, get, patch, post, web};
 use serde::Deserialize;
 use sqlx::PgPool;
 use std::collections::HashMap;
+use std::fmt::Write;
 use std::net::Ipv4Addr;
 use std::sync::Arc;
 use tracing::info;
@@ -221,9 +222,11 @@ pub async fn delphi_result_ingest(
 
     for (issue, trace) in &body.issues {
         for (path, code) in trace {
-            header.push_str(&format!(
+            write!(
+                &mut header,
                 "\n issue {issue} found at file {path}: \n ```\n{code}\n```"
-            ));
+            )
+            .unwrap();
         }
     }
 
@@ -244,12 +247,15 @@ pub async fn delphi_result_ingest(
 
     for (issue, trace) in &body.issues {
         for path in trace.keys() {
-            thread_header
-                .push_str(&format!("\n\n- issue {issue} found at file {path}"));
+            write!(
+                &mut thread_header,
+                "\n\n- issue {issue} found at file {path}"
+            )
+            .unwrap();
         }
 
         if trace.is_empty() {
-            thread_header.push_str(&format!("\n\n- issue {issue} found",));
+            write!(&mut thread_header, "\n\n- issue {issue} found").unwrap();
         }
     }
 

apps/labrinth/src/routes/internal/billing.rs

@@ -531,11 +531,9 @@ pub async fn edit_subscription(
 
                 if let Some(payment_method) = &edit_subscription.payment_method
                 {
-                    let payment_method_id = if let Ok(id) =
+                    let Ok(payment_method_id) =
                         PaymentMethodId::from_str(payment_method)
-                    {
-                        id
-                    } else {
+                    else {
                         return Err(ApiError::InvalidInput(
                             "Invalid payment method id".to_string(),
                         ));
@@ -743,9 +741,7 @@ pub async fn edit_payment_method(
 
     let (id,) = info.into_inner();
 
-    let payment_method_id = if let Ok(id) = PaymentMethodId::from_str(&id) {
-        id
-    } else {
+    let Ok(payment_method_id) = PaymentMethodId::from_str(&id) else {
         return Err(ApiError::NotFound);
     };
 
@@ -766,10 +762,7 @@ pub async fn edit_payment_method(
     )
     .await?;
 
-    if payment_method
-        .customer
-        .map(|x| x.id() == customer)
-        .unwrap_or(false)
+    if payment_method.customer.is_some_and(|x| x.id() == customer)
         || user.role.is_admin()
     {
         stripe::Customer::update(
@@ -812,9 +805,7 @@ pub async fn remove_payment_method(
 
     let (id,) = info.into_inner();
 
-    let payment_method_id = if let Ok(id) = PaymentMethodId::from_str(&id) {
-        id
-    } else {
+    let Ok(payment_method_id) = PaymentMethodId::from_str(&id) else {
         return Err(ApiError::NotFound);
     };
 
@@ -864,10 +855,7 @@ pub async fn remove_payment_method(
         }
     }
 
-    if payment_method
-        .customer
-        .map(|x| x.id() == customer)
-        .unwrap_or(false)
+    if payment_method.customer.is_some_and(|x| x.id() == customer)
         || user.role.is_admin()
     {
         stripe::PaymentMethod::detach(&stripe_client, &payment_method_id)
@@ -1437,8 +1425,6 @@ pub async fn stripe_webhook(
             pub user_subscription_item:
                 Option<user_subscription_item::DBUserSubscription>,
             pub payment_metadata: Option<PaymentRequestMetadata>,
-            #[allow(dead_code)]
-            pub charge_type: ChargeType,
         }
 
         #[allow(clippy::too_many_arguments)]
@@ -1453,24 +1439,20 @@ pub async fn stripe_webhook(
             transaction: &mut Transaction<'_, Postgres>,
         ) -> Result<PaymentIntentMetadata, ApiError> {
             'metadata: {
-                let user_id = if let Some(user_id) = metadata
+                let Some(user_id) = metadata
                     .get("modrinth_user_id")
                     .and_then(|x| parse_base62(x).ok())
                     .map(|x| crate::database::models::ids::DBUserId(x as i64))
-                {
-                    user_id
-                } else {
+                else {
                     break 'metadata;
                 };
 
-                let user = if let Some(user) =
+                let Some(user) =
                     crate::database::models::user_item::DBUser::get_id(
                         user_id, pool, redis,
                     )
                     .await?
-                {
-                    user
-                } else {
+                else {
                     break 'metadata;
                 };
 
@@ -1478,22 +1460,20 @@ pub async fn stripe_webhook(
                     .get("modrinth_payment_metadata")
                     .and_then(|x| serde_json::from_str(x).ok());
 
-                let charge_id = if let Some(charge_id) = metadata
+                let Some(charge_id) = metadata
                     .get("modrinth_charge_id")
                     .and_then(|x| parse_base62(x).ok())
-                    .map(|x| crate::database::models::ids::DBChargeId(x as i64))
-                {
-                    charge_id
-                } else {
+                    .map(|x| {
+                        crate::database::models::ids::DBChargeId(x as i64)
+                    })
+                else {
                     break 'metadata;
                 };
 
-                let charge_type = if let Some(charge_type) = metadata
+                let Some(charge_type) = metadata
                     .get("modrinth_charge_type")
                     .map(|x| ChargeType::from_string(x))
-                {
-                    charge_type
-                } else {
+                else {
                     break 'metadata;
                 };
 
@@ -1505,21 +1485,19 @@ pub async fn stripe_webhook(
                     )
                     .await?
                 {
-                    let price = if let Some(price) =
-                        product_item::DBProductPrice::get(charge.price_id, pool)
-                            .await?
-                    {
-                        price
-                    } else {
+                    let Some(price) = product_item::DBProductPrice::get(
+                        charge.price_id,
+                        pool,
+                    )
+                    .await?
+                    else {
                         break 'metadata;
                     };
 
-                    let product = if let Some(product) =
+                    let Some(product) =
                         product_item::DBProduct::get(price.product_id, pool)
                             .await?
-                    {
-                        product
-                    } else {
+                    else {
                         break 'metadata;
                     };
 
@@ -1530,15 +1508,13 @@ pub async fn stripe_webhook(
                     charge.upsert(transaction).await?;
 
                     if let Some(subscription_id) = charge.subscription_id {
-                        let mut subscription = if let Some(subscription) =
+                        let Some(mut subscription) =
                             user_subscription_item::DBUserSubscription::get(
                                 subscription_id,
                                 pool,
                             )
                             .await?
-                        {
-                            subscription
-                        } else {
+                        else {
                             break 'metadata;
                         };
 
@@ -1567,58 +1543,49 @@ pub async fn stripe_webhook(
                         (charge, price, product, None)
                     }
                 } else {
-                    let price_id = if let Some(price_id) = metadata
+                    let Some(price_id) = metadata
                         .get("modrinth_price_id")
                         .and_then(|x| parse_base62(x).ok())
                         .map(|x| {
                             crate::database::models::ids::DBProductPriceId(
                                 x as i64,
                             )
-                        }) {
-                        price_id
-                    } else {
+                        })
+                    else {
                         break 'metadata;
                     };
 
-                    let price = if let Some(price) =
+                    let Some(price) =
                         product_item::DBProductPrice::get(price_id, pool)
                             .await?
-                    {
-                        price
-                    } else {
+                    else {
                         break 'metadata;
                     };
 
-                    let product = if let Some(product) =
+                    let Some(product) =
                         product_item::DBProduct::get(price.product_id, pool)
                             .await?
-                    {
-                        product
-                    } else {
+                    else {
                         break 'metadata;
                     };
 
                     let subscription = match &price.prices {
                         Price::OneTime { .. } => None,
                         Price::Recurring { intervals } => {
-                            let interval = if let Some(interval) = metadata
+                            let Some(interval) = metadata
                                 .get("modrinth_subscription_interval")
                                 .map(|x| PriceDuration::from_string(x))
-                            {
-                                interval
-                            } else {
+                            else {
                                 break 'metadata;
                             };
 
                             if intervals.get(&interval).is_some() {
-                                let subscription_id = if let Some(subscription_id) = metadata
+                                let Some(subscription_id) = metadata
                                     .get("modrinth_subscription_id")
                                     .and_then(|x| parse_base62(x).ok())
                                     .map(|x| {
                                         crate::database::models::ids::DBUserSubscriptionId(x as i64)
-                                    }) {
-                                    subscription_id
-                                } else {
+                                    }) else {
                                     break 'metadata;
                                 };
 
@@ -1687,7 +1654,6 @@ pub async fn stripe_webhook(
                     charge_item: charge,
                     user_subscription_item: subscription,
                     payment_metadata,
-                    charge_type,
                 });
             }
 
@@ -2049,10 +2015,9 @@ pub async fn stripe_webhook(
                         )
                         .await?;
 
-                        if !customer
+                        if customer
                             .invoice_settings
-                            .map(|x| x.default_payment_method.is_some())
-                            .unwrap_or(false)
+                            .is_none_or(|x| x.default_payment_method.is_none())
                         {
                             stripe::Customer::update(
                                 &stripe_client,
@@ -2187,12 +2152,10 @@ pub async fn index_subscriptions(pool: PgPool, redis: RedisPool) {
         .await?;
 
         for charge in all_charges {
-            let subscription = if let Some(subscription) = all_subscriptions
+            let Some(subscription) = all_subscriptions
                 .iter_mut()
                 .find(|x| Some(x.id) == charge.subscription_id)
-            {
-                subscription
-            } else {
+            else {
                 continue;
             };
 
@@ -2200,29 +2163,23 @@ pub async fn index_subscriptions(pool: PgPool, redis: RedisPool) {
                 continue;
             }
 
-            let product_price = if let Some(product_price) = subscription_prices
+            let Some(product_price) = subscription_prices
                 .iter()
                 .find(|x| x.id == subscription.price_id)
-            {
-                product_price
-            } else {
+            else {
                 continue;
             };
 
-            let product = if let Some(product) = subscription_products
+            let Some(product) = subscription_products
                 .iter()
                 .find(|x| x.id == product_price.product_id)
-            {
-                product
-            } else {
+            else {
                 continue;
             };
 
-            let user = if let Some(user) =
+            let Some(user) =
                 users.iter().find(|x| x.id == subscription.user_id)
-            {
-                user
-            } else {
+            else {
                 continue;
             };
 
@@ -2350,19 +2307,14 @@ pub async fn index_billing(
         .await?;
 
         for mut charge in charges_to_do {
-            let product_price = if let Some(price) =
+            let Some(product_price) =
                 prices.iter().find(|x| x.id == charge.price_id)
-            {
-                price
-            } else {
+            else {
                 continue;
             };
 
-            let user = if let Some(user) =
-                users.iter().find(|x| x.id == charge.user_id)
-            {
-                user
-            } else {
+            let Some(user) = users.iter().find(|x| x.id == charge.user_id)
+            else {
                 continue;
             };
 
@@ -2399,17 +2351,14 @@ pub async fn index_billing(
                 )
                 .await?;
 
-                let currency = match Currency::from_str(
+                let Ok(currency) = Currency::from_str(
                     &product_price.currency_code.to_lowercase(),
-                ) {
-                    Ok(x) => x,
-                    Err(_) => {
-                        warn!(
-                            "Could not find currency for {}",
-                            product_price.currency_code
-                        );
-                        continue;
-                    }
+                ) else {
+                    warn!(
+                        "Could not find currency for {}",
+                        product_price.currency_code
+                    );
+                    continue;
                 };
 
                 let mut intent =

apps/labrinth/src/routes/internal/flows.rs

@@ -1249,7 +1249,7 @@ pub async fn delete_auth_provider(
     .await?
     .1;
 
-    if !user.auth_providers.map(|x| x.len() > 1).unwrap_or(false)
+    if user.auth_providers.is_none_or(|x| x.len() <= 1)
         && !user.has_password.unwrap_or(false)
     {
         return Err(ApiError::InvalidInput(

apps/labrinth/src/routes/internal/statuses.rs

@@ -217,8 +217,7 @@ pub async fn ws_init(
                         if status
                             .profile_name
                             .as_ref()
-                            .map(|x| x.len() > 64)
-                            .unwrap_or(false)
+                            .is_some_and(|x| x.len() > 64)
                         {
                             return;
                         }

apps/labrinth/src/routes/maven.rs

@@ -250,7 +250,7 @@ fn find_file<'a>(
     // Minecraft mods are not going to be both a mod and a modpack, so this minecraft-specific handling is fine
     // As there can be multiple project types, returns the first allowable match
     let mut fileexts = vec![];
-    for project_type in version.project_types.iter() {
+    for project_type in &version.project_types {
         match project_type.as_str() {
             "mod" => fileexts.push("jar"),
             "modpack" => fileexts.push("mrpack"),
@@ -381,8 +381,10 @@ pub async fn version_file_sha1(
 
     Ok(find_file(&project_id, &vnum, &version, &file)
         .and_then(|file| file.hashes.get("sha1"))
-        .map(|hash_str| HttpResponse::Ok().body(hash_str.clone()))
-        .unwrap_or_else(|| HttpResponse::NotFound().body("")))
+        .map_or_else(
+            || HttpResponse::NotFound().body(""),
+            |hash_str| HttpResponse::Ok().body(hash_str.clone()),
+        ))
 }
 
 #[get("maven/modrinth/{id}/{versionnum}/{file}.sha512")]
@@ -426,6 +428,8 @@ pub async fn version_file_sha512(
 
     Ok(find_file(&project_id, &vnum, &version, &file)
         .and_then(|file| file.hashes.get("sha512"))
-        .map(|hash_str| HttpResponse::Ok().body(hash_str.clone()))
-        .unwrap_or_else(|| HttpResponse::NotFound().body("")))
+        .map_or_else(
+            || HttpResponse::NotFound().body(""),
+            |hash_str| HttpResponse::Ok().body(hash_str.clone()),
+        ))
 }

apps/labrinth/src/routes/v2/projects.rs

@@ -83,7 +83,7 @@ pub async fn project_search(
                                     val
                                 )
                             } else {
-                                facet.to_string()
+                                facet
                             }
                         })
                         .collect::<Vec<_>>()

apps/labrinth/src/routes/v2/version_creation.rs

@@ -283,28 +283,23 @@ async fn get_example_version_fields(
     pool: Data<PgPool>,
     redis: &RedisPool,
 ) -> Result<Option<Vec<VersionField>>, CreateError> {
-    let project_id = match project_id {
-        Some(project_id) => project_id,
-        None => return Ok(None),
+    let Some(project_id) = project_id else {
+        return Ok(None);
     };
 
-    let vid = match project_item::DBProject::get_id(
-        project_id.into(),
-        &**pool,
-        redis,
-    )
-    .await?
-    .and_then(|p| p.versions.first().cloned())
-    {
-        Some(vid) => vid,
-        None => return Ok(None),
+    let Some(vid) =
+        project_item::DBProject::get_id(project_id.into(), &**pool, redis)
+            .await?
+            .and_then(|p| p.versions.first().copied())
+    else {
+        return Ok(None);
     };
 
-    let example_version =
-        match version_item::DBVersion::get(vid, &**pool, redis).await? {
-            Some(version) => version,
-            None => return Ok(None),
-        };
+    let Some(example_version) =
+        version_item::DBVersion::get(vid, &**pool, redis).await?
+    else {
+        return Ok(None);
+    };
     Ok(Some(example_version.version_fields))
 }
 

apps/labrinth/src/routes/v3/organizations.rs

@@ -256,13 +256,11 @@ pub async fn organization_get(
             .filter(|x| {
                 logged_in
                     || x.accepted
-                    || user_id
-                        .map(|y: crate::database::models::DBUserId| {
-                            y == x.user_id
-                        })
-                        .unwrap_or(false)
+                    || user_id.is_some_and(
+                        |y: crate::database::models::DBUserId| y == x.user_id,
+                    )
             })
-            .flat_map(|data| {
+            .filter_map(|data| {
                 users.iter().find(|x| x.id == data.user_id).map(|user| {
                     crate::models::teams::TeamMember::from(
                         data,
@@ -345,13 +343,11 @@ pub async fn organizations_get(
             .filter(|x| {
                 logged_in
                     || x.accepted
-                    || user_id
-                        .map(|y: crate::database::models::DBUserId| {
-                            y == x.user_id
-                        })
-                        .unwrap_or(false)
+                    || user_id.is_some_and(
+                        |y: crate::database::models::DBUserId| y == x.user_id,
+                    )
             })
-            .flat_map(|data| {
+            .filter_map(|data| {
                 users.iter().find(|x| x.id == data.user_id).map(|user| {
                     crate::models::teams::TeamMember::from(
                         data,
@@ -635,7 +631,7 @@ pub async fn organization_delete(
     .try_collect::<Vec<_>>()
     .await?;
 
-    for organization_project_team in organization_project_teams.iter() {
+    for organization_project_team in &organization_project_teams {
         let new_id = crate::database::models::ids::generate_team_member_id(
             &mut transaction,
         )

apps/labrinth/src/routes/v3/payouts.rs

@@ -830,14 +830,13 @@ async fn get_user_balance(
     .fetch_optional(pool)
     .await?;
 
-    let (withdrawn, fees) = withdrawn
-        .map(|x| {
+    let (withdrawn, fees) =
+        withdrawn.map_or((Decimal::ZERO, Decimal::ZERO), |x| {
             (
                 x.amount.unwrap_or(Decimal::ZERO),
                 x.fee.unwrap_or(Decimal::ZERO),
             )
-        })
-        .unwrap_or((Decimal::ZERO, Decimal::ZERO));
+        });
 
     Ok(UserBalance {
         available: available.round_dp(16)

apps/labrinth/src/routes/v3/project_creation.rs

@@ -360,15 +360,14 @@ async fn project_create_inner(
         // The first multipart field must be named "data" and contain a
         // JSON `ProjectCreateData` object.
 
-        let mut field = payload
-            .next()
-            .await
-            .map(|m| m.map_err(CreateError::MultipartError))
-            .unwrap_or_else(|| {
+        let mut field = payload.next().await.map_or_else(
+            || {
                 Err(CreateError::MissingValueError(String::from(
                     "No `data` field in multipart upload",
                 )))
-            })?;
+            },
+            |m| m.map_err(CreateError::MultipartError),
+        )?;
 
         let name = field.name().ok_or_else(|| {
             CreateError::MissingValueError(String::from("Missing content name"))
@@ -550,8 +549,8 @@ async fn project_create_inner(
                 )));
             };
             // `index` is always valid for these lists
-            let created_version = versions.get_mut(index).unwrap();
-            let version_data = project_create_data.initial_versions.get(index).unwrap();
+            let created_version = &mut versions[index];
+            let version_data = &project_create_data.initial_versions[index];
             // TODO: maybe redundant is this calculation done elsewhere?
 
             let existing_file_names = created_version
@@ -670,10 +669,9 @@ async fn project_create_inner(
                 &team_member,
             );
 
-            if !perms
-                .map(|x| x.contains(OrganizationPermissions::ADD_PROJECT))
-                .unwrap_or(false)
-            {
+            if !perms.is_some_and(|x| {
+                x.contains(OrganizationPermissions::ADD_PROJECT)
+            }) {
                 return Err(CreateError::CustomAuthenticationError(
                     "You do not have the permissions to create projects in this organization!"
                         .to_string(),

apps/labrinth/src/routes/v3/projects.rs

@@ -448,7 +448,7 @@ pub async fn project_edit(
                     }
                 }
 
-                if team_member.map(|x| !x.accepted).unwrap_or(true) {
+                if team_member.is_none_or(|x| !x.accepted) {
                     let notified_members = sqlx::query!(
                         "
                         SELECT tm.user_id id
@@ -2397,13 +2397,11 @@ pub async fn project_get_organization(
             .filter(|x| {
                 logged_in
                     || x.accepted
-                    || user_id
-                        .map(|y: crate::database::models::DBUserId| {
-                            y == x.user_id
-                        })
-                        .unwrap_or(false)
+                    || user_id.is_some_and(
+                        |y: crate::database::models::DBUserId| y == x.user_id,
+                    )
             })
-            .flat_map(|data| {
+            .filter_map(|data| {
                 users.iter().find(|x| x.id == data.user_id).map(|user| {
                     crate::models::teams::TeamMember::from(
                         data,

apps/labrinth/src/routes/v3/tags.rs

@@ -148,16 +148,15 @@ pub async fn loader_fields_list(
             ))
         })?;
 
-    let loader_field_enum_id = match loader_field.field_type {
-        LoaderFieldType::Enum(enum_id)
-        | LoaderFieldType::ArrayEnum(enum_id) => enum_id,
-        _ => {
-            return Err(ApiError::InvalidInput(format!(
-                "'{}' is not an enumerable field, but an '{}' field.",
-                query.loader_field,
-                loader_field.field_type.to_str()
-            )));
-        }
+    let (LoaderFieldType::Enum(loader_field_enum_id)
+    | LoaderFieldType::ArrayEnum(loader_field_enum_id)) =
+        loader_field.field_type
+    else {
+        return Err(ApiError::InvalidInput(format!(
+            "'{}' is not an enumerable field, but an '{}' field.",
+            query.loader_field,
+            loader_field.field_type.to_str()
+        )));
     };
 
     let results: Vec<_> = if let Some(filters) = query.filters {

apps/labrinth/src/routes/v3/teams.rs

@@ -101,13 +101,11 @@ pub async fn team_members_get_project(
             .filter(|x| {
                 logged_in
                     || x.accepted
-                    || user_id
-                        .map(|y: crate::database::models::DBUserId| {
-                            y == x.user_id
-                        })
-                        .unwrap_or(false)
+                    || user_id.is_some_and(
+                        |y: crate::database::models::DBUserId| y == x.user_id,
+                    )
             })
-            .flat_map(|data| {
+            .filter_map(|data| {
                 users.iter().find(|x| x.id == data.user_id).map(|user| {
                     crate::models::teams::TeamMember::from(
                         data,
@@ -176,13 +174,11 @@ pub async fn team_members_get_organization(
             .filter(|x| {
                 logged_in
                     || x.accepted
-                    || user_id
-                        .map(|y: crate::database::models::DBUserId| {
-                            y == x.user_id
-                        })
-                        .unwrap_or(false)
+                    || user_id.is_some_and(
+                        |y: crate::database::models::DBUserId| y == x.user_id,
+                    )
             })
-            .flat_map(|data| {
+            .filter_map(|data| {
                 users.iter().find(|x| x.id == data.user_id).map(|user| {
                     crate::models::teams::TeamMember::from(
                         data,
@@ -242,11 +238,11 @@ pub async fn team_members_get(
         .filter(|x| {
             logged_in
                 || x.accepted
-                || user_id
-                    .map(|y: crate::database::models::DBUserId| y == x.user_id)
-                    .unwrap_or(false)
+                || user_id.is_some_and(
+                    |y: crate::database::models::DBUserId| y == x.user_id,
+                )
         })
-        .flat_map(|data| {
+        .filter_map(|data| {
             users.iter().find(|x| x.id == data.user_id).map(|user| {
                 crate::models::teams::TeamMember::from(
                     data,
@@ -319,7 +315,7 @@ pub async fn teams_get(
         let team_members = members
             .into_iter()
             .filter(|x| logged_in || x.accepted)
-            .flat_map(|data| {
+            .filter_map(|data| {
                 users.iter().find(|x| x.id == data.user_id).map(|user| {
                     crate::models::teams::TeamMember::from(
                         data,
@@ -592,8 +588,7 @@ pub async fn add_team_member(
             };
         if new_user_organization_team_member
             .as_ref()
-            .map(|tm| tm.is_owner)
-            .unwrap_or(false)
+            .is_some_and(|tm| tm.is_owner)
             && new_member.permissions != ProjectPermissions::all()
         {
             return Err(ApiError::InvalidInput(
@@ -748,12 +743,10 @@ pub async fn edit_team_member(
 
             if organization_team_member
                 .as_ref()
-                .map(|x| x.is_owner)
-                .unwrap_or(false)
+                .is_some_and(|x| x.is_owner)
                 && edit_member
                     .permissions
-                    .map(|x| x != ProjectPermissions::all())
-                    .unwrap_or(false)
+                    .is_some_and(|x| x != ProjectPermissions::all())
             {
                 return Err(ApiError::CustomAuthentication(
                     "You cannot override the project permissions of the organization owner!"
@@ -1011,7 +1004,7 @@ pub async fn transfer_ownership(
                     .collect();
 
             // If the owner of the organization is a member of the project, remove them
-            for team_id in team_ids.iter() {
+            for team_id in &team_ids {
                 DBTeamMember::delete(
                     *team_id,
                     new_owner.user_id.into(),

apps/labrinth/src/routes/v3/threads.rs

@@ -119,7 +119,7 @@ pub async fn filter_authorized_threads(
         let project_thread_ids = check_threads
             .iter()
             .filter(|x| x.type_ == ThreadType::Project)
-            .flat_map(|x| x.project_id.map(|x| x.0))
+            .filter_map(|x| x.project_id.map(|x| x.0))
             .collect::<Vec<_>>();
 
         if !project_thread_ids.is_empty() {
@@ -148,13 +148,12 @@ pub async fn filter_authorized_threads(
             .await?;
         }
 
-        let org_project_thread_ids = check_threads
+        let mut org_project_thread_ids = check_threads
             .iter()
             .filter(|x| x.type_ == ThreadType::Project)
-            .flat_map(|x| x.project_id.map(|x| x.0))
-            .collect::<Vec<_>>();
+            .filter_map(|x| x.project_id.map(|x| x.0));
 
-        if !org_project_thread_ids.is_empty() {
+        if org_project_thread_ids.next().is_some() {
             sqlx::query!(
                 "
                 SELECT m.id FROM mods m
@@ -184,7 +183,7 @@ pub async fn filter_authorized_threads(
         let report_thread_ids = check_threads
             .iter()
             .filter(|x| x.type_ == ThreadType::Report)
-            .flat_map(|x| x.report_id.map(|x| x.0))
+            .filter_map(|x| x.report_id.map(|x| x.0))
             .collect::<Vec<_>>();
 
         if !report_thread_ids.is_empty() {

apps/labrinth/src/routes/v3/users.rs

@@ -207,7 +207,7 @@ pub async fn user_get(
         .ok();
 
         let response: crate::models::users::User =
-            if auth_user.map(|x| x.role.is_admin()).unwrap_or(false) {
+            if auth_user.is_some_and(|x| x.role.is_admin()) {
                 crate::models::users::User::from_full(data)
             } else {
                 data.into()
@@ -242,9 +242,8 @@ pub async fn collections_list(
     if let Some(id) = id_option.map(|x| x.id) {
         let user_id: UserId = id.into();
 
-        let can_view_private = user
-            .map(|y| y.role.is_mod() || y.id == user_id)
-            .unwrap_or(false);
+        let can_view_private =
+            user.is_some_and(|y| y.role.is_mod() || y.id == user_id);
 
         let project_data = DBUser::get_collections(id, &**pool).await?;
 
@@ -334,7 +333,7 @@ pub async fn orgs_list(
             let team_members: Vec<_> = members_data
                 .into_iter()
                 .filter(|x| logged_in || x.accepted || id == x.user_id)
-                .flat_map(|data| {
+                .filter_map(|data| {
                     users.iter().find(|x| x.id == data.user_id).map(|user| {
                         crate::models::teams::TeamMember::from(
                             data,
@@ -412,8 +411,7 @@ pub async fn user_edit(
 
                 if existing_user_id_option
                     .map(|x| UserId::from(x.id))
-                    .map(|id| id == user.id)
-                    .unwrap_or(true)
+                    .is_none_or(|id| id == user.id)
                 {
                     sqlx::query!(
                         "

apps/labrinth/src/routes/v3/version_creation.rs

@@ -606,13 +606,10 @@ async fn upload_file_to_version_inner(
 
     let result = models::DBVersion::get(version_id, &**client, &redis).await?;
 
-    let version = match result {
-        Some(v) => v,
-        None => {
-            return Err(CreateError::InvalidInput(
-                "An invalid version id was supplied".to_string(),
-            ));
-        }
+    let Some(version) = result else {
+        return Err(CreateError::InvalidInput(
+            "An invalid version id was supplied".to_string(),
+        ));
     };
 
     let all_loaders =
@@ -1065,7 +1062,7 @@ pub fn try_create_version_fields(
         .filter(|lf| !lf.optional)
         .map(|lf| lf.field.clone())
         .collect::<HashSet<_>>();
-    for (key, value) in submitted_fields.iter() {
+    for (key, value) in submitted_fields {
         let loader_field = loader_fields
             .iter()
             .find(|lf| &lf.field == key)

apps/labrinth/src/routes/v3/versions.rs

@@ -794,8 +794,7 @@ pub async fn version_list(
             .filter(|version| {
                 filters
                     .featured
-                    .map(|featured| featured == version.inner.featured)
-                    .unwrap_or(true)
+                    .is_none_or(|featured| featured == version.inner.featured)
             })
             .cloned()
             .collect::<Vec<_>>();
@@ -830,22 +829,20 @@ pub async fn version_list(
             }
 
             joined_filters.into_iter().for_each(|filter| {
-                versions
-                    .iter()
-                    .find(|version| {
-                        // TODO: This is the bandaid fix for detecting auto-featured versions.
-                        let game_versions = version
-                            .version_fields
-                            .iter()
-                            .find(|vf| vf.field_name == "game_versions")
-                            .map(|vf| vf.value.clone())
-                            .map(|v| v.as_strings())
-                            .unwrap_or_default();
-                        game_versions.contains(&filter.0.version)
-                            && version.loaders.contains(&filter.1.loader)
-                    })
-                    .map(|version| response.push(version.clone()))
-                    .unwrap_or(());
+                if let Some(version) = versions.iter().find(|version| {
+                    // TODO: This is the bandaid fix for detecting auto-featured versions.
+                    let game_versions = version
+                        .version_fields
+                        .iter()
+                        .find(|vf| vf.field_name == "game_versions")
+                        .map(|vf| vf.value.clone())
+                        .map(|v| v.as_strings())
+                        .unwrap_or_default();
+                    game_versions.contains(&filter.0.version)
+                        && version.loaders.contains(&filter.1.loader)
+                }) {
+                    response.push(version.clone());
+                }
             });
 
             if response.is_empty() {

apps/labrinth/src/search/indexing/local_import.rs

@@ -522,7 +522,7 @@ async fn index_versions(
     // Convert to partial versions
     let mut res_versions: HashMap<DBProjectId, Vec<PartialVersion>> =
         HashMap::new();
-    for (project_id, version_ids) in versions.iter() {
+    for (project_id, version_ids) in &versions {
         for version_id in version_ids {
             // Extract version-specific data fetched
             // We use 'remove' as every version is only in the map once

apps/labrinth/src/util/actix.rs

@@ -13,7 +13,6 @@ pub struct MultipartSegment {
 }
 
 #[derive(Debug, Clone)]
-#[allow(dead_code)]
 pub enum MultipartSegmentData {
     Text(String),
     Binary(Vec<u8>),

apps/labrinth/src/util/img.rs

@@ -98,13 +98,12 @@ pub async fn upload_image_optimized(
 
     let url = format!("{}/{}", cdn_url, upload_data.file_name);
     Ok(UploadImageResult {
-        url: processed_upload_data
-            .clone()
-            .map(|x| format!("{}/{}", cdn_url, x.file_name))
-            .unwrap_or_else(|| url.clone()),
+        url: processed_upload_data.clone().map_or_else(
+            || url.clone(),
+            |x| format!("{}/{}", cdn_url, x.file_name),
+        ),
         url_path: processed_upload_data
-            .map(|x| x.file_name)
-            .unwrap_or_else(|| upload_data.file_name.clone()),
+            .map_or_else(|| upload_data.file_name.clone(), |x| x.file_name),
 
         raw_url: url,
         raw_url_path: upload_data.file_name,
@@ -119,7 +118,7 @@ fn process_image(
     min_aspect_ratio: Option<f32>,
 ) -> Result<(bytes::Bytes, String), ImageError> {
     if content_type.to_lowercase() == "image/gif" {
-        return Ok((image_bytes.clone(), "gif".to_string()));
+        return Ok((image_bytes, "gif".to_string()));
     }
 
     let mut img = image::load_from_memory(&image_bytes)?;

apps/labrinth/src/util/ratelimit.rs

@@ -56,18 +56,15 @@ impl AsyncRateLimiter {
     }
 
     pub async fn check_rate_limit(&self, key: &str) -> RateLimitDecision {
-        let mut conn = match self.redis_pool.connect().await {
-            Ok(conn) => conn,
-            Err(_) => {
-                // If Redis is unavailable, allow the request but with reduced limit
-                return RateLimitDecision {
-                    allowed: true,
-                    limit: self.params.burst_size,
-                    remaining: 1,
-                    reset_after_ms: 60_000, // 1 minute
-                    retry_after_ms: None,
-                };
-            }
+        let Ok(mut conn) = self.redis_pool.connect().await else {
+            // If Redis is unavailable, allow the request but with reduced limit
+            return RateLimitDecision {
+                allowed: true,
+                limit: self.params.burst_size,
+                remaining: 1,
+                reset_after_ms: 60_000, // 1 minute
+                retry_after_ms: None,
+            };
         };
 
         // Get current time in nanoseconds since UNIX epoch

apps/labrinth/src/util/validate.rs

@@ -1,4 +1,4 @@
-use std::sync::LazyLock;
+use std::{fmt::Write, sync::LazyLock};
 
 use itertools::Itertools;
 use regex::Regex;
@@ -44,15 +44,17 @@ pub fn validation_errors_to_string(
                 ValidationErrorsKind::Field(errors) => {
                     if let Some(error) = errors.first() {
                         if let Some(adder) = adder {
-                            output.push_str(&format!(
-                                "Field {} {} failed validation with error: {}",
-                                field, adder, error.code
-                            ));
+                            write!(
+                                &mut output,
+                                "Field {field} {adder} failed validation with error: {}",
+                                error.code
+                            ).unwrap();
                         } else {
-                            output.push_str(&format!(
-                                "Field {} failed validation with error: {}",
-                                field, error.code
-                            ));
+                            write!(
+                                &mut output,
+                                "Field {field} failed validation with error: {}",
+                                error.code
+                            ).unwrap();
                         }
                     }
 

apps/labrinth/src/validate/mod.rs

@@ -77,7 +77,6 @@ pub enum SupportedGameVersions {
     All,
     PastDate(DateTime<Utc>),
     Range(DateTime<Utc>, DateTime<Utc>),
-    #[allow(dead_code)]
     Custom(Vec<MinecraftGameVersion>),
 }
 
@@ -232,8 +231,7 @@ fn game_version_supported(
                 all_game_versions
                     .iter()
                     .find(|y| y.version == x.version)
-                    .map(|x| x.created > date)
-                    .unwrap_or(false)
+                    .is_some_and(|x| x.created > date)
             })
         }
         SupportedGameVersions::Range(before, after) => {
@@ -241,8 +239,7 @@ fn game_version_supported(
                 all_game_versions
                     .iter()
                     .find(|y| y.version == x.version)
-                    .map(|x| x.created > before && x.created < after)
-                    .unwrap_or(false)
+                    .is_some_and(|x| x.created > before && x.created < after)
             })
         }
         SupportedGameVersions::Custom(versions) => {

apps/labrinth/src/validate/modpack.rs

@@ -28,14 +28,11 @@ impl super::Validator for ModpackValidator {
         archive: &mut ZipArchive<Cursor<bytes::Bytes>>,
     ) -> Result<ValidationResult, ValidationError> {
         let pack: PackFormat = {
-            let mut file =
-                if let Ok(file) = archive.by_name("modrinth.index.json") {
-                    file
-                } else {
-                    return Ok(ValidationResult::Warning(
-                        "Pack manifest is missing.",
-                    ));
-                };
+            let Ok(mut file) = archive.by_name("modrinth.index.json") else {
+                return Ok(ValidationResult::Warning(
+                    "Pack manifest is missing.",
+                ));
+            };
 
             let mut contents = String::new();
             file.read_to_string(&mut contents)?;
@@ -109,7 +106,7 @@ impl super::Validator for ModpackValidator {
                             || x.starts_with("overrides/shaderpacks")
                             || x.starts_with("client-overrides/shaderpacks"))
                 })
-                .flat_map(|x| x.rsplit('/').next().map(|x| x.to_string()))
+                .filter_map(|x| x.rsplit('/').next().map(|x| x.to_string()))
                 .collect::<Vec<String>>(),
         })
     }

apps/labrinth/tests/analytics.rs

@@ -12,7 +12,7 @@ use labrinth::models::teams::ProjectPermissions;
 use labrinth::queue::payouts;
 use rust_decimal::{Decimal, prelude::ToPrimitive};
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 pub async fn analytics_revenue() {
@@ -50,7 +50,7 @@ pub async fn analytics_revenue() {
             ];
 
             let project_id = parse_base62(&alpha_project_id).unwrap() as i64;
-            for (money, time) in money_time_pairs.iter() {
+            for (money, time) in &money_time_pairs {
                 insert_user_ids.push(USER_USER_ID_PARSED);
                 insert_project_ids.push(project_id);
                 insert_payouts.push(Decimal::from_f64_retain(*money).unwrap());
@@ -87,7 +87,7 @@ pub async fn analytics_revenue() {
                 )
                 .await;
             assert_eq!(analytics.len(), 1); // 1 project
-            let project_analytics = analytics.get(&alpha_project_id).unwrap();
+            let project_analytics = &analytics[&alpha_project_id];
             assert_eq!(project_analytics.len(), 8); // 1 days cut off, and 2 points take place on the same day. note that the day exactly 14 days ago is included
             // sorted_by_key, values in the order of smallest to largest key
             let (sorted_keys, sorted_by_key): (Vec<i64>, Vec<Decimal>) =
@@ -117,7 +117,7 @@ pub async fn analytics_revenue() {
                     USER_USER_PAT,
                 )
                 .await;
-            let project_analytics = analytics.get(&alpha_project_id).unwrap();
+            let project_analytics = &analytics[&alpha_project_id];
             assert_eq!(project_analytics.len(), 9); // and 2 points take place on the same day
             let (sorted_keys, sorted_by_key): (Vec<i64>, Vec<Decimal>) =
                 project_analytics

apps/labrinth/tests/common/api_common/models.rs

@@ -31,13 +31,12 @@ use serde::Deserialize;
 // as the environment generator for both uses common fields.
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonProject {
     // For example, for CommonProject, we do not include:
     // - game_versions (v2 only)
     // - loader_fields (v3 only)
     // - etc.
-    // For any tests that require those fields, we make a separate test with separate API functions tht do not use Common models.
+    // For any tests that require those fields, we make a separate test with separate API functions that do not use Common models.
     pub id: ProjectId,
     pub slug: Option<String>,
     pub organization: Option<OrganizationId>,
@@ -62,7 +61,6 @@ pub struct CommonProject {
     pub monetization_status: MonetizationStatus,
 }
 #[derive(Deserialize, Clone)]
-#[allow(dead_code)]
 pub struct CommonVersion {
     pub id: VersionId,
     pub loaders: Vec<String>,
@@ -82,7 +80,6 @@ pub struct CommonVersion {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonLoaderData {
     pub icon: String,
     pub name: String,
@@ -90,7 +87,6 @@ pub struct CommonLoaderData {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonCategoryData {
     pub icon: String,
     pub name: String,
@@ -100,7 +96,6 @@ pub struct CommonCategoryData {
 
 /// A member of a team
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonTeamMember {
     pub team_id: TeamId,
     pub user: User,
@@ -114,7 +109,6 @@ pub struct CommonTeamMember {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonNotification {
     pub id: NotificationId,
     pub user_id: UserId,
@@ -127,7 +121,6 @@ pub struct CommonNotification {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonNotificationAction {
     pub action_route: (String, String),
 }
@@ -153,7 +146,6 @@ impl CommonItemType {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonReport {
     pub id: ReportId,
     pub report_type: String,
@@ -175,7 +167,6 @@ pub enum LegacyItemType {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonThread {
     pub id: ThreadId,
     #[serde(rename = "type")]
@@ -187,7 +178,6 @@ pub struct CommonThread {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonThreadMessage {
     pub id: ThreadMessageId,
     pub author_id: Option<UserId>,
@@ -196,7 +186,6 @@ pub struct CommonThreadMessage {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub enum CommonMessageBody {
     Text {
         body: String,
@@ -216,7 +205,6 @@ pub enum CommonMessageBody {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub enum CommonThreadType {
     Report,
     Project,
@@ -224,7 +212,6 @@ pub enum CommonThreadType {
 }
 
 #[derive(Deserialize)]
-#[allow(dead_code)]
 pub struct CommonUser {
     pub id: UserId,
     pub username: String,

apps/labrinth/tests/common/api_common/request_data.rs

@@ -5,21 +5,18 @@ use labrinth::util::actix::MultipartSegment;
 
 use crate::common::dummy_data::TestFile;
 
-#[allow(dead_code)]
 pub struct ProjectCreationRequestData {
     pub slug: String,
     pub jar: Option<TestFile>,
     pub segment_data: Vec<MultipartSegment>,
 }
 
-#[allow(dead_code)]
 pub struct VersionCreationRequestData {
     pub version: String,
     pub jar: Option<TestFile>,
     pub segment_data: Vec<MultipartSegment>,
 }
 
-#[allow(dead_code)]
 pub struct ImageData {
     pub filename: String,
     pub extension: String,

apps/labrinth/tests/common/api_v2/mod.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use super::{
     api_common::{Api, ApiBuildable},
     environment::LocalService,

apps/labrinth/tests/common/api_v2/project.rs

@@ -1,4 +1,4 @@
-use std::collections::HashMap;
+use std::{collections::HashMap, fmt::Write};
 
 use crate::{
     assert_status,
@@ -490,13 +490,13 @@ impl ApiProject for ApiV2 {
             featured = featured
         );
         if let Some(title) = title {
-            url.push_str(&format!("&title={title}"));
+            write!(&mut url, "&title={title}").unwrap();
         }
         if let Some(description) = description {
-            url.push_str(&format!("&description={description}"));
+            write!(&mut url, "&description={description}").unwrap();
         }
         if let Some(ordering) = ordering {
-            url.push_str(&format!("&ordering={ordering}"));
+            write!(&mut url, "&ordering={ordering}").unwrap();
         }
 
         let req = test::TestRequest::post()
@@ -521,11 +521,12 @@ impl ApiProject for ApiV2 {
         );
 
         for (key, value) in patch {
-            url.push_str(&format!(
+            write!(
+                &mut url,
                 "&{key}={value}",
-                key = key,
                 value = urlencoding::encode(&value)
-            ));
+            )
+            .unwrap();
         }
 
         let req = test::TestRequest::patch()

apps/labrinth/tests/common/api_v2/request_data.rs

@@ -1,4 +1,3 @@
-#![allow(dead_code)]
 use serde_json::json;
 
 use crate::common::{
@@ -90,7 +89,7 @@ pub fn get_public_project_creation_data_json(
         {
             "title": format!("Test Project {slug}"),
             "slug": slug,
-            "project_type": version_jar.as_ref().map(|f| f.project_type()).unwrap_or("mod".to_string()),
+            "project_type": version_jar.as_ref().map_or("mod".to_string(), |f| f.project_type()),
             "description": "A dummy project for testing with.",
             "body": "This project is approved, and versions are listed.",
             "client_side": "required",

apps/labrinth/tests/common/api_v2/version.rs

@@ -1,4 +1,5 @@
 use std::collections::HashMap;
+use std::fmt::Write;
 
 use super::{
     ApiV2,
@@ -383,32 +384,36 @@ impl ApiVersion for ApiV2 {
     ) -> ServiceResponse {
         let mut query_string = String::new();
         if let Some(game_versions) = game_versions {
-            query_string.push_str(&format!(
+            write!(
+                &mut query_string,
                 "&game_versions={}",
                 urlencoding::encode(
                     &serde_json::to_string(&game_versions).unwrap()
                 )
-            ));
+            )
+            .unwrap();
         }
         if let Some(loaders) = loaders {
-            query_string.push_str(&format!(
+            write!(
+                &mut query_string,
                 "&loaders={}",
                 urlencoding::encode(&serde_json::to_string(&loaders).unwrap())
-            ));
+            )
+            .unwrap();
         }
         if let Some(featured) = featured {
-            query_string.push_str(&format!("&featured={featured}"));
+            write!(&mut query_string, "&featured={featured}").unwrap();
         }
         if let Some(version_type) = version_type {
-            query_string.push_str(&format!("&version_type={version_type}"));
+            write!(&mut query_string, "&version_type={version_type}").unwrap();
         }
         if let Some(limit) = limit {
             let limit = limit.to_string();
-            query_string.push_str(&format!("&limit={limit}"));
+            write!(&mut query_string, "&limit={limit}").unwrap();
         }
         if let Some(offset) = offset {
             let offset = offset.to_string();
-            query_string.push_str(&format!("&offset={offset}"));
+            write!(&mut query_string, "&offset={offset}").unwrap();
         }
 
         let req = test::TestRequest::get()

apps/labrinth/tests/common/api_v3/mod.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use super::{
     api_common::{Api, ApiBuildable},
     environment::LocalService,

apps/labrinth/tests/common/api_v3/project.rs

@@ -1,4 +1,4 @@
-use std::collections::HashMap;
+use std::{collections::HashMap, fmt::Write};
 
 use actix_http::StatusCode;
 use actix_web::{
@@ -363,13 +363,13 @@ impl ApiProject for ApiV3 {
             featured = featured
         );
         if let Some(title) = title {
-            url.push_str(&format!("&title={title}"));
+            write!(&mut url, "&title={title}").unwrap();
         }
         if let Some(description) = description {
-            url.push_str(&format!("&description={description}"));
+            write!(&mut url, "&description={description}").unwrap();
         }
         if let Some(ordering) = ordering {
-            url.push_str(&format!("&ordering={ordering}"));
+            write!(&mut url, "&ordering={ordering}").unwrap();
         }
 
         let req = test::TestRequest::post()
@@ -394,11 +394,12 @@ impl ApiProject for ApiV3 {
         );
 
         for (key, value) in patch {
-            url.push_str(&format!(
+            write!(
+                &mut url,
                 "&{key}={value}",
-                key = key,
                 value = urlencoding::encode(&value)
-            ));
+            )
+            .unwrap();
         }
 
         let req = test::TestRequest::patch()
@@ -593,17 +594,17 @@ impl ApiV3 {
             let start_date = start_date.to_rfc3339();
             // let start_date = serde_json::to_string(&start_date).unwrap();
             let start_date = urlencoding::encode(&start_date);
-            extra_args.push_str(&format!("&start_date={start_date}"));
+            write!(&mut extra_args, "&start_date={start_date}").unwrap();
         }
         if let Some(end_date) = end_date {
             let end_date = end_date.to_rfc3339();
             // let end_date = serde_json::to_string(&end_date).unwrap();
             let end_date = urlencoding::encode(&end_date);
-            extra_args.push_str(&format!("&end_date={end_date}"));
+            write!(&mut extra_args, "&end_date={end_date}").unwrap();
         }
         if let Some(resolution_minutes) = resolution_minutes {
-            extra_args
-                .push_str(&format!("&resolution_minutes={resolution_minutes}"));
+            write!(&mut extra_args, "&resolution_minutes={resolution_minutes}")
+                .unwrap();
         }
 
         let req = test::TestRequest::get()

apps/labrinth/tests/common/api_v3/request_data.rs

@@ -1,4 +1,3 @@
-#![allow(dead_code)]
 use serde_json::json;
 
 use crate::common::{

apps/labrinth/tests/common/api_v3/version.rs

@@ -1,4 +1,5 @@
 use std::collections::HashMap;
+use std::fmt::Write;
 
 use super::{
     ApiV3,
@@ -416,32 +417,36 @@ impl ApiVersion for ApiV3 {
     ) -> ServiceResponse {
         let mut query_string = String::new();
         if let Some(game_versions) = game_versions {
-            query_string.push_str(&format!(
+            write!(
+                &mut query_string,
                 "&game_versions={}",
                 urlencoding::encode(
                     &serde_json::to_string(&game_versions).unwrap()
                 )
-            ));
+            )
+            .unwrap();
         }
         if let Some(loaders) = loaders {
-            query_string.push_str(&format!(
+            write!(
+                &mut query_string,
                 "&loaders={}",
                 urlencoding::encode(&serde_json::to_string(&loaders).unwrap())
-            ));
+            )
+            .unwrap();
         }
         if let Some(featured) = featured {
-            query_string.push_str(&format!("&featured={featured}"));
+            write!(&mut query_string, "&featured={featured}").unwrap();
         }
         if let Some(version_type) = version_type {
-            query_string.push_str(&format!("&version_type={version_type}"));
+            write!(&mut query_string, "&version_type={version_type}").unwrap();
         }
         if let Some(limit) = limit {
             let limit = limit.to_string();
-            query_string.push_str(&format!("&limit={limit}"));
+            write!(&mut query_string, "&limit={limit}").unwrap();
         }
         if let Some(offset) = offset {
             let offset = offset.to_string();
-            query_string.push_str(&format!("&offset={offset}"));
+            write!(&mut query_string, "&offset={offset}").unwrap();
         }
 
         let req = test::TestRequest::get()

apps/labrinth/tests/common/asserts.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use crate::common::get_json_val_str;
 use itertools::Itertools;
 use labrinth::models::v3::projects::Version;

apps/labrinth/tests/common/database.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use labrinth::{database::redis::RedisPool, search};
 use sqlx::{PgPool, postgres::PgPoolOptions};
 use std::time::Duration;

apps/labrinth/tests/common/dummy_data.rs

@@ -1,4 +1,3 @@
-#![allow(dead_code)]
 use std::io::{Cursor, Write};
 
 use crate::{
@@ -28,7 +27,6 @@ use super::{database::USER_USER_ID, get_json_val_str};
 
 pub const DUMMY_DATA_UPDATE: i64 = 7;
 
-#[allow(dead_code)]
 pub const DUMMY_CATEGORIES: &[&str] = &[
     "combat",
     "decoration",
@@ -41,7 +39,6 @@ pub const DUMMY_CATEGORIES: &[&str] = &[
 
 pub const DUMMY_OAUTH_CLIENT_ALPHA_SECRET: &str = "abcdefghijklmnopqrstuvwxyz";
 
-#[allow(dead_code)]
 #[derive(Clone)]
 pub enum TestFile {
     DummyProjectAlpha,
@@ -173,7 +170,6 @@ impl TestFile {
 }
 
 #[derive(Clone)]
-#[allow(dead_code)]
 pub enum DummyImage {
     SmallIcon, // 200x200
 }

apps/labrinth/tests/common/environment.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use super::{
     api_common::{Api, ApiBuildable, generic::GenericApi},
     api_v2::ApiV2,

apps/labrinth/tests/common/pats.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use chrono::Utc;
 use labrinth::{
     database::{self, models::generate_pat_id},

apps/labrinth/tests/common/permissions.rs

@@ -1,4 +1,3 @@
-#![allow(dead_code)]
 use actix_http::StatusCode;
 use actix_web::{dev::ServiceResponse, test};
 use futures::Future;

apps/labrinth/tests/common/scopes.rs

@@ -1,4 +1,3 @@
-#![allow(dead_code)]
 use actix_web::{dev::ServiceResponse, test};
 use futures::Future;
 use labrinth::models::pats::Scopes;

apps/labrinth/tests/common/search.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use std::{collections::HashMap, sync::Arc};
 
 use actix_http::StatusCode;

apps/labrinth/tests/error.rs

@@ -7,7 +7,7 @@ use common::api_v3::ApiV3;
 use common::database::USER_USER_PAT;
 use common::environment::{TestEnvironment, with_test_environment};
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 pub async fn error_404_body() {

apps/labrinth/tests/games.rs

@@ -5,7 +5,7 @@ use common::{
     environment::{TestEnvironment, with_test_environment},
 };
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn get_games() {

apps/labrinth/tests/loader_fields.rs

@@ -17,8 +17,7 @@ use crate::common::dummy_data::{
     DummyProjectAlpha, DummyProjectBeta, TestFile,
 };
 
-// importing common module.
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 
@@ -242,7 +241,7 @@ async fn creating_loader_fields() {
                 USER_USER_PAT,
             )
             .await;
-        assert_eq!(v.fields.get("test_fabric_optional").unwrap(), &json!(555));
+        assert_eq!(&v.fields["test_fabric_optional"], &json!(555));
         // - Patch
         let resp = api
             .edit_version(
@@ -257,7 +256,7 @@ async fn creating_loader_fields() {
         let v = api
             .get_version_deserialized(alpha_version_id, USER_USER_PAT)
             .await;
-        assert_eq!(v.fields.get("test_fabric_optional").unwrap(), &json!(555));
+        assert_eq!(&v.fields["test_fabric_optional"], &json!(555));
 
         // Simply setting them as expected works
         // - Create
@@ -286,12 +285,9 @@ async fn creating_loader_fields() {
                 USER_USER_PAT,
             )
             .await;
-        assert_eq!(
-            v.fields.get("game_versions").unwrap(),
-            &json!(["1.20.1", "1.20.2"])
-        );
-        assert_eq!(v.fields.get("singleplayer").unwrap(), &json!(false));
-        assert_eq!(v.fields.get("server_only").unwrap(), &json!(true));
+        assert_eq!(&v.fields["game_versions"], &json!(["1.20.1", "1.20.2"]));
+        assert_eq!(&v.fields["singleplayer"], &json!(false));
+        assert_eq!(&v.fields["server_only"], &json!(true));
         // - Patch
         let resp = api
             .edit_version(
@@ -308,10 +304,7 @@ async fn creating_loader_fields() {
         let v = api
             .get_version_deserialized(alpha_version_id, USER_USER_PAT)
             .await;
-        assert_eq!(
-            v.fields.get("game_versions").unwrap(),
-            &json!(["1.20.1", "1.20.2"])
-        );
+        assert_eq!(&v.fields["game_versions"], &json!(["1.20.1", "1.20.2"]));
 
         // Now that we've created a version, we need to make sure that the Project's loader fields are updated (aggregate)
         // First, add a new version
@@ -361,23 +354,11 @@ async fn creating_loader_fields() {
             )
             .await;
         assert_eq!(
-            project.fields.get("game_versions").unwrap(),
+            &project.fields["game_versions"],
             &[json!("1.20.1"), json!("1.20.2"), json!("1.20.5")]
         );
-        assert!(
-            project
-                .fields
-                .get("singleplayer")
-                .unwrap()
-                .contains(&json!(false))
-        );
-        assert!(
-            project
-                .fields
-                .get("singleplayer")
-                .unwrap()
-                .contains(&json!(true))
-        );
+        assert!(project.fields["singleplayer"].contains(&json!(false)));
+        assert!(project.fields["singleplayer"].contains(&json!(true)));
     })
     .await
 }
@@ -533,7 +514,7 @@ async fn test_multi_get_redis_cache() {
             assert_eq!(projects.len(), 10);
 
             // Ensure all 5 modpacks have 'mrpack_loaders', and all 5 mods do not
-            for project in projects.iter() {
+            for project in &projects {
                 if modpacks.contains(project.slug.as_ref().unwrap()) {
                     assert!(project.fields.contains_key("mrpack_loaders"));
                 } else if mods.contains(project.slug.as_ref().unwrap()) {
@@ -566,7 +547,7 @@ async fn test_multi_get_redis_cache() {
             assert_eq!(versions.len(), 10);
 
             // Ensure all 5 versions from modpacks have 'mrpack_loaders', and all 5 versions from mods do not
-            for version in versions.iter() {
+            for version in &versions {
                 if version_ids_modpacks.contains(&version.id) {
                     assert!(version.fields.contains_key("mrpack_loaders"));
                 } else if version_ids_mods.contains(&version.id) {

apps/labrinth/tests/notifications.rs

@@ -5,7 +5,7 @@ use common::{
 
 use crate::common::api_common::ApiTeams;
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 pub async fn get_user_notifications_after_team_invitation_returns_notification()

apps/labrinth/tests/oauth.rs

@@ -16,7 +16,7 @@ use common::{
 };
 use labrinth::auth::oauth::TokenResponse;
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn oauth_flow_happy_path() {

apps/labrinth/tests/oauth_clients.rs

@@ -17,7 +17,7 @@ use labrinth::{
 
 use common::database::USER_USER_ID_PARSED;
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn can_create_edit_get_oauth_client() {

apps/labrinth/tests/organizations.rs

@@ -22,7 +22,7 @@ use common::{
 use labrinth::models::teams::{OrganizationPermissions, ProjectPermissions};
 use serde_json::json;
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn create_organization() {
@@ -583,9 +583,7 @@ async fn add_remove_organization_project_ownership_to_user() {
                 .await;
             assert_eq!(members.len(), 1);
             assert_eq!(members[0].user.id.to_string(), FRIEND_USER_ID);
-            let user_member =
-                members.iter().filter(|m| m.is_owner).collect::<Vec<_>>();
-            assert_eq!(user_member.len(), 0);
+            assert_eq!(members.iter().filter(|m| m.is_owner).count(), 0);
 
             // Beta project should have:
             // - No members
@@ -836,9 +834,7 @@ async fn delete_organization_means_all_projects_to_org_owner() {
                 .api
                 .get_team_members_deserialized(alpha_team_id, USER_USER_PAT)
                 .await;
-            let user_member =
-                members.iter().filter(|m| m.is_owner).collect::<Vec<_>>();
-            assert_eq!(user_member.len(), 0);
+            assert_eq!(members.iter().filter(|m| m.is_owner).count(), 0);
 
             // Transfer ownership of zeta organization to FRIEND
             let resp = test_env
@@ -856,9 +852,7 @@ async fn delete_organization_means_all_projects_to_org_owner() {
                 .api
                 .get_team_members_deserialized(alpha_team_id, USER_USER_PAT)
                 .await;
-            let user_member =
-                members.iter().filter(|m| m.is_owner).collect::<Vec<_>>();
-            assert_eq!(user_member.len(), 0);
+            assert_eq!(members.iter().filter(|m| m.is_owner).count(), 0);
 
             // Delete organization
             let resp = test_env

apps/labrinth/tests/pats.rs

@@ -8,7 +8,7 @@ use serde_json::json;
 
 use crate::common::api_common::AppendsOptionalPat;
 
-mod common;
+pub mod common;
 
 // Full pat test:
 // - create a PAT and ensure it can be used for the scope

apps/labrinth/tests/project.rs

@@ -27,7 +27,7 @@ use labrinth::util::actix::{MultipartSegment, MultipartSegmentData};
 use serde_json::json;
 use sha1::Digest;
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn test_get_project() {

apps/labrinth/tests/scopes.rs

@@ -29,7 +29,7 @@ use serde_json::json;
 // - test the function with the PAT with the given scopes
 // - test the function with the PAT with all other scopes
 
-mod common;
+pub mod common;
 
 // Test for users, emails, and payout scopes (not user auth scope or notifs)
 #[actix_rt::test]

apps/labrinth/tests/search.rs

@@ -14,7 +14,7 @@ use serde_json::json;
 use crate::common::api_common::Api;
 use crate::common::api_common::ApiProject;
 
-mod common;
+pub mod common;
 
 // TODO: Revisit this wit   h the new modify_json in the version maker
 // That change here should be able to simplify it vastly

apps/labrinth/tests/tags.rs

@@ -9,7 +9,7 @@ use common::{
 
 use crate::common::api_common::ApiTags;
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn get_tags() {

apps/labrinth/tests/teams.rs

@@ -10,7 +10,7 @@ use labrinth::models::teams::{OrganizationPermissions, ProjectPermissions};
 use rust_decimal::Decimal;
 use serde_json::json;
 
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn test_get_team() {

apps/labrinth/tests/user.rs

@@ -5,7 +5,7 @@ use common::{
     environment::with_test_environment_all,
 };
 
-mod common;
+pub mod common;
 
 // user GET (permissions, different users)
 // users GET

apps/labrinth/tests/v2/version.rs

@@ -219,7 +219,7 @@ async fn version_updates() {
 
             // Add 3 new versions, 1 before, and 2 after, with differing game_version/version_types/loaders
             let mut update_ids = vec![];
-            for (version_number, patch_value) in [
+            for (version_number, patch_value) in &[
                 (
                     "0.9.9",
                     json!({
@@ -241,9 +241,7 @@ async fn version_updates() {
                         "version_type": "beta"
                     }),
                 ),
-            ]
-            .iter()
-            {
+            ] {
                 let version = api
                     .add_public_version_deserialized_common(
                         *alpha_project_id_parsed,

apps/labrinth/tests/v2_tests.rs

@@ -1,5 +1,4 @@
-// importing common module.
-mod common;
+pub mod common;
 
 // Not all tests expect exactly the same functionality in v2 and v3.
 // For example, though we expect the /GET version to return the corresponding project,

apps/labrinth/tests/version.rs

@@ -22,8 +22,7 @@ use labrinth::models::projects::{
 use labrinth::routes::v3::version_file::FileUpdateData;
 use serde_json::json;
 
-// importing common module.
-mod common;
+pub mod common;
 
 #[actix_rt::test]
 async fn test_get_version() {
@@ -164,7 +163,7 @@ async fn version_updates() {
 
             // Add 3 new versions, 1 before, and 2 after, with differing game_version/version_types/loaders
             let mut update_ids = vec![];
-            for (version_number, patch_value) in [
+            for (version_number, patch_value) in &[
                 (
                     "0.9.9",
                     json!({
@@ -186,9 +185,7 @@ async fn version_updates() {
                         "version_type": "beta"
                     }),
                 ),
-            ]
-            .iter()
-            {
+            ] {
                 let version = api
                     .add_public_version_deserialized(
                         *alpha_project_id_parsed,

packages/app-lib/src/api/jre.rs

@@ -166,9 +166,8 @@ pub async fn test_jre(
     path: PathBuf,
     major_version: u32,
 ) -> crate::Result<bool> {
-    let jre = match jre::check_java_at_filepath(&path).await {
-        Some(jre) => jre,
-        None => return Ok(false),
+    let Some(jre) = jre::check_java_at_filepath(&path).await else {
+        return Ok(false);
     };
     let (major, _) = extract_java_majorminor_version(&jre.version)?;
     Ok(major == major_version)

packages/app-lib/src/api/pack/import/curseforge.rs

@@ -65,8 +65,7 @@ pub async fn import_curseforge(
         "Curseforge-{}",
         curseforge_instance_folder
             .file_name()
-            .map(|a| a.to_string_lossy().to_string())
-            .unwrap_or("Unknown".to_string())
+            .map_or("Unknown".to_string(), |a| a.to_string_lossy().to_string())
     );
 
     let state = State::get().await?;

packages/app-lib/src/api/pack/import/gdlauncher.rs

@@ -52,8 +52,7 @@ pub async fn import_gdlauncher(
         "GDLauncher-{}",
         gdlauncher_instance_folder
             .file_name()
-            .map(|a| a.to_string_lossy().to_string())
-            .unwrap_or("Unknown".to_string())
+            .map_or("Unknown".to_string(), |a| a.to_string_lossy().to_string())
     );
 
     // Re-cache icon

packages/app-lib/src/api/pack/import/mmc.rs

@@ -26,6 +26,7 @@ enum MMCInstanceEnum {
 struct MMCInstanceGeneral {
     pub general: MMCInstance,
 }
+
 #[derive(Serialize, Deserialize, Debug)]
 #[serde(rename_all = "PascalCase")]
 pub struct MMCInstance {
@@ -144,9 +145,9 @@ pub async fn is_valid_mmc(instance_folder: PathBuf) -> bool {
     let instance_cfg = instance_folder.join("instance.cfg");
     let mmc_pack = instance_folder.join("mmc-pack.json");
 
-    let mmc_pack = match io::read_any_encoding_to_string(&mmc_pack).await {
-        Ok((mmc_pack, _)) => mmc_pack,
-        Err(_) => return false,
+    let Ok((mmc_pack, _)) = io::read_any_encoding_to_string(&mmc_pack).await
+    else {
+        return false;
     };
 
     load_instance_cfg(&instance_cfg).await.is_ok()
@@ -233,7 +234,7 @@ pub async fn import_mmc(
                 // Kept separate as we may in the future want to add special handling for modrinth managed packs
                 import_mmc_unmanaged(profile_path, minecraft_folder, "Imported Modrinth Modpack".to_string(), description, mmc_pack).await?;
             }
-            Some(MMCManagedPackType::Flame) | Some(MMCManagedPackType::ATLauncher) => {
+            Some(MMCManagedPackType::Flame | MMCManagedPackType::ATLauncher) => {
                 // For flame/atlauncher managed packs
                 // Treat as unmanaged, but with 'minecraft' folder instead of '.minecraft'
                 import_mmc_unmanaged(profile_path, minecraft_folder, "Imported Modpack".to_string(), description, mmc_pack).await?;

packages/app-lib/src/api/pack/install_from.rs

@@ -357,9 +357,7 @@ pub async fn set_profile_information(
         }
     }
 
-    let game_version = if let Some(game_version) = game_version {
-        game_version
-    } else {
+    let Some(game_version) = game_version else {
         return Err(crate::ErrorKind::InputError(
             "Pack did not specify Minecraft version".to_string(),
         )
@@ -393,10 +391,7 @@ pub async fn set_profile_information(
                     locked: if !ignore_lock {
                         true
                     } else {
-                        prof.linked_data
-                            .as_ref()
-                            .map(|x| x.locked)
-                            .unwrap_or(true)
+                        prof.linked_data.as_ref().is_none_or(|x| x.locked)
                     },
                 })
             }

packages/app-lib/src/api/pack/install_mrpack.rs

@@ -152,8 +152,7 @@ pub async fn install_zipped_mrpack_files(
                     if let Some(env) = project.env {
                         if env
                             .get(&EnvType::Client)
-                            .map(|x| x == &SideType::Unsupported)
-                            .unwrap_or(false)
+                            .is_some_and(|x| x == &SideType::Unsupported)
                         {
                             return Ok(());
                         }

packages/app-lib/src/api/profile/mod.rs

@@ -586,7 +586,7 @@ pub async fn get_pack_export_candidates(
         .await
         .map_err(|e| IOError::with_path(e, &profile_base_dir))?
     {
-        let path: PathBuf = entry.path();
+        let path = entry.path();
         if path.is_dir() {
             // Two layers of files/folders if its a folder
             let mut read_dir = io::read_dir(&path).await?;
@@ -595,10 +595,10 @@ pub async fn get_pack_export_candidates(
                 .await
                 .map_err(|e| IOError::with_path(e, &profile_base_dir))?
             {
-                let path: PathBuf = entry.path();
-
-                path_list
-                    .push(pack_get_relative_path(&profile_base_dir, &path)?);
+                path_list.push(pack_get_relative_path(
+                    &profile_base_dir,
+                    &entry.path(),
+                )?);
             }
         } else {
             // One layer of files/folders if its a file
@@ -669,7 +669,7 @@ pub async fn run_credentials(
         if let Some(command) = cmd.next() {
             let full_path = get_full_path(&profile.path).await?;
             let result = Command::new(command)
-                .args(cmd.collect::<Vec<&str>>())
+                .args(cmd)
                 .current_dir(&full_path)
                 .spawn()
                 .map_err(|e| IOError::with_path(e, &full_path))?
@@ -881,15 +881,12 @@ pub async fn create_mrpack_json(
                 env.insert(EnvType::Client, SideType::Required);
                 env.insert(EnvType::Server, SideType::Required);
 
-                let primary_file =
-                    if let Some(primary_file) = version.files.first() {
-                        primary_file
-                    } else {
-                        return Some(Err(crate::ErrorKind::OtherError(
-                            format!("No primary file found for mod at: {path}"),
-                        )
-                        .as_error()));
-                    };
+                let Some(primary_file) = version.files.first() else {
+                    return Some(Err(crate::ErrorKind::OtherError(format!(
+                        "No primary file found for mod at: {path}"
+                    ))
+                    .as_error()));
+                };
 
                 let file_size = primary_file.size;
                 let downloads = vec![primary_file.url.clone()];

packages/app-lib/src/api/worlds.rs

@@ -255,7 +255,7 @@ async fn get_all_worlds_in_profile(
         AttachedWorldData::get_all_for_instance(profile_path, &state.pool)
             .await?;
     if !attached_data.is_empty() {
-        for world in worlds.iter_mut() {
+        for world in &mut worlds {
             if let Some(data) = attached_data
                 .get(&(world.world_type(), world.world_id().to_owned()))
             {

packages/app-lib/src/event/emit.rs

@@ -139,9 +139,7 @@ pub async fn edit_loading(
 // increment refers to by what relative increment to the loading struct's total to update
 // message is the message to display on the loading bar- if None, use the loading bar's default one
 // By convention, fraction is the fraction of the progress bar that is filled
-#[allow(unused_variables)]
 #[tracing::instrument(level = "debug")]
-
 pub fn emit_loading(
     key: &LoadingBarId,
     increment_frac: f64,
@@ -149,22 +147,13 @@ pub fn emit_loading(
 ) -> crate::Result<()> {
     let event_state = crate::EventState::get()?;
 
-    let mut loading_bar = match event_state.loading_bars.get_mut(&key.0) {
-        Some(f) => f,
-        None => {
-            return Err(EventError::NoLoadingBar(key.0).into());
-        }
+    let Some(mut loading_bar) = event_state.loading_bars.get_mut(&key.0) else {
+        return Err(EventError::NoLoadingBar(key.0).into());
     };
 
     // Tick up loading bar
     loading_bar.current += increment_frac;
     let display_frac = loading_bar.current / loading_bar.total;
-    let opt_display_frac = if display_frac >= 1.0 {
-        None // by convention, when its done, we submit None
-    // any further updates will be ignored (also sending None)
-    } else {
-        Some(display_frac)
-    };
 
     if f64::abs(display_frac - loading_bar.last_sent) > 0.005 {
         // Emit event to indicatif progress bar
@@ -187,7 +176,12 @@ pub fn emit_loading(
             .emit(
                 "loading",
                 LoadingPayload {
-                    fraction: opt_display_frac,
+                    fraction: if display_frac >= 1.0 {
+                        None // by convention, when its done, we submit None
+                    // any further updates will be ignored (also sending None)
+                    } else {
+                        Some(display_frac)
+                    },
                     message: message
                         .unwrap_or(&loading_bar.message)
                         .to_string(),
@@ -197,6 +191,9 @@ pub fn emit_loading(
             )
             .map_err(EventError::from)?;
 
+        #[cfg(not(any(feature = "cli", feature = "tauri")))]
+        let _ = message;
+
         loading_bar.last_sent = display_frac;
     }
 
@@ -204,8 +201,6 @@ pub fn emit_loading(
 }
 
 // emit_warning(message)
-#[allow(dead_code)]
-#[allow(unused_variables)]
 pub async fn emit_warning(message: &str) -> crate::Result<()> {
     #[cfg(feature = "tauri")]
     {
@@ -227,8 +222,6 @@ pub async fn emit_warning(message: &str) -> crate::Result<()> {
 // emit_command(CommandPayload::Something { something })
 // ie: installing a pack, opening an .mrpack, etc
 // Generally used for url deep links and file opens that we want to handle in the frontend
-#[allow(dead_code)]
-#[allow(unused_variables)]
 pub async fn emit_command(command: CommandPayload) -> crate::Result<()> {
     tracing::debug!("Command: {}", serde_json::to_string(&command)?);
     #[cfg(feature = "tauri")]

packages/app-lib/src/launcher/args.rs

@@ -87,9 +87,9 @@ pub fn get_lib_path(
     lib: &str,
     allow_not_exist: bool,
 ) -> crate::Result<String> {
-    let mut path = libraries_path.to_path_buf();
-
-    path.push(get_path_from_artifact(lib)?);
+    let path = libraries_path
+        .to_path_buf()
+        .join(get_path_from_artifact(lib)?);
 
     if !path.exists() && allow_not_exist {
         return Ok(path.to_string_lossy().to_string());

packages/app-lib/src/launcher/download.rs

@@ -37,12 +37,7 @@ pub async fn download_minecraft(
     let assets_index =
         download_assets_index(st, version, Some(loading_bar), force).await?;
 
-    let amount = if version
-        .processors
-        .as_ref()
-        .map(|x| !x.is_empty())
-        .unwrap_or(false)
-    {
+    let amount = if version.processors.as_ref().is_some_and(|x| !x.is_empty()) {
         25.0
     } else {
         40.0

packages/app-lib/src/launcher/mod.rs

@@ -17,7 +17,7 @@ use daedalus::modded::LoaderVersion;
 use regex::Regex;
 use serde::Deserialize;
 use st::Profile;
-use std::collections::HashMap;
+use std::fmt::Write;
 use std::path::PathBuf;
 use tokio::process::Command;
 
@@ -137,8 +137,7 @@ pub async fn get_java_version_from_profile(
     let key = version_info
         .java_version
         .as_ref()
-        .map(|it| it.major_version)
-        .unwrap_or(8);
+        .map_or(8, |it| it.major_version);
 
     let state = State::get().await?;
 
@@ -253,8 +252,7 @@ pub async fn install_minecraft(
 
         let loader_version_id = loader_version.clone();
         crate::api::profile::edit(&profile.path, |prof| {
-            prof.loader_version =
-                loader_version_id.clone().map(|x| x.id.clone());
+            prof.loader_version = loader_version_id.clone().map(|x| x.id);
 
             async { Ok(()) }
         })
@@ -279,8 +277,7 @@ pub async fn install_minecraft(
     let key = version_info
         .java_version
         .as_ref()
-        .map(|it| it.major_version)
-        .unwrap_or(8);
+        .map_or(8, |it| it.major_version);
     let (java_version, set_java) = if let Some(java_version) =
         get_java_version_from_profile(profile, &version_info).await?
     {
@@ -631,8 +628,7 @@ pub async fn launch_minecraft(
                     .as_ref()
                     .and_then(|x| x.get(&LoggingSide::Client)),
             )?
-            .into_iter()
-            .collect::<Vec<_>>(),
+            .into_iter(),
         )
         .arg(version_info.main_class.clone())
         .args(
@@ -650,8 +646,7 @@ pub async fn launch_minecraft(
                 &java_version.architecture,
                 quick_play_type,
             )?
-            .into_iter()
-            .collect::<Vec<_>>(),
+            .into_iter(),
         )
         .current_dir(instance_path.clone());
 
@@ -695,7 +690,7 @@ pub async fn launch_minecraft(
             // check if the regex exists in the file
             if !re.is_match(&options_string) {
                 // The key was not found in the file, so append it
-                options_string.push_str(&format!("\n{key}:{value}"));
+                write!(&mut options_string, "\n{key}:{value}").unwrap();
             } else {
                 let replaced_string = re
                     .replace_all(&options_string, &format!("{key}:{value}"))
@@ -715,31 +710,6 @@ pub async fn launch_minecraft(
     })
     .await?;
 
-    let mut censor_strings = HashMap::new();
-    let username = whoami::username();
-    censor_strings
-        .insert(format!("/{username}/"), "/{COMPUTER_USERNAME}/".to_string());
-    censor_strings.insert(
-        format!("\\{username}\\"),
-        "\\{COMPUTER_USERNAME}\\".to_string(),
-    );
-    censor_strings.insert(
-        credentials.access_token.clone(),
-        "{MINECRAFT_ACCESS_TOKEN}".to_string(),
-    );
-    censor_strings.insert(
-        credentials.username.clone(),
-        "{MINECRAFT_USERNAME}".to_string(),
-    );
-    censor_strings.insert(
-        credentials.id.as_simple().to_string(),
-        "{MINECRAFT_UUID}".to_string(),
-    );
-    censor_strings.insert(
-        credentials.id.as_hyphenated().to_string(),
-        "{MINECRAFT_UUID}".to_string(),
-    );
-
     // If in tauri, and the 'minimize on launch' setting is enabled, minimize the window
     #[cfg(feature = "tauri")]
     {

packages/app-lib/src/state/cache.rs

@@ -461,8 +461,7 @@ impl CacheValue {
             CacheValue::Team(members) => members
                 .iter()
                 .next()
-                .map(|x| x.team_id.as_str())
-                .unwrap_or(DEFAULT_ID)
+                .map_or(DEFAULT_ID, |x| x.team_id.as_str())
                 .to_string(),
             CacheValue::Organization(org) => org.id.clone(),
             CacheValue::File(file) => file.hash.clone(),
@@ -556,7 +555,6 @@ macro_rules! impl_cache_methods {
             $(
                 paste::paste! {
                     #[tracing::instrument(skip(pool, fetch_semaphore))]
-                    #[allow(dead_code)]
                     pub async fn [<get_ $variant:snake>](
                         id: &str,
                         cache_behaviour: Option<CacheBehaviour>,
@@ -568,7 +566,6 @@ macro_rules! impl_cache_methods {
                     }
 
                     #[tracing::instrument(skip(pool, fetch_semaphore))]
-                    #[allow(dead_code)]
                     pub async fn [<get_ $variant:snake _many>](
                         ids: &[&str],
                         cache_behaviour: Option<CacheBehaviour>,
@@ -597,7 +594,6 @@ macro_rules! impl_cache_method_singular {
             $(
                 paste::paste! {
                     #[tracing::instrument(skip(pool, fetch_semaphore))]
-                    #[allow(dead_code)]
                     pub async fn [<get_ $variant:snake>] (
                         cache_behaviour: Option<CacheBehaviour>,
                         pool: &SqlitePool,
@@ -735,18 +731,13 @@ impl CachedEntry {
 
                 remaining_keys.retain(|x| {
                     x != &&*row.id
-                        && !row
-                            .alias
-                            .as_ref()
-                            .map(|y| {
-                                if type_.case_sensitive_alias().unwrap_or(true)
-                                {
-                                    x == y
-                                } else {
-                                    y.to_lowercase() == x.to_lowercase()
-                                }
-                            })
-                            .unwrap_or(false)
+                        && !row.alias.as_ref().is_some_and(|y| {
+                            if type_.case_sensitive_alias().unwrap_or(true) {
+                                x == y
+                            } else {
+                                y.to_lowercase() == x.to_lowercase()
+                            }
+                        })
                 });
 
                 if let Some(data) = parsed_data {
@@ -991,7 +982,7 @@ impl CachedEntry {
                     let key = key.to_string();
 
                     if let Some(position) = teams.iter().position(|x| {
-                        x.first().map(|x| x.team_id == key).unwrap_or(false)
+                        x.first().is_some_and(|x| x.team_id == key)
                     }) {
                         let team = teams.remove(position);
 

packages/app-lib/src/state/dirs.rs

@@ -42,9 +42,8 @@ impl DirectoryInfo {
             ))
         })?;
 
-        let config_dir = config_dir
-            .map(PathBuf::from)
-            .unwrap_or_else(|| settings_dir.clone());
+        let config_dir =
+            config_dir.map_or_else(|| settings_dir.clone(), PathBuf::from);
 
         Ok(Self {
             settings_dir,
@@ -193,8 +192,7 @@ impl DirectoryInfo {
             let move_dir = settings
                 .custom_dir
                 .as_ref()
-                .map(PathBuf::from)
-                .unwrap_or_else(|| app_dir.clone());
+                .map_or_else(|| app_dir.clone(), PathBuf::from);
 
             async fn is_dir_writeable(
                 new_config_dir: &Path,
@@ -220,7 +218,7 @@ impl DirectoryInfo {
 
                 let disks = sysinfo::Disks::new_with_refreshed_list();
 
-                for disk in disks.iter() {
+                for disk in &disks {
                     if path.starts_with(disk.mount_point()) {
                         return Ok(Some(disk.available_space()));
                     }

packages/app-lib/src/state/friends.rs

@@ -174,7 +174,7 @@ impl FriendsSocket {
                                             ServerToClientMessage::FriendRequest { from } => {
                                                 let _ = emit_friend(FriendPayload::FriendRequest { from }).await;
                                             }
-                                            ServerToClientMessage::FriendRequestRejected { .. } => todo!(),
+                                            ServerToClientMessage::FriendRequestRejected { .. } => {}, // TODO
 
                                             ServerToClientMessage::FriendSocketListening { .. } => {}, // TODO
                                             ServerToClientMessage::FriendSocketStoppedListening { .. } => {}, // TODO

packages/app-lib/src/state/legacy_converter.rs

@@ -29,9 +29,7 @@ where
         return Ok(());
     };
 
-    let old_launcher_root = if let Some(dir) = default_settings_dir() {
-        dir
-    } else {
+    let Some(old_launcher_root) = default_settings_dir() else {
         return Ok(());
     };
     let old_launcher_root_str = old_launcher_root.to_string_lossy().to_string();
@@ -177,12 +175,10 @@ where
 
                 let profile_path = entry.path().join("profile.json");
 
-                let profile = if let Ok(profile) =
+                let Ok(profile) =
                     read_json::<LegacyProfile>(&profile_path, &io_semaphore)
                         .await
-                {
-                    profile
-                } else {
+                else {
                     continue;
                 };
 
@@ -285,7 +281,7 @@ where
 
                                         TeamMember {
                                             team_id: x.team_id,
-                                            user: user.clone(),
+                                            user,
                                             is_owner: x.role == "Owner",
                                             role: x.role,
                                             ordering: x.ordering,