Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 414236 Ð show_bug.cgi: Remove the knob in favor of normal <select> boxes

Browse Source 
Patch By Guy Pyrzak<guy.pyrzak@gmail.com> r=mkanat, a=LpSolit.
Removes knob from edit single and edit multiple bugs.


git-svn-id: svn://10.0.0.236/trunk@249984 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
guy.pyrzak%gmail.com
2008-04-10 16:34:01 +00:00
parent 96498ab8bb
commit 0014203b3d
11 changed files with 230 additions and 214 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
mozilla/webtools/bugzilla/process_bug.cgi
View File

@@ -495,23 +495,19 @@ if (!$cgi->param('id') && $cgi->param('dup_id')) {
# down here, because the validity of status changes depends on other fields,
# such as Target Milestone.
foreach my $b (@bug_objects) {
if (should_set('knob')) {
# First, get the correct resolution <select>, in case there is more
# than one open -> closed transition allowed. Allow to fallback to
# 'resolution' (useful when called from email_in.pl).
my $knob = $cgi->param('knob');
my $status = new Bugzilla::Status({name => $knob});
my $resolution;
if ($status) {
$resolution = $cgi->param('resolution_knob_' . $status->id)
|| $cgi->param('resolution');
}
else {
$resolution = $cgi->param('resolution_knob_change_resolution');
}
# Translate the knob values into new status and resolution values.
$b->process_knob($knob, $resolution, scalar $cgi->param('dup_id'));
if (should_set('bug_status')) {
$b->set_status(
scalar $cgi->param('bug_status'),
{resolution => scalar $cgi->param('resolution'),
dupe_of => scalar $cgi->param('dup_id')}
);
}
elsif (should_set('resolution')) {
$b->set_resolution(scalar $cgi->param('resolution'),
{dupe_of => scalar $cgi->param('dup_id')});
}
elsif (should_set('dup_id')) {
$b->set_dup_id(scalar $cgi->param('dup_id'));
}
}