Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve performance of SelectorMatches using nsIContent::HasAttr, which was added a few months ago. r=bzbarsky sr=attinasi a=asa b=128739

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@116716 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
dbaron%fas.harvard.edu
2002-03-16 15:24:08 +00:00
parent 12d4a64e95
commit 0076b3d38d
2 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
mozilla/content/html/style/src/nsCSSStyleSheet.cpp
View File

@@ -3663,16 +3663,19 @@ static PRBool SelectorMatches(RuleProcessorData &data,
} else {
result = localTrue;
nsAttrSelector* attr = aSelector->mAttrList;
nsAutoString value;
do {
nsresult attrState = data.mContent->GetAttr(attr->mNameSpace, attr->mAttr, value);
if (NS_FAILED(attrState) || (NS_CONTENT_ATTR_NOT_THERE == attrState)) {
if (!data.mContent->HasAttr(attr->mNameSpace, attr->mAttr)) {
result = localFalse;
}
else {
else if (attr->mFunction != NS_ATTR_FUNC_SET) {
nsAutoString value;
nsresult attrState =
data.mContent->GetAttr(attr->mNameSpace, attr->mAttr, value);
NS_ASSERTION(NS_SUCCEEDED(attrState) &&
NS_CONTENT_ATTR_NOT_THERE != attrState,
"HasAttr lied or GetAttr failed");
PRBool isCaseSensitive = attr->mCaseSensitive;
switch (attr->mFunction) {
case NS_ATTR_FUNC_SET: break;
case NS_ATTR_FUNC_EQUALS:
if (isCaseSensitive) {
result = PRBool(localTrue == value.Equals(attr->mValue));

13
mozilla/layout/style/nsCSSStyleSheet.cpp
View File

@@ -3663,16 +3663,19 @@ static PRBool SelectorMatches(RuleProcessorData &data,
} else {
result = localTrue;
nsAttrSelector* attr = aSelector->mAttrList;
nsAutoString value;
do {
nsresult attrState = data.mContent->GetAttr(attr->mNameSpace, attr->mAttr, value);
if (NS_FAILED(attrState) || (NS_CONTENT_ATTR_NOT_THERE == attrState)) {
if (!data.mContent->HasAttr(attr->mNameSpace, attr->mAttr)) {
result = localFalse;
}
else {
else if (attr->mFunction != NS_ATTR_FUNC_SET) {
nsAutoString value;
nsresult attrState =
data.mContent->GetAttr(attr->mNameSpace, attr->mAttr, value);
NS_ASSERTION(NS_SUCCEEDED(attrState) &&
NS_CONTENT_ATTR_NOT_THERE != attrState,
"HasAttr lied or GetAttr failed");
PRBool isCaseSensitive = attr->mCaseSensitive;
switch (attr->mFunction) {
case NS_ATTR_FUNC_SET: break;
case NS_ATTR_FUNC_EQUALS:
if (isCaseSensitive) {
result = PRBool(localTrue == value.Equals(attr->mValue));