Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for bug #13439: SelectAll Delete does not repaint entire edit area

Browse Source 
- Removed all references to mUpdateBatchCnt
    in nsViewManager::UpdateView().

  - The methods Enable/DisableRefresh() now check to
    see if we are batching before executing their code.
    This will prevent any layout/parser code from turning
    on refresh before all Begin/EndUpdateViewBatch() calls
    are unwound.


git-svn-id: svn://10.0.0.236/trunk@47645 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
kin%netscape.com 1999-09-15 20:39:03 +00:00
parent d0370bd7bf
commit 06c17f0ef0
1 changed files with 19 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
mozilla/view/src/nsViewManager.cpp
View File

@ -1374,7 +1374,7 @@ NS_IMETHODIMP nsViewManager::UpdateView(nsIView *aView, nsIRegion *aRegion, PRUi
NS_IMETHODIMP nsViewManager :: UpdateView(nsIView *aView, const nsRect &aRect, PRUint32 aUpdateFlags)
{
NS_PRECONDITION(nsnull != aView, "null view");
if (!mRefreshEnabled && 0 == mUpdateBatchCnt) {
if (!mRefreshEnabled) {
// accumulate this rectangle in the view's dirty region, so we can process it later.
AddRectToDirtyRegion(aView, aRect);
++mUpdateCnt;
@ -1424,7 +1424,7 @@ NS_IMETHODIMP nsViewManager :: UpdateView(nsIView *aView, const nsRect &aRect, P
if (nsnull != widgetView)
{
if (0 == mUpdateCnt && 0 == mUpdateBatchCnt)
if (0 == mUpdateCnt)
RestartTimer();
mUpdateCnt++;
@ -1453,22 +1453,19 @@ NS_IMETHODIMP nsViewManager :: UpdateView(nsIView *aView, const nsRect &aRect, P
// See if we should do an immediate refresh or wait
if (0 == mUpdateBatchCnt)
if (aUpdateFlags & NS_VMREFRESH_IMMEDIATE)
{
if (aUpdateFlags & NS_VMREFRESH_IMMEDIATE)
{
Composite();
}
else if ((mTrueFrameRate > 0) && !(aUpdateFlags & NS_VMREFRESH_NO_SYNC))
{
// or if a sync paint is allowed and it's time for the compositor to
// do a refresh
PRInt32 deltams = PR_IntervalToMilliseconds(PR_IntervalNow() - mLastRefresh);
if (deltams > (1000 / (PRInt32)mTrueFrameRate))
Composite();
}
else if ((mTrueFrameRate > 0) && !(aUpdateFlags & NS_VMREFRESH_NO_SYNC))
{
// or if a sync paint is allowed and it's time for the compositor to
// do a refresh
PRInt32 deltams = PR_IntervalToMilliseconds(PR_IntervalNow() - mLastRefresh);
if (deltams > (1000 / (PRInt32)mTrueFrameRate))
Composite();
}
}
}
@ -2273,12 +2270,18 @@ void nsViewManager :: UpdateTransCnt(nsIView *oldview, nsIView *newview)
NS_IMETHODIMP nsViewManager :: DisableRefresh(void)
{
if (mUpdateBatchCnt > 0)
return NS_OK;
mRefreshEnabled = PR_FALSE;
return NS_OK;
}
NS_IMETHODIMP nsViewManager :: EnableRefresh(void)
{
if (mUpdateBatchCnt > 0)
return NS_OK;
mRefreshEnabled = PR_TRUE;
if (mUpdateCnt > 0)