From 0714ad586e4ca06ee4bb54afcd39b1779c26d38f Mon Sep 17 00:00:00 2001 From: "reed%reedloden.com" Date: Wed, 20 Dec 2006 05:14:24 +0000 Subject: [PATCH] Bug 364195 - "No way to search for private comments" [p=reed r=justdave a=justdave] git-svn-id: svn://10.0.0.236/trunk@217228 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/bugzilla/Bugzilla/Field.pm | 1 + mozilla/webtools/bugzilla/Bugzilla/Search.pm | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/mozilla/webtools/bugzilla/Bugzilla/Field.pm b/mozilla/webtools/bugzilla/Bugzilla/Field.pm index 782ee558154..dd885cd55b9 100644 --- a/mozilla/webtools/bugzilla/Bugzilla/Field.pm +++ b/mozilla/webtools/bugzilla/Bugzilla/Field.pm @@ -168,6 +168,7 @@ use constant DEFAULT_FIELDS => ( {name => 'creation_ts', desc => 'Creation date', in_new_bugmail => 1}, {name => 'delta_ts', desc => 'Last changed date', in_new_bugmail => 1}, {name => 'longdesc', desc => 'Comment'}, + {name => 'longdescs.isprivate', desc => 'Comment is private'}, {name => 'alias', desc => 'Alias'}, {name => 'everconfirmed', desc => 'Ever Confirmed'}, {name => 'reporter_accessible', desc => 'Reporter Accessible'}, diff --git a/mozilla/webtools/bugzilla/Bugzilla/Search.pm b/mozilla/webtools/bugzilla/Bugzilla/Search.pm index d0b0cd6ba15..c20abc418a3 100644 --- a/mozilla/webtools/bugzilla/Bugzilla/Search.pm +++ b/mozilla/webtools/bugzilla/Bugzilla/Search.pm @@ -707,6 +707,18 @@ sub init { "ON $table.bug_id = bugs.bug_id $extra"); $f = "$table.thetext"; }, + "^longdescs\.isprivate," => sub { + my $table = "longdescs_$chartid"; + my $extra = ""; + if (Bugzilla->params->{"insidergroup"} + && !Bugzilla->user->in_group(Bugzilla->params->{"insidergroup"})) + { + $extra = "AND $table.isprivate < 1"; + } + push(@supptables, "INNER JOIN longdescs AS $table " . + "ON $table.bug_id = bugs.bug_id $extra"); + $f = "$table.isprivate"; + }, "^work_time,changedby" => sub { my $table = "longdescs_$chartid"; push(@supptables, "INNER JOIN longdescs AS $table " .