From 0bf660e6a56cddbded6a58fcd3d847c38beb2ad2 Mon Sep 17 00:00:00 2001
From: "sspitzer%netscape.com"
 <sspitzer%netscape.com@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Thu, 24 Jun 1999 21:16:01 +0000
Subject: [PATCH] check return values.  don't compare a nsresult with NS_OK
 directory, use the macros.

git-svn-id: svn://10.0.0.236/trunk@36726 18797224-902f-48f8-a5cc-f745e15eee43
---
 mozilla/xpfe/AppCores/src/nsBrowserAppCore.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/mozilla/xpfe/AppCores/src/nsBrowserAppCore.cpp b/mozilla/xpfe/AppCores/src/nsBrowserAppCore.cpp
index c3ac9668208..2aab443579f 100644
--- a/mozilla/xpfe/AppCores/src/nsBrowserAppCore.cpp
+++ b/mozilla/xpfe/AppCores/src/nsBrowserAppCore.cpp
@@ -282,19 +282,21 @@ nsBrowserAppCore::Init(const nsString& aId)
   nsresult rv = nsServiceManager::GetService(kAppCoresManagerCID,
                                              kIDOMAppCoresManagerIID,
                                              (nsISupports**)&appCoreManager);
-  if (NS_OK == rv) {
+  if (NS_SUCCEEDED(rv)) {
 	  appCoreManager->Add((nsIDOMBaseAppCore *)(nsBaseAppCore *)this);
     nsServiceManager::ReleaseService(kAppCoresManagerCID, appCoreManager);
   }
 
   // Get the Global history service  
-  nsServiceManager::GetService(kCGlobalHistoryCID, kIGlobalHistoryIID,
+  rv = nsServiceManager::GetService(kCGlobalHistoryCID, kIGlobalHistoryIID,
 					(nsISupports **)&mGHistory);
+  if (NS_FAILED(rv)) return rv;
 
   rv = nsComponentManager::CreateInstance(kCSessionHistoryCID,
                                           nsnull,
                                           kISessionHistoryIID,
                                           (void **) &mSHistory);
+  if (NS_FAILED(rv)) return rv;
 
   BeginObserving();
 
@@ -338,7 +340,7 @@ nsBrowserAppCore::Reload(PRInt32  aType)
 	return NS_OK;
 }   
 
-NS_IMETHODIMP    
+NS_IMETHODIMP
 nsBrowserAppCore::Forward()
 {
   GoForward(mContentAreaWebShell);