From 0d50ed8549d0dc75c9b1b36c71e07c07e342247d Mon Sep 17 00:00:00 2001 From: "mrbkap%gmail.com" Date: Wed, 18 Jan 2006 23:06:06 +0000 Subject: [PATCH] bug 322773: The prompt service asserts if there our window doesn't have a document. r+sr=bzbarsky git-svn-id: svn://10.0.0.236/trunk@187783 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/content/base/src/nsFrameLoader.cpp | 6 +++++- mozilla/docshell/base/nsDocShell.cpp | 9 +++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/mozilla/content/base/src/nsFrameLoader.cpp b/mozilla/content/base/src/nsFrameLoader.cpp index da801e71731..356706dfbc3 100644 --- a/mozilla/content/base/src/nsFrameLoader.cpp +++ b/mozilla/content/base/src/nsFrameLoader.cpp @@ -188,7 +188,11 @@ nsFrameLoader::LoadURI(nsIURI* aURI) // Kick off the load... rv = mDocShell->LoadURI(aURI, loadInfo, nsIWebNavigation::LOAD_FLAGS_NONE, PR_FALSE); - NS_ASSERTION(NS_SUCCEEDED(rv), "failed to load URL"); +#ifdef DEBUG + if (NS_FAILED(rv)) { + NS_WARNING("Failed to load the URL"); + } +#endif return rv; } diff --git a/mozilla/docshell/base/nsDocShell.cpp b/mozilla/docshell/base/nsDocShell.cpp index c665db1f164..90876eda1d5 100644 --- a/mozilla/docshell/base/nsDocShell.cpp +++ b/mozilla/docshell/base/nsDocShell.cpp @@ -3095,6 +3095,15 @@ nsDocShell::DisplayLoadError(nsresult aError, nsIURI *aURI, } else { + // The prompter reqires that our private window has a document (or it + // asserts). Satisfy that assertion now since GetDocument will force + // creation of one if it hasn't already been created. + nsCOMPtr pwin(do_QueryInterface(mScriptGlobal)); + if (pwin) { + nsCOMPtr doc; + pwin->GetDocument(getter_AddRefs(doc)); + } + // Display a message box prompter->Alert(nsnull, messageStr.get()); }