From 0e41748e11fcce40a70f5656dfadfbeeff5aacef Mon Sep 17 00:00:00 2001 From: "stefanh%inbox.com" Date: Sun, 13 May 2007 21:36:09 +0000 Subject: [PATCH] Bug 346605 - Make openHelp() calls call suiterunner help correctly: Remove help buttons/js from Composer dialogs and use an overlay in suite/common instead. r=IanN, sr=Neil. git-svn-id: svn://10.0.0.236/trunk@226362 18797224-902f-48f8-a5cc-f745e15eee43 --- .../ui/dialogs/content/EdAdvancedEdit.js | 6 -- .../ui/dialogs/content/EdAdvancedEdit.xul | 7 +- .../editor/ui/dialogs/content/EdImageMap.js | 5 -- .../editor/ui/dialogs/content/EdImageMap.xul | 6 +- .../editor/ui/dialogs/content/EdImageProps.js | 6 -- .../ui/dialogs/content/EdImageProps.xul | 6 +- .../editor/ui/dialogs/content/EdLinkProps.js | 6 -- .../editor/ui/dialogs/content/EdLinkProps.xul | 6 +- .../editor/ui/dialogs/content/EdTableProps.js | 5 -- .../ui/dialogs/content/EdTableProps.xul | 7 +- .../ui/dialogs/content/EditorPublish.js | 8 -- .../ui/dialogs/content/EditorPublish.xul | 7 +- .../dialogs/content/EditorPublishProgress.js | 5 -- .../dialogs/content/EditorPublishProgress.xul | 3 +- .../dialogs/content/EditorPublishSettings.js | 6 -- .../dialogs/content/EditorPublishSettings.xul | 7 +- .../chrome/dialogs/EditorPublishProgress.dtd | 2 - .../help/resources/content/contents.rdf | 35 ++++++++ mozilla/extensions/help/resources/jar.mn | 28 +----- mozilla/suite/common/helpEditorOverlay.xul | 87 +++++++++++++++++++ mozilla/suite/common/jar.mn | 8 ++ 21 files changed, 150 insertions(+), 106 deletions(-) create mode 100644 mozilla/suite/common/helpEditorOverlay.xul diff --git a/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.js b/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.js index bf76b7dc86c..5e000746c64 100644 --- a/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.js +++ b/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.js @@ -354,12 +354,6 @@ function AddTreeItem ( name, value, treeChildrenId, attArray ) return treeitem; } -function doHelpButton() -{ - openHelp("advanced_property_editor"); - return true; -} - function selectTreeItem(treeChildren, item) { var index = treeChildren.parentNode.contentView.getIndexOfItem(item); diff --git a/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.xul b/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.xul index 865e06cd020..0d274957e3e 100644 --- a/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.xul +++ b/mozilla/editor/ui/dialogs/content/EdAdvancedEdit.xul @@ -48,13 +48,13 @@ + ondialogcancel="return onCancel();"> + + + + + + + + + + + + + + + + diff --git a/mozilla/suite/common/jar.mn b/mozilla/suite/common/jar.mn index 01114c5382f..d0a8cd459f4 100644 --- a/mozilla/suite/common/jar.mn +++ b/mozilla/suite/common/jar.mn @@ -9,6 +9,13 @@ comm.jar: % overlay chrome://help/content/help.xul chrome://communicator/content/helpOverlay.xul % overlay chrome://communicator/content/tasksOverlay.xul chrome://communicator/content/emOverlay.xul % overlay chrome://communicator/content/pref/preftree.xul chrome://pippki/content/PrefOverlay.xul +% overlay chrome://editor/content/EdAdvancedEdit.xul chrome://communicator/content/helpEditorOverlay.xul +% overlay chrome://editor/content/EdImageProps.xul chrome://communicator/content/helpEditorOverlay.xul +% overlay chrome://editor/content/EditorPublish.xul chrome://communicator/content/helpEditorOverlay.xul +% overlay chrome://editor/content/EditorPublishProgress.xul chrome://communicator/content/helpEditorOverlay.xul +% overlay chrome://editor/content/EditorPublishSettings.xul chrome://communicator/content/helpEditorOverlay.xul +% overlay chrome://editor/content/EdLinkProps.xul chrome://communicator/content/helpEditorOverlay.xul +% overlay chrome://editor/content/EdTableProps.xul chrome://communicator/content/helpEditorOverlay.xul % overlay chrome://pippki/content/certManager.xul chrome://communicator/content/helpSecurityOverlay.xul % overlay chrome://pippki/content/certViewer.xul chrome://communicator/content/helpSecurityOverlay.xul % overlay chrome://pippki/content/changepassword.xul chrome://communicator/content/helpSecurityOverlay.xul @@ -62,6 +69,7 @@ comm.jar: content/communicator/editorBindings.xul content/communicator/emOverlay.xul content/communicator/findUtils.js + content/communicator/helpEditorOverlay.xul content/communicator/helpMessengerOverlay.xul content/communicator/helpSecurityOverlay.xul content/communicator/helpOverlay.js