From 0f1acb709a76a7f13c7adb0f5ee4c93d88462dab Mon Sep 17 00:00:00 2001 From: "guy.pyrzak%gmail.com" Date: Fri, 23 Jan 2009 21:08:27 +0000 Subject: [PATCH] Bug 471518: "Field only appears when:" produces a JavaScript error in Internet Explorer Patch By Jill Foley r=mkanat, a=mkanat git-svn-id: svn://10.0.0.236/trunk@255907 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/bugzilla/js/util.js | 2 +- .../template/en/default/admin/custom_fields/cf-js.js.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mozilla/webtools/bugzilla/js/util.js b/mozilla/webtools/bugzilla/js/util.js index 86924210ca8..8e787847a4d 100644 --- a/mozilla/webtools/bugzilla/js/util.js +++ b/mozilla/webtools/bugzilla/js/util.js @@ -166,7 +166,7 @@ function bz_isValueInArray(aArray, aValue) */ function bz_createOptionInSelect(aSelect, aTextValue, aValue) { var myOption = new Option(aTextValue, aValue); - aSelect.appendChild(myOption); + aSelect.options[aSelect.length] = myOption; return myOption; } diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/cf-js.js.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/cf-js.js.tmpl index 6c5bbf62624..891f5da7641 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/cf-js.js.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/cf-js.js.tmpl @@ -27,7 +27,7 @@ var select_values = new Array(); [% FOREACH sel_field = Bugzilla.get_fields({ is_select => 1 }) %] select_values[[% sel_field.id FILTER js %]] = [ [% FOREACH legal_value = sel_field.legal_values %] - [[% legal_value.id FILTER js %], '[% legal_value.name FILTER html %]'], + [[% legal_value.id FILTER js %], '[% legal_value.name FILTER html %]'][% ',' UNLESS loop.last %] [% END %] ]; [% END %]