diff --git a/mozilla/webtools/bugzilla/admineditor.pl b/mozilla/webtools/bugzilla/admineditor.pl index 8ac6d8cf567..6b6287d88d4 100644 --- a/mozilla/webtools/bugzilla/admineditor.pl +++ b/mozilla/webtools/bugzilla/admineditor.pl @@ -59,28 +59,28 @@ $::wentwrong = 'Something went wrong.'; ################################################################################ # What we're editing eg ('resolution', 'Resolution', 'resolutions'). -#my ($::valuetype, $::valuetypeicap, $::valuetypeplural); +($::valuetype, $::valuetypeicap, $::valuetypeplural) = (); # What group you have to be in to edit these. -#my $::grouprestrict; +$::grouprestrict = undef; # The name of the CGI calling the editor. -#my $::thiscgi; +$::thiscgi = undef; # The name of the table that stores what we're editing. -#my $::tablename; +$::tablename = undef; # The name of the table that has references to what we're editing. # This currently doesn't support multiple references. -#my $::bugsreftablename; +$::bugsreftablename = undef; # The full field name of the field that has references to what we're editing, # eg 'bugs.resolution_id'. -#my $::bugsreffieldref; +$::bugsreffieldref = undef; # The maximum number of characters allowed in the name of what we're editing. # Get this information from the schema. -#my $::maxnamesize; +$::maxnamesize = undef; ################################################################################ # The following may be changed by the caller. @@ -239,34 +239,35 @@ sub AdminEditor() { confirm_login(); $::db->{Taint} = 1; + $::db->{Taint} = 1; # Silliness unless (UserInGroup($::grouprestrict)) { - DisplayError("Sorry, you aren't a member of the $::grouprestrict group. " . - "And so, you aren't allowed to add, modify or delete $::valuetypeplural.", - "Not allowed"); - exit; + DisplayError("Sorry, you aren't a member of the $::grouprestrict group. " . + "And so, you aren't allowed to add, modify or delete $::valuetypeplural.", + "Not allowed"); + exit; } # Define the global variables and functions that will be passed to the UI # template. Individual functions add their own values to this hash before # sending them to the templates they process. $vars = { - # Function for retrieving global parameters. - 'Param' => \&Param, - - # Function for processing global parameters that contain references - # to other global parameters. - 'PerformSubsts' => \&PerformSubsts, - - # Uses for links that point back to this script. - 'thiscgi' => $::thiscgi, - - # What we are actually editing. - 'valuetype' => $::valuetype, - 'valuetypeicap' => $::valuetypeicap, - - # Maximum size allowed for a name of this value - 'maxnamesize' => $::maxnamesize, + # Function for retrieving global parameters. + 'Param' => \&Param, + + # Function for processing global parameters that contain references + # to other global parameters. + 'PerformSubsts' => \&PerformSubsts, + + # Uses for links that point back to this script. + 'thiscgi' => $::thiscgi, + + # What we are actually editing. + 'valuetype' => $::valuetype, + 'valuetypeicap' => $::valuetypeicap, + + # Maximum size allowed for a name of this value + 'maxnamesize' => $::maxnamesize, }; &$::extravarsref($vars); @@ -282,43 +283,43 @@ sub AdminEditor() { if ($action eq "list") { - ListScreen(""); + ListScreen(""); } elsif ($action eq "add") { - - CreateScreen(); - + + CreateScreen(); + } elsif ($action eq "new") { - - ValidateName(\%fields); - ValidateDesc(\%fields); - &$::validaterestref(\%fields); - InsertNew(%fields); - + + ValidateName(\%fields); + ValidateDesc(\%fields); + &$::validaterestref(\%fields); + InsertNew(%fields); + } elsif ($action eq "edit") { - - ValidateID(\%fields); - EditScreen(%fields); - + + ValidateID(\%fields); + EditScreen(%fields); + } elsif ($action eq "update") { - - ValidateID(\%fields); - ValidateName(\%fields); - ValidateDesc(\%fields); - ValidateIsActive(\%fields); - &$::validaterestref(\%fields); - UpdateExisting(%fields); - + + ValidateID(\%fields); + ValidateName(\%fields); + ValidateDesc(\%fields); + ValidateIsActive(\%fields); + &$::validaterestref(\%fields); + UpdateExisting(%fields); + } elsif ($action eq "delete") { - - ValidateID(\%fields); - DeleteExisting(%fields); - + + ValidateID(\%fields); + DeleteExisting(%fields); + } else { - - print "Content-type: text/html\n\n"; - ThatDoesntValidate("action"); - + + print "Content-type: text/html\n\n"; + ThatDoesntValidate("action"); + } } @@ -348,7 +349,7 @@ sub ListScreen ($) { $bugcount ||= 0; push( @values, { 'id' => $id, 'name' => $name, 'description' => $description, - 'isactive' => $isactive, 'bugcount' => $bugcount } ); + 'isactive' => $isactive, 'bugcount' => $bugcount } ); } # Define the variables and functions that will be passed to the UI template. @@ -545,7 +546,7 @@ sub DeleteExisting (%) { } if ($bugcount > 0) { - &$::deleterefsref($id); + &$::deleterefsref($id); } SendSQL("DELETE FROM $::tablename WHERE id = $id"); diff --git a/mozilla/webtools/bugzilla/bug_form.pl b/mozilla/webtools/bugzilla/bug_form.pl index 207204d4aa4..223b5cd3d2c 100644 --- a/mozilla/webtools/bugzilla/bug_form.pl +++ b/mozilla/webtools/bugzilla/bug_form.pl @@ -160,7 +160,7 @@ print "
| Bug#: | $bug{'bug_id'} | - | Platform: | +Platform: | Reporter: | $bug{'reporter'} | @@ -190,21 +190,21 @@ print "CC: | $cc_element | ||
| Status: | +Status: | $bug{'bug_status'} | - | Priority: | +Priority: | |||||
| Resolution: | +Resolution: | $bug{'resolution'} | - | Severity: | +Severity: | |||||
| Assigned To: + | Assigned To: | $bug{'assigned_to'} | "; @@ -493,7 +493,7 @@ if ($canedit || $::userid == $assignedtoid || my $resolution_popup = make_options(\@::settable_normal_resolution, $bug{'resolution'}); print " - Resolve bug, changing resolution to + Resolve bug, changing resolution to |
-
|
Note that the operating system implies the platform, but not always. +For example, Linux can run on PC and Macintosh and others.
This is the person in charge of resolving the bug. Every time this +field changes, the status changes to NEW to make it easy to see +which new bugs have appeared on a person's list.
-The default status for queries is set to NEW, ASSIGNED and REOPENED. When +The default status for queries is set to NEW, ASSIGNED and REOPENED. When searching for bugs that have been resolved or verified, remember to set the -status field appropriately. +status field appropriately.
-