Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 653341: Bug.create() fails to error out if an invalid group is passed

Browse Source 
r/a=mkanat


git-svn-id: svn://10.0.0.236/branches/BUGZILLA-4_0-BRANCH@262298 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mkanat%bugzilla.org 2011-05-06 21:05:42 +00:00
parent e9c6041d72
commit 1af3f824a7
5 changed files with 27 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@ -1 +1 @@
7592
7593

13
mozilla/webtools/bugzilla/Bugzilla/Bug.pm
View File

@ -1615,11 +1615,14 @@ sub _check_groups {
# First check all the groups they chose to set.
foreach my $name (@$group_names) {
# We don't want to expose the existence or non-existence of groups,
# so instead of doing check(), we just do "next" on an invalid
# group.
my $group = new Bugzilla::Group({ name => $name }) or next;
next if !$product->group_is_settable($group);
my $group = Bugzilla::Group->check(
{ name => $name, product => $product,
_error => 'group_restriction_not_allowed' });
if (!$product->group_is_settable($group)) {
ThrowUserError('group_restriction_not_allowed',
{ name => $name, product => $product });
}
$add_groups{$group->id} = $group;
}
}

14
mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm
View File

@ -2275,9 +2275,8 @@ is private, otherwise it is assumed to be public.
=item C<groups> (array) - An array of group names to put this
bug into. You can see valid group names on the Permissions
tab of the Preferences screen, or, if you are an administrator,
in the Groups control panel. Note that invalid group names or
groups that the bug can't be restricted to are silently ignored. If
you don't specify this argument, then a bug will be added into
in the Groups control panel.
If you don't specify this argument, then the bug will be added into
all the groups that are set as being "Default" for this product. (If
you want to avoid that, you should specify C<groups> as an empty array.)
@ -2338,6 +2337,11 @@ You didn't specify a summary for the bug.
You specified values in the C<blocks> or C<depends_on> fields
that would cause a circular dependency between bugs.
=item 120 (Group Restriction Denied)
You tried to restrict the bug to a group which does not exist, or which
you cannot use with this product.
=item 504 (Invalid User)
Either the QA Contact, Assignee, or CC lists have some invalid user
@ -2354,7 +2358,9 @@ B<Required>, due to a bug in Bugzilla.
=item The C<groups> argument was added in Bugzilla B<4.0>. Before
Bugzilla 4.0, bugs were only added into Mandatory groups by this
method.
method. Since Bugzilla B<4.0.2>, passing an illegal group name will
throw an error. In Bugzilla 4.0 and 4.0.1, illegal group names were
silently ignored.
=item The C<comment_is_private> argument was added in Bugzilla B<4.0>.
Before Bugzilla 4.0, you had to use the undocumented C<commentprivacy>

1
mozilla/webtools/bugzilla/Bugzilla/WebService/Constants.pm
View File

@ -111,6 +111,7 @@ use constant WS_ERROR_CODE => {
# Group errors
group_change_denied => 120,
group_invalid_restriction => 120,
group_restriction_not_allowed => 120,
# Status/Resolution errors
missing_resolution => 121,
resolution_not_allowed => 122,

7
mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl
View File

@ -744,6 +744,13 @@
'[% product FILTER html %]' product can not be restricted to
that group.
[% ELSIF error == "group_restriction_not_allowed" %]
[% title = "Group Restriction Not Allowed" %]
You tried to restrict [% terms.abug %] to the "[% name FILTER html %]"
group, but either this group does not exist, or you are not allowed
to restrict [% terms.bugs %] to this group in the "[% product.name FILTER html %]"
product.
[% ELSIF error == "group_not_specified" %]
[% title = "Group not specified" %]
No group was specified.