From 1e824d81bce599e7185b3249b75210c02e3a0e63 Mon Sep 17 00:00:00 2001
From: "rickg%netscape.com"
 <rickg%netscape.com@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Tue, 15 Jun 1999 02:03:33 +0000
Subject: [PATCH] more error reporting in ToInteger()

git-svn-id: svn://10.0.0.236/trunk@35316 18797224-902f-48f8-a5cc-f745e15eee43
---
 mozilla/string/obsolete/nsString2.cpp       | 21 +++++++++++++++------
 mozilla/xpcom/ds/nsString2.cpp              | 21 +++++++++++++++------
 mozilla/xpcom/string/obsolete/nsString2.cpp | 21 +++++++++++++++------
 3 files changed, 45 insertions(+), 18 deletions(-)

diff --git a/mozilla/string/obsolete/nsString2.cpp b/mozilla/string/obsolete/nsString2.cpp
index 72e0364b518..12fbce19122 100644
--- a/mozilla/string/obsolete/nsString2.cpp
+++ b/mozilla/string/obsolete/nsString2.cpp
@@ -756,7 +756,7 @@ PRInt32 GetNumericSubstring(nsString2& aString,PRUint32& aRadix) {
     else if((*cp>='A') && (*cp<='F')) {
       continue;
     }
-    else if((*cp>='-') || (*cp>='+')){
+    else if((*cp=='-') || (*cp=='+')){
       break;
     }
     else {
@@ -794,13 +794,17 @@ PRInt32 nsString2::ToInteger(PRInt32* anErrorCode) const {
    ********************************************************************************/
 
   //copy chars to local buffer -- step down from 2 bytes to 1 if necessary...
-  nsAutoString2 theString(*this,eOneByte);
-  PRUint32  theRadix=10;
-  PRInt32   result=GetNumericSubstring(theString,theRadix);
+  PRInt32 result=0;
+  if(0<mLength) {
+    nsAutoString2 theString(*this,eOneByte);
+    PRUint32  theRadix=10;
+    *anErrorCode=GetNumericSubstring(theString,theRadix);
 
-  if(NS_OK==result){
-    result=_ToInteger(theString,anErrorCode,theRadix);
+    if(NS_OK==*anErrorCode){
+      result=_ToInteger(theString,anErrorCode,theRadix);
+    }
   }
+  else *anErrorCode=NS_ERROR_ILLEGAL_VALUE;
   return result;
 }
 
@@ -2175,8 +2179,13 @@ CStringTester::CStringTester() {
   //try a few numeric conversion routines...
   {
     nsString2 str1("10000",theSize);
+    nsString2 str2("hello");
+    nsString2 str3;
     PRInt32 err;
     PRInt32 theInt=str1.ToInteger(&err);
+    theInt=str2.ToInteger(&err);
+    theInt=str3.ToInteger(&err);
+
     str1="100.100";
     float theFloat=str1.ToFloat(&err);
   }
diff --git a/mozilla/xpcom/ds/nsString2.cpp b/mozilla/xpcom/ds/nsString2.cpp
index 72e0364b518..12fbce19122 100644
--- a/mozilla/xpcom/ds/nsString2.cpp
+++ b/mozilla/xpcom/ds/nsString2.cpp
@@ -756,7 +756,7 @@ PRInt32 GetNumericSubstring(nsString2& aString,PRUint32& aRadix) {
     else if((*cp>='A') && (*cp<='F')) {
       continue;
     }
-    else if((*cp>='-') || (*cp>='+')){
+    else if((*cp=='-') || (*cp=='+')){
       break;
     }
     else {
@@ -794,13 +794,17 @@ PRInt32 nsString2::ToInteger(PRInt32* anErrorCode) const {
    ********************************************************************************/
 
   //copy chars to local buffer -- step down from 2 bytes to 1 if necessary...
-  nsAutoString2 theString(*this,eOneByte);
-  PRUint32  theRadix=10;
-  PRInt32   result=GetNumericSubstring(theString,theRadix);
+  PRInt32 result=0;
+  if(0<mLength) {
+    nsAutoString2 theString(*this,eOneByte);
+    PRUint32  theRadix=10;
+    *anErrorCode=GetNumericSubstring(theString,theRadix);
 
-  if(NS_OK==result){
-    result=_ToInteger(theString,anErrorCode,theRadix);
+    if(NS_OK==*anErrorCode){
+      result=_ToInteger(theString,anErrorCode,theRadix);
+    }
   }
+  else *anErrorCode=NS_ERROR_ILLEGAL_VALUE;
   return result;
 }
 
@@ -2175,8 +2179,13 @@ CStringTester::CStringTester() {
   //try a few numeric conversion routines...
   {
     nsString2 str1("10000",theSize);
+    nsString2 str2("hello");
+    nsString2 str3;
     PRInt32 err;
     PRInt32 theInt=str1.ToInteger(&err);
+    theInt=str2.ToInteger(&err);
+    theInt=str3.ToInteger(&err);
+
     str1="100.100";
     float theFloat=str1.ToFloat(&err);
   }
diff --git a/mozilla/xpcom/string/obsolete/nsString2.cpp b/mozilla/xpcom/string/obsolete/nsString2.cpp
index 72e0364b518..12fbce19122 100644
--- a/mozilla/xpcom/string/obsolete/nsString2.cpp
+++ b/mozilla/xpcom/string/obsolete/nsString2.cpp
@@ -756,7 +756,7 @@ PRInt32 GetNumericSubstring(nsString2& aString,PRUint32& aRadix) {
     else if((*cp>='A') && (*cp<='F')) {
       continue;
     }
-    else if((*cp>='-') || (*cp>='+')){
+    else if((*cp=='-') || (*cp=='+')){
       break;
     }
     else {
@@ -794,13 +794,17 @@ PRInt32 nsString2::ToInteger(PRInt32* anErrorCode) const {
    ********************************************************************************/
 
   //copy chars to local buffer -- step down from 2 bytes to 1 if necessary...
-  nsAutoString2 theString(*this,eOneByte);
-  PRUint32  theRadix=10;
-  PRInt32   result=GetNumericSubstring(theString,theRadix);
+  PRInt32 result=0;
+  if(0<mLength) {
+    nsAutoString2 theString(*this,eOneByte);
+    PRUint32  theRadix=10;
+    *anErrorCode=GetNumericSubstring(theString,theRadix);
 
-  if(NS_OK==result){
-    result=_ToInteger(theString,anErrorCode,theRadix);
+    if(NS_OK==*anErrorCode){
+      result=_ToInteger(theString,anErrorCode,theRadix);
+    }
   }
+  else *anErrorCode=NS_ERROR_ILLEGAL_VALUE;
   return result;
 }
 
@@ -2175,8 +2179,13 @@ CStringTester::CStringTester() {
   //try a few numeric conversion routines...
   {
     nsString2 str1("10000",theSize);
+    nsString2 str2("hello");
+    nsString2 str3;
     PRInt32 err;
     PRInt32 theInt=str1.ToInteger(&err);
+    theInt=str2.ToInteger(&err);
+    theInt=str3.ToInteger(&err);
+
     str1="100.100";
     float theFloat=str1.ToFloat(&err);
   }