Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Frame processing needs to happen before bubbling system event group handlers in order to fix bug 300227 and thus properly fix bug 298894 r=jst sr=bz

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@179192 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
neil%parkwaycc.co.uk 2005-08-29 13:41:11 +00:00
parent 7602271f2b
commit 1e99a3c217
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
mozilla/layout/base/nsPresShell.cpp
View File

@ -6220,14 +6220,24 @@ PresShell::HandleEventInternal(nsEvent* aEvent, nsIView *aView,
} }
} }
// Continue with second dispatch to system event handlers.
// Stopping propagation in the default group does not affect // Stopping propagation in the default group does not affect
// propagation in the system event group. // propagation in the system event group.
// (see also section 1.2.2.6 of the DOM3 Events Working Draft) // (see also section 1.2.2.6 of the DOM3 Events Working Draft)
aEvent->flags &= ~NS_EVENT_FLAG_STOP_DISPATCH; aEvent->flags &= ~NS_EVENT_FLAG_STOP_DISPATCH;
// 3. Give event to the Frames for browser default processing.
// This is the nearest we can get to being an at target
// system event group handler. In particular we need to
// fire before bubbling system event group handlers.
if (GetCurrentEventFrame() && NS_SUCCEEDED (rv) &&
aEvent->eventStructType != NS_EVENT) {
rv = mCurrentEventFrame->HandleEvent(mPresContext, (nsGUIEvent*)aEvent,
aStatus);
}
// Continue with second dispatch to system event handlers.
// Need to null check mCurrentEventContent and mCurrentEventFrame // Need to null check mCurrentEventContent and mCurrentEventFrame
// since the previous dispatch could have nuked them. // since the previous dispatch could have nuked them.
if (mCurrentEventContent) { if (mCurrentEventContent) {
@ -6246,13 +6256,6 @@ PresShell::HandleEventInternal(nsEvent* aEvent, nsIView *aView,
} }
} }
// 3. Give event to the Frames for browser default processing.
if (GetCurrentEventFrame() && NS_SUCCEEDED (rv) &&
aEvent->eventStructType != NS_EVENT) {
rv = mCurrentEventFrame->HandleEvent(mPresContext, (nsGUIEvent*)aEvent,
aStatus);
}
// 4. Give event to event manager for post event state changes and // 4. Give event to event manager for post event state changes and
// generation of synthetic events. // generation of synthetic events.
if (NS_SUCCEEDED (rv) && if (NS_SUCCEEDED (rv) &&