From 21091d77bd8a3caeb451a37e32d5e43eee8b24ae Mon Sep 17 00:00:00 2001 From: "cbiesinger%web.de" Date: Fri, 4 Aug 2006 17:20:27 +0000 Subject: [PATCH] Bug 344196 make nsVariant::SetAsDOMString set mType correctly patch by Andrew Miller r=dougt sr=brendan git-svn-id: svn://10.0.0.236/trunk@206582 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/xpcom/ds/nsVariant.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mozilla/xpcom/ds/nsVariant.cpp b/mozilla/xpcom/ds/nsVariant.cpp index 3bb9d984311..38df847db89 100644 --- a/mozilla/xpcom/ds/nsVariant.cpp +++ b/mozilla/xpcom/ds/nsVariant.cpp @@ -2011,9 +2011,10 @@ NS_IMETHODIMP nsVariant::SetAsDOMString(const nsAString & aValue) { if(!mWritable) return NS_ERROR_OBJECT_IS_IMMUTABLE; - // A DOMString maps to an AString internally, so we can re-use - // SetFromAString here. - return nsVariant::SetFromAString(&mData, aValue); + DATA_SETTER_PROLOGUE((&mData)); + if(!(mData.u.mAStringValue = new nsString(aValue))) + return NS_ERROR_OUT_OF_MEMORY; + DATA_SETTER_EPILOGUE((&mData), VTYPE_DOMSTRING); } /* void setAsACString (in ACString aValue); */