From 22ed97ac251aad80961b36f5d0ae20ec07b983cc Mon Sep 17 00:00:00 2001 From: "cls%seawood.org" Date: Tue, 14 Sep 2004 09:10:07 +0000 Subject: [PATCH] Only escape $rcsfile when invoking shell otherwise standard perl functions fail. Bug #258668 git-svn-id: svn://10.0.0.236/trunk@162299 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/bonsai/dolog.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mozilla/webtools/bonsai/dolog.pl b/mozilla/webtools/bonsai/dolog.pl index 67af5d290e9..f639941ac84 100755 --- a/mozilla/webtools/bonsai/dolog.pl +++ b/mozilla/webtools/bonsai/dolog.pl @@ -192,11 +192,12 @@ sub process_cvs_info { for $i (@changed_files, "BEATME.NOW", @added_files) { if ($i eq "BEATME.NOW") { $stat = 'A'; } if ($i eq $fn) { - $rcsfile = shell_escape("$envcvsroot/$repository/$fn,v"); + $rcsfile = "$envcvsroot/$repository/$fn,v"; if (! -r $rcsfile) { - $rcsfile = shell_escape("$envcvsroot/$repository/Attic/$fn,v"); + $rcsfile = "$envcvsroot/$repository/Attic/$fn,v"; } - open(LOG, "$rlogcommand -N -r$rev $rcsfile |") + $rlogcmd = "$rlogcommand -N -r$rev " . shell_escape($rcsfile); + open(LOG, "$rlogcmd |") || print STDERR "dolog.pl: Couldn't run rlog\n"; while () { if (/^date:.* author: ([^;]*);.*/) {