Session history traversals from URI with anchor to same URI without anchor

should scroll.  Bug 280215, r=biesi, sr=darin


git-svn-id: svn://10.0.0.236/trunk@168532 18797224-902f-48f8-a5cc-f745e15eee43

mozilla/docshell/base/nsDocShell.cpp

@@ -6012,17 +6012,23 @@ nsDocShell::ScrollIfAnchor(nsIURI * aURI, PRBool * aWasAnchor,
     newSpec.EndReading(refEnd);
     
     PRInt32 hashNew = newSpec.FindChar(kHash);
-    if (hashNew <= 0) {
-        return NS_OK;           // Strange URI or no new anchor
+    if (hashNew == 0) {
+        return NS_OK;           // Strange URI
     }
 
-    // found it
-    urlEnd = urlStart;
-    urlEnd.advance(hashNew);
+    if (hashNew > 0) {
+        // found it
+        urlEnd = urlStart;
+        urlEnd.advance(hashNew);
         
-    refStart = urlEnd;
-    ++refStart;             // advanced past '#'
+        refStart = urlEnd;
+        ++refStart;             // advanced past '#'
         
+    }
+    else {
+        // no hash at all
+        urlEnd = refStart = refEnd;
+    }
     const nsACString& sNewLeft = Substring(urlStart, urlEnd);
     const nsACString& sNewRef =  Substring(refStart, refEnd);
                                           
@@ -6043,6 +6049,17 @@ nsDocShell::ScrollIfAnchor(nsIURI * aURI, PRBool * aWasAnchor,
         currentSpec.EndReading(currentLeftEnd);
     }
 
+    // If we have no new anchor, we do not want to scroll, unless there is a
+    // current anchor and we are doing a history load.  So return if we have no
+    // new anchor, and there is no current anchor or the load is not a history
+    // load.
+    NS_ASSERTION(hashNew != 0 && hashCurrent != 0,
+                 "What happened to the early returns above?");
+    if (hashNew == kNotFound &&
+        (hashCurrent == kNotFound || aLoadType != LOAD_HISTORY)) {
+        return NS_OK;
+    }
+
     // Compare the URIs.
     //
     // NOTE: this is a case sensitive comparison because some parts of the