Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leaks. Make JavaXPCOMInstance hold ref to XPCOM object.

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@164510 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
pedemont%us.ibm.com
2004-10-27 17:10:03 +00:00
parent 0b329a63b0
commit 23bd99e9d9
5 changed files with 39 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
mozilla/extensions/java/xpcom/nsJavaWrapper.cpp
View File

@@ -649,7 +649,10 @@ FinalizeParams(JNIEnv *env, const jobject aParam,
if (NS_FAILED(rv))
return rv;
inst = CreateJavaXPCOMInstance((nsISupports*) aVariant.val.p, &iid);
nsISupports* variant =
NS_REINTERPRET_CAST(nsISupports*, aVariant.val.p);
inst = CreateJavaXPCOMInstance(variant, &iid);
NS_RELEASE(variant); // JavaXPCOMInstance has owning ref
if (inst) {
// create java stub
@@ -816,7 +819,10 @@ SetRetval(JNIEnv *env, const nsXPTParamInfo &aParamInfo,
if (NS_FAILED(rv))
return rv;
inst = CreateJavaXPCOMInstance((nsISupports*) aVariant.val.p, &iid);
nsISupports* variant =
NS_REINTERPRET_CAST(nsISupports*, aVariant.val.p);
inst = CreateJavaXPCOMInstance(variant, &iid);
NS_RELEASE(variant); // JavaXPCOMInstance has owning ref
if (inst) {
// create java stub