Fixed bug #1159. Reference counting bug related to forms...

git-svn-id: svn://10.0.0.236/trunk@13244 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
rpotts%netscape.com
1998-10-21 09:26:33 +00:00
parent 5cb570fb1f
commit 2ddf7cd9af
2 changed files with 28 additions and 14 deletions

View File

@@ -2199,17 +2199,23 @@ nsHTMLDocument::AddForm(nsIDOMHTMLFormElement *aForm)
if (nsnull == aForm) {
return NS_ERROR_NULL_POINTER;
}
if (!mForms) {
nsIDOMHTMLCollection* forms = nsnull;
GetForms(&forms);
}
nsIContent* iContent = nsnull;
nsresult result = aForm->QueryInterface(kIContentIID, (void**)&iContent);
if ((NS_OK == result) && iContent) {
if (mForms->Add(iContent)) {
NS_RELEASE(iContent);
return NS_OK;
nsIDOMHTMLCollection* forms = nsnull;
// Initialize mForms if necessary...
if (nsnull == mForms) {
nsIDOMHTMLCollection* forms = nsnull;
result = GetForms(&forms);
NS_IF_RELEASE(forms);
}
if (NS_SUCCEEDED(result)) {
mForms->Add(iContent);
}
NS_RELEASE(iContent);
}
return result;
}
@@ -2223,6 +2229,7 @@ nsHTMLDocument::GetForms(nsIDOMHTMLCollection** aForms)
if (nsnull == mForms) {
return NS_ERROR_OUT_OF_MEMORY;
}
NS_ADDREF(mForms);
}
*aForms = (nsIDOMHTMLCollection *)mForms;