Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 924802: (CVE-2013-1742) [SECURITY] (XSS) "id" and "sortkey" are not sanitized when editing flag types if categoryAction-foo is set

Browse Source 
r=dkl a=glob


git-svn-id: svn://10.0.0.236/trunk@265061 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzrmirror%bugzilla.org
2013-10-16 17:33:13 +00:00
parent 7e6c565c4c
commit 3194b05f37
3 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@@ -1 +1 @@
8778
8779

6
mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl
View File

@@ -36,7 +36,7 @@
<form id="flagtype_properties" method="post" action="editflagtypes.cgi">
<input type="hidden" name="action" value="[% action FILTER html %]">
<input type="hidden" name="can_fully_edit" value="[% can_fully_edit FILTER html %]">
<input type="hidden" name="id" value="[% type.id %]">
<input type="hidden" name="id" value="[% type.id FILTER html %]">
<input type="hidden" name="token" value="[% token FILTER html %]">
<input type="hidden" name="target_type" value="[% type.target_type FILTER html %]">
<input type="hidden" name="check_clusions" value="[% check_clusions FILTER none %]">
@@ -133,8 +133,8 @@
this type will be sorted when displayed to users in a list; ignore if you
don't care what order the types appear in or if you want them to appear
in alphabetical order.<br>
<input type="text" name="sortkey" value="[% type.sortkey || 0 %]" size="5" maxlength="5"
[%- ' disabled="disabled"' UNLESS can_fully_edit %]>
<input type="text" name="sortkey" value="[% type.sortkey || 0 FILTER html %]" size="5"
maxlength="5" [% ' disabled="disabled"' UNLESS can_fully_edit %]>
</td>
</tr>

2
mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl
View File

@@ -386,8 +386,6 @@
],
'admin/flag-type/edit.html.tmpl' => [
'type.id',
'type.sortkey || 0',
'selname',
],