Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Workaround gcc -O2 compiler optimization problem by moving the declaration of a nsCOMPtr outside of a while loop.

Browse Source 
Bug #80988 r=braddr sr=scc a=asa


git-svn-id: svn://10.0.0.236/trunk@97284 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
cls%seawood.org 2001-06-16 23:35:43 +00:00
parent 176266cd1f
commit 426c54fa15
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mozilla/layout/xul/base/src/nsMenuFrame.cpp
View File

@ -1198,6 +1198,13 @@ nsMenuFrame::UpdateMenuSpecialState(nsIPresContext* aPresContext) {
if ( NS_FAILED(rv) || !sib )
return;
// XXX - egcs 1.1.2 & gcc 2.95.x -Oy builds, where y > 1,
// are known to break if we declare nsCOMPtrs inside this loop.
// Moving the declaration out of the loop works around this problem.
// http://bugzilla.mozilla.org/show_bug.cgi?id=80988
nsCOMPtr<nsIContent> content;
do {
if (NS_FAILED(sib->QueryInterface(NS_GET_IID(nsIMenuFrame),
(void **)&sibMenu)))
@ -1208,7 +1215,6 @@ nsMenuFrame::UpdateMenuSpecialState(nsIPresContext* aPresContext) {
(sibMenu->MenuIsChecked(sibChecked), sibChecked) &&
(sibMenu->GetRadioGroupName(sibGroup), sibGroup == mGroupName)) {
nsCOMPtr<nsIContent> content;
if (NS_FAILED(sib->GetContent(getter_AddRefs(content))))
continue; // break?