From 44df1f1fa9af9f0e5958dcee9c8f46073e91ac50 Mon Sep 17 00:00:00 2001 From: "sspitzer%netscape.com" Date: Tue, 19 Feb 2002 21:24:31 +0000 Subject: [PATCH] fix for #121868. crashers problems when we fail to generate collation keys. this happens to us on OS X, it seems. patch by nhotta. r/sr=sspitzer git-svn-id: svn://10.0.0.236/trunk@114950 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/mailnews/addrbook/src/nsAbView.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mozilla/mailnews/addrbook/src/nsAbView.cpp b/mozilla/mailnews/addrbook/src/nsAbView.cpp index 7c95684e344..9ebd05c0a36 100644 --- a/mozilla/mailnews/addrbook/src/nsAbView.cpp +++ b/mozilla/mailnews/addrbook/src/nsAbView.cpp @@ -757,11 +757,7 @@ nsresult nsAbView::CreateCollationKey(const PRUnichar *aSource, PRUint8 **aKey, return NS_ERROR_OUT_OF_MEMORY; rv = mCollationKeyGenerator->CreateRawSortKey(kCollationCaseInSensitive, sourceString, *aKey, aKeyLen); - if (NS_FAILED(rv)) - { - nsMemory::Free(*aKey); - return rv; - } + NS_ASSERTION(NS_SUCCEEDED(rv), "failed to generate a raw sort key, see bug #121868"); return NS_OK; }