From 44e5f0d4e8ad28ac9f104c62a0a32bf42cc28cfd Mon Sep 17 00:00:00 2001
From: "zach%zachlipton.com"
 <zach%zachlipton.com@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Mon, 30 Jul 2007 18:11:50 +0000
Subject: [PATCH] Bugs 390164 and 390166: fix steps and expectedResults spacing
 and the syntax error in the "select tests" dialog. p=ben_h, r=zach.

git-svn-id: svn://10.0.0.236/trunk@231182 18797224-902f-48f8-a5cc-f745e15eee43
---
 .../extensions/community/chrome/content/tabs/litmus.xul   | 8 ++++----
 .../community/chrome/content/tabs/selecttests.js          | 3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/mozilla/testing/extensions/community/chrome/content/tabs/litmus.xul b/mozilla/testing/extensions/community/chrome/content/tabs/litmus.xul
index 36e35bf6cdb..cd684eb9c0a 100644
--- a/mozilla/testing/extensions/community/chrome/content/tabs/litmus.xul
+++ b/mozilla/testing/extensions/community/chrome/content/tabs/litmus.xul
@@ -40,16 +40,16 @@
 	 </hbox>
 	
 	<vbox width="370px" minwidth="370px">
-		<groupbox height="160px" minwidth="370px" width="370px">
+		<groupbox maxheight="130px" minwidth="370px" width="370px">
 			<caption label="&qa.testcase.steps;" crop="end" maxwidth="200"/>
-			<div xmlns="http://www.w3.org/1999/xhtml" style="width: 350px; height: 160px; overflow: auto;" id="qa-testcase-steps" class="list"/>
+			<div xmlns="http://www.w3.org/1999/xhtml" style="width: 350px; height: 140px; overflow: auto;" id="qa-testcase-steps" class="list"/>
 		</groupbox>
 		<splitter id="qa-mainwindow-splitter" state="open" collapse="none">
 			<grippy/>
 		</splitter>
-		<groupbox height="130px" minwidth="370px" width="370px">
+		<groupbox maxheight="120px" minwidth="370px" width="370px">
 			<caption label="&qa.testcase.expected;" />
-			<div xmlns="http://www.w3.org/1999/xhtml" style="width: 350px; height: 130px; overflow: auto;" id="qa-testcase-expected" class="list"/>
+			<div xmlns="http://www.w3.org/1999/xhtml" style="width: 350px; height: 120px; overflow: auto;" id="qa-testcase-expected" class="list"/>
 		</groupbox>
 	</vbox>
 	
diff --git a/mozilla/testing/extensions/community/chrome/content/tabs/selecttests.js b/mozilla/testing/extensions/community/chrome/content/tabs/selecttests.js
index 1b62c87addb..74b3df3a7f8 100644
--- a/mozilla/testing/extensions/community/chrome/content/tabs/selecttests.js
+++ b/mozilla/testing/extensions/community/chrome/content/tabs/selecttests.js
@@ -10,12 +10,13 @@
 			if (window.arguments.length > 0) {
 				updateFunction = window.arguments[0];   // parent window passes in a function to update itself with data
                 handleCancel = window.arguments[1];     // parent window passes in a function to restore state if dialog canceled
-            }
+            } 
 			litmus.getTestruns(populateTestRuns);
 		}
 
         function handleRunSelect() {
             var id = document.getElementById("qa-st-testrun").selectedItem.getAttribute("value");
+            if (id == "") return;  // oddly, this check doesn't seem necessary in the other handlers...
             litmus.getTestrun(id, populateTestGroups);
         }