Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 413424 - PNG encoder leaks a string. r=stuart, a1.9=schrep, guilty=dolske

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@243765 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
dolske%mozilla.com 2008-01-22 23:15:23 +00:00
parent b63f2be759
commit 4ab8753b51
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mozilla/modules/libpr0n/encoders/png/nsPNGEncoder.cpp
View File

@ -336,10 +336,12 @@ nsPNGEncoder::ParseOptions(const nsAString& aOptions,
PRUint32* offsetX,
PRUint32* offsetY)
{
char* token;
char* options = nsCRT::strdup(PromiseFlatCString(NS_ConvertUTF16toUTF8(aOptions)).get());
// Make a copy of aOptions, because strtok() will modify it.
nsCAutoString optionsCopy;
optionsCopy.Assign(NS_ConvertUTF16toUTF8(aOptions));
char* options = optionsCopy.BeginWriting();
while ((token = nsCRT::strtok(options, ";", &options))) {
while (char* token = nsCRT::strtok(options, ";", &options)) {
// If there's an '=' character, split the token around it.
char* equals = token, *value = nsnull;
while(*equals != '=' && *equals) { ++equals; }