Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for bug 492385 . Stop crash freeing named CRL entry on shudown. r=nelson

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@257183 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
julien.pierre.boogz%sun.com 2009-05-13 22:47:28 +00:00
parent 0f0829b37e
commit 503a10244f
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mozilla/security/nss/lib/certdb/crl.c
View File

@ -37,7 +37,7 @@
/*
* Moved from secpkcs7.c
*
* $Id: crl.c,v 1.66 2009-04-21 22:53:58 julien.pierre.boogz%sun.com Exp $
* $Id: crl.c,v 1.67 2009-05-13 22:47:28 julien.pierre.boogz%sun.com Exp $
*/
#include "cert.h"
@ -3136,6 +3136,7 @@ static SECStatus addCRLToCache(CERTCertDBHandle* dbhandle, SECItem* crl,
rv = SECFailure;
/* no need to keep unused CRL around */
SECITEM_ZfreeItem(entry->crl, PR_TRUE);
entry->crl = NULL;
}
return rv;
}
@ -3206,6 +3207,10 @@ SECStatus cert_CacheCRLByGeneralName(CERTCertDBHandle* dbhandle, SECItem* crl,
if (!removed)
{
rv = SECFailure;
/* leak old entry since we couldn't remove it from the hash table */
}
else
{
rv2 = NamedCRLCacheEntry_Destroy(oldEntry);
PORT_Assert(SECSuccess == rv2);
}
@ -3249,7 +3254,11 @@ SECStatus cert_CacheCRLByGeneralName(CERTCertDBHandle* dbhandle, SECItem* crl,
PORT_Assert(removed);
if (!removed)
{
/* leak old entry since we couldn't remove it from the hash table */
rv = SECFailure;
}
else
{
rv2 = NamedCRLCacheEntry_Destroy(oldEntry);
PORT_Assert(SECSuccess == rv2);
}