Bug 317021 - improve description of bz_canusewhine* parameters. r=gerv.

git-svn-id: svn://10.0.0.236/trunk@265690 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzrmirror%bugzilla.org 2014-11-25 10:46:39 +00:00
parent 87fbd3d0ca
commit 5154d0fab9
3 changed files with 12 additions and 6 deletions

View File

@ -1 +1 @@
9223
9224

View File

@ -1 +1 @@
977de764485c48c16c4b34e73ab2f1d08506b0a7
649a38910889a9945e2ef22f5d6ff4d32fceeba6

View File

@ -135,11 +135,13 @@ use constant SYSTEM_GROUPS => (
},
{
name => 'bz_canusewhineatothers',
description => 'Can configure whine reports for other users',
description => 'Can configure queries and schedules for periodic'
. ' reports to be run and sent via email to other users and groups',
},
{
name => 'bz_canusewhines',
description => 'User can configure whine reports for self',
description => 'Can configure queries and schedules for periodic'
. ' reports to be run and sent via email to themselves',
# inherited_by means that users in the groups listed below are
# automatically members of bz_canusewhines.
inherited_by => ['editbugs', 'bz_canusewhineatothers'],
@ -217,8 +219,8 @@ sub update_system_groups {
# Create most of the system groups
foreach my $definition (SYSTEM_GROUPS) {
my $exists = new Bugzilla::Group({ name => $definition->{name} });
if (!$exists) {
my $group = new Bugzilla::Group({ name => $definition->{name} });
if (!$group) {
$definition->{isbuggroup} = 0;
$definition->{silently} = !$editbugs_exists;
my $inherited_by = delete $definition->{inherited_by};
@ -234,6 +236,10 @@ sub update_system_groups {
}
}
}
elsif ($group->description ne $definition->{description}) {
$group->set_description($definition->{description});
$group->update();
}
}
$dbh->bz_commit_transaction();