From 56b4287d556da143a62d28e4683aa711f4013676 Mon Sep 17 00:00:00 2001 From: "mbarnson%sisna.com" Date: Tue, 5 Nov 2002 03:11:25 +0000 Subject: [PATCH] Removed binmode references on Win32 documentation. See bug 155743. git-svn-id: svn://10.0.0.236/trunk@132990 18797224-902f-48f8-a5cc-f745e15eee43 --- .../bugzilla/docs/sgml/installation.sgml | 52 ------------------- .../bugzilla/docs/xml/installation.xml | 52 ------------------- 2 files changed, 104 deletions(-) diff --git a/mozilla/webtools/bugzilla/docs/sgml/installation.sgml b/mozilla/webtools/bugzilla/docs/sgml/installation.sgml index 0af9c4bf6ee..07ab699b47a 100644 --- a/mozilla/webtools/bugzilla/docs/sgml/installation.sgml +++ b/mozilla/webtools/bugzilla/docs/sgml/installation.sgml @@ -1898,58 +1898,6 @@ system ("C:\\perl\\bin\\perl", "processmail", @ARGLIST); - - Add - binmode() - - calls so attachments will work ( - bug - 62000 - - ). - - Because Microsoft Windows based systems handle binary files - different than Unix based systems, you need to add the following - lines to - createattachment.cgi - - and - showattachment.cgi - - before the - require 'CGI.pl'; - - line. - - - - - - - - - According to - - bug 62000 - - , the perl documentation says that you should always use - binmode() - - when dealing with binary files, but never when dealing with text - files. That seems to suggest that rather than arbitrarily putting - - binmode() - - at the beginning of the attachment files, there should be logic - to determine if - binmode() - - is needed or not. - - diff --git a/mozilla/webtools/bugzilla/docs/xml/installation.xml b/mozilla/webtools/bugzilla/docs/xml/installation.xml index 0af9c4bf6ee..07ab699b47a 100644 --- a/mozilla/webtools/bugzilla/docs/xml/installation.xml +++ b/mozilla/webtools/bugzilla/docs/xml/installation.xml @@ -1898,58 +1898,6 @@ system ("C:\\perl\\bin\\perl", "processmail", @ARGLIST); - - Add - binmode() - - calls so attachments will work ( - bug - 62000 - - ). - - Because Microsoft Windows based systems handle binary files - different than Unix based systems, you need to add the following - lines to - createattachment.cgi - - and - showattachment.cgi - - before the - require 'CGI.pl'; - - line. - - - - - - - - - According to - - bug 62000 - - , the perl documentation says that you should always use - binmode() - - when dealing with binary files, but never when dealing with text - files. That seems to suggest that rather than arbitrarily putting - - binmode() - - at the beginning of the attachment files, there should be logic - to determine if - binmode() - - is needed or not. - -