diff --git a/mozilla/webtools/tinderbox2/ChangeLog b/mozilla/webtools/tinderbox2/ChangeLog index 97666145080..0300b51ee52 100644 --- a/mozilla/webtools/tinderbox2/ChangeLog +++ b/mozilla/webtools/tinderbox2/ChangeLog @@ -9,12 +9,12 @@ Add support for historical Tinderbox images Mozilla layout preferences are now standard (non uniform row spacing, - truely empty cells, + truly empty cells, legend on bottom of page). Allow users to backdate notices -autmate regeneration of HTML when user uses CGI +automate regeneration of HTML when user uses CGI interface Put the C in all build cells. @@ -22,7 +22,7 @@ Put the C in all build cells. VC code did the wrong thing when generating old pages and there was no TreeState data. -Fix Spelling mistakes thoughout code. +Fix Spelling mistakes throughout code. Add support for build machines to tell the server to add text/links into build cells (TinderboxPrint). @@ -70,7 +70,7 @@ this an important feature. Allow Tinderbox to run via suid wrappers. This is needed for some times of mail delivery systems -No longer exclude 'priveledged id's from running Tinderbox. +No longer exclude 'priviledged id's from running Tinderbox. Now we require tinderbox to run as the id which the user specifies is the tinderbox id. @@ -84,9 +84,9 @@ Begin work to allow tinderbox admin pages to open and close bonsai trees fix code which allowed tinderbox to determine the state of bonsai trees -Major bug in theh untainting code, fixed. This was a security +Major bug in the untainting code, fixed. This was a security problem. I suspect people may have trouble with the fix but this was -how the code was inteneded to work. I do not understand how this got +how the code was intended to work. I do not understand how this got through my unit tests. Give a useful example of how use the new build script. @@ -120,7 +120,7 @@ Release 0.8 This release moved some files into new directories update with cvs update -d -P -Remove the strict time checking on mail, itcahsed too many problems. +Remove the strict time checking on mail, it caused too many problems. Fix the Unmonitored Builds in admintree.cgi and in status.html page. @@ -129,7 +129,7 @@ Storable.pm has been tested as a Persistence implementation. Improve the prediction of when builds will end by introducing the notion of 'deadtime'. -Separate out the BuildStaus table for easier configuration of the +Separate out the BuildStatus table for easier configuration of the status without changing the build display library. Better comments in the ReadMe files diff --git a/mozilla/webtools/tinderbox2/Goals b/mozilla/webtools/tinderbox2/Goals index 1d0a0393809..ae80a72b986 100644 --- a/mozilla/webtools/tinderbox2/Goals +++ b/mozilla/webtools/tinderbox2/Goals @@ -8,7 +8,7 @@ special needs. project and need a GUI to help change various types of project information (treestate, message of the day, etc). They will also need summary pages which will show them the current status of all the -projects which they are working on. They may occassionally "drill +projects which they are working on. They may occasionally "drill down" into the detailed status page but this will not be their primary view of the tinderbox system. @@ -18,7 +18,7 @@ build systems (bugzilla, cvs, bonsai, etc). A GUI would not be helpful as local customizations may require small changes to the code. Configurations need to be kept (mostly) in files which are separate from the Tinderbox source code so that they can be version controled -and will not get stepped on when tinderbox is upgradded. +and will not get stepped on when tinderbox is upgraded. 3) Developers: need to view the "state of development" and add notices to the notice board. @@ -27,7 +27,7 @@ Improvements needed from Tinderbox1 ----------------------------------- highly configurable design with multiple Version Control systems -possible (bonsai, raw cvs, perforce, continuious, clearcase) and +possible (bonsai, raw cvs, perforce, continuous, clearcase) and multiple modes of running possible (with no version control system with no builds display). @@ -53,7 +53,7 @@ all programmable configuration parameters should be stored easy change and configure for novice users. make better use of the perl data structures to mirror the way we wish -to use the data. This will allow easier maintainabilty and allow for +to use the data. This will allow easier maintainability and allow for more expansion of features. display should work on many different browsers. @@ -61,7 +61,7 @@ display should work on many different browsers. popup windows should not be netscape specific. Permanent data should be stored via datadumper so that the data and -datastrucutres are easy to read and debug. Currently this is a +data strucutres are easy to read and debug. Currently this is a performance bottle neck with a large percentage of our cpu time during testing being spent in Data::Dumper::Dump. The perl module Storable is much faster. I wish to not add additional module requirements at @@ -76,7 +76,7 @@ this time, this will be configurable. # (out of 19.03 User/102.15 Elapsed Seconds) # was spend in 32878 calls to Data::Dumper::_dump() -# System Time was negligable at 2.49 Seconds +# System Time was negligible at 2.49 Seconds All errors should be trapped and sent to log files. Strange program states should be explicitly checked for. @@ -86,7 +86,7 @@ to race conditions. All column modules (processmail, build, VC, Notices) should be able to be run individually. Modules should accept well defined text files as -input and produce text files as output. This will greatly inhance the +input and produce text files as output. This will greatly enhance the ability to test each module in isolation and to quickly port modules to new architectures. diff --git a/mozilla/webtools/tinderbox2/Install b/mozilla/webtools/tinderbox2/Install index 79cc2235cac..79a294f6ef8 100644 --- a/mozilla/webtools/tinderbox2/Install +++ b/mozilla/webtools/tinderbox2/Install @@ -25,10 +25,19 @@ To install: It would be a good idea to have these modules installed: Storable, Date::Format, +You can easily check if these are installed by executing these two +commands. + +If the module is installed, you'll get no output: + perl -e 'use Storable' + perl -e 'use Date::Format' + + + *) Read the Policies and Overview documents found in this directory to help you get a feel for the scope of this installation. -*) The process id which receives and process the mail must be the the +*) The process id which receives and process the mail must be the same id which runs the tinderbox cron job to prepare the web pages. I prefer to manage my webserver so that all CGI scripts do not run as the same user. Using one user id can cause security problems which @@ -39,10 +48,10 @@ unix system users (daemon, nobody, bin) since this could cause security interactions with other programs which use these ids. It may take some thought as to how the user id will be configured to -run when recieving mail and when recieving web requests and not be a +run when receiving mail and when receiving web requests and not be a user id which will cause security problems. -These products will help partion your web application to run as +These products will help partition your web application to run as different users. (See http://www.w3.org/Security/Faq/wwwsf4.html for more info) @@ -99,7 +108,7 @@ scripts we must substitute some values into the source code to make it executable. You may wish to change the default directories in configure for some of the makefile variables. Please read config.out and make any changes which need to be made for your system. Configure -also excepts command line options to change some default variables. +also accepts command line options to change some default variables. Please look at the configure source code for variable details, but the most common changes are: @@ -143,7 +152,7 @@ can copy the *.cgi files to another directory if this is not the case. *) There are some gifs located in the gif directory which have historically been used by tinderbox. The installation via 'make install' does not install these images. Put them somewhere in your -webservers html directory if you wish to use them. Samples of their +webserver's html directory if you wish to use them. Samples of their use are in the configuration files. *) set up a cron job to run $cgi-bin/bin/tinder.cgi --daemon-mode @@ -159,10 +168,10 @@ incoming tinderbox mail. The process id which receives and process the mail must be the the same id which runs the tinderbox cron job to prepare the web pages. Usually this set up is accomplished by having the MTA (Sendmail) pass mail for particular accounts into a script. -This can be configued via a global configuration file (Sendmail alias +This can be configured via a global configuration file (Sendmail alias file) or via a .forward file (each account gets the same user id but a different home directory, each home directory gets a .forward to cause -incomming mail to be delivered through the correct tinderbox mail +incoming mail to be delivered through the correct tinderbox mail processing program). I have used the following configurations for the mail server Postfix. @@ -209,7 +218,7 @@ hostname/modules exactly as you wrote it in VCData. Then copy your ~/.cvspass into the tinderbox server user id's home directory. This must be the REAL home of the Tinderbox daemon, as listed in /etc/passwd/ and set in the $HOME environmental variable for -tinder.cgi. The file must not be world readble or writeable or +tinder.cgi. The file must not be world readable or writable or executable. @@ -234,7 +243,7 @@ mailing to changes in ticket state not updates (edit) of a ticket. *) Check that the time on your webserver, your version control machine, your bug tracking machine and your build machines are all in sync. Check that mail if build mail bounces on any of the above -machines that it will be recieved by someone who can act on it. +machines that it will be received by someone who can act on it. diff --git a/mozilla/webtools/tinderbox2/Overview b/mozilla/webtools/tinderbox2/Overview index 95ab06765b1..dd7fe9ccab6 100644 --- a/mozilla/webtools/tinderbox2/Overview +++ b/mozilla/webtools/tinderbox2/Overview @@ -37,12 +37,16 @@ and you can separately version the local configurations which you make. It is also easy to see the local configurations since you have both the original and the modified code on the same server and can difference the two. As an example you might need to change the -BuildStatus I assume that you have the following possible build +BuildStatus - I assume that you have the following possible build outcomes (Build in progress, Build failed, Build succeded but tests failed, Build and all tests were successful) You may have additional outcomes to specifiy which kind of tests failed (unit test failed, not -enough unit test coverage, performance tests failed). Similarly you may have unusual requirements for how the filesystem should be laied out. I provide a - I suggest that you read through the files to see +enough unit test coverage, performance tests failed). Similarly you +may have unusual requirements for how the filesystem should be laied +out. I provide a outcomes to specify which kind of tests failed (unit +test failed, not enough unit test coverage, performance tests failed). +Similarly you may have unusual requirements for how the filesystem +should be laid out. I suggest that you read through the files to see how they are laid out and what types of changes are possible. diff --git a/mozilla/webtools/tinderbox2/Policies b/mozilla/webtools/tinderbox2/Policies index ae5c5f3cf9a..6e8c702a6e5 100644 --- a/mozilla/webtools/tinderbox2/Policies +++ b/mozilla/webtools/tinderbox2/Policies @@ -6,7 +6,7 @@ policies you will need to set: To install tinderbox you will need some information about your existing computer systems and some idea about what your goals are. Here is a list of questions to help get you started, some of these -ideas may not be apropriate for your environment. +ideas may not be appropriate for your environment. The webserver will serve the tinderbox pages. @@ -40,8 +40,8 @@ The same user id must be used for running the scripts as for tinderbox mail delivery. The Tinderbox Configuration files will define this user id and as a security precaution check that it is running as the required id. It is suggested that this id not be a privileged id -(higher ids are better, please make this number be grater then 10 and -bigger then 100 is recommended). Smaller ids are often assumed to +(higher ids are better, please make this number be greater than 10 and +bigger than 100 is recommended). Smaller ids are often assumed to have more privileges on a Unix box then larger ids. It is not a good idea for an unauthenticated user to have any privileges so a large id is recommended. It is also recommended that you not use the id 'nobody' diff --git a/mozilla/webtools/tinderbox2/Todo b/mozilla/webtools/tinderbox2/Todo index 5cc777171f1..b1bdd989b85 100644 --- a/mozilla/webtools/tinderbox2/Todo +++ b/mozilla/webtools/tinderbox2/Todo @@ -13,7 +13,7 @@ javascript programs in tinderbox2/src/lib/HTMLPopUp/MozillaLayers.pm. Please keep the code neat and nicely indented. I need to allow the VC system to have a daemon gather the VC -information and pass it to tinderbox via the same update methods wich +information and pass it to tinderbox via the same update methods which Builds uses. Then both the tinder.cgi and this new cvs process could be run out of cron periodically and the webpages would not be delayed if CVS takes a long time to respond this might improve the response @@ -23,5 +23,5 @@ which was IO bound and one which was CPU bound. It would be really nice if CVS could mail tinderbox the updates which apply to the branches of interest, then tinderbox would not have to -pool and it would get the branch information which it needs. +poll and it would get the branch information which it needs. diff --git a/mozilla/webtools/tinderbox2/src/bin/addnote.cgi b/mozilla/webtools/tinderbox2/src/bin/addnote.cgi index 7493ba360fe..ff965c78271 100644 --- a/mozilla/webtools/tinderbox2/src/bin/addnote.cgi +++ b/mozilla/webtools/tinderbox2/src/bin/addnote.cgi @@ -2,12 +2,12 @@ # -*- Mode: perl; indent-tabs-mode: nil -*- # -# addnote.cgi - the webform which users enter notices to be displayed +# addnote.cgi - the webform via which users enter notices to be # on the tinderbox status page. -# $Revision: 1.21 $ -# $Date: 2003-06-18 16:11:00 $ +# $Revision: 1.22 $ +# $Date: 2003-08-04 17:14:56 $ # $Author: kestes%walrus.com $ # $Source: /home/befator/cvs/jail/cvsroot/mozilla/webtools/tinderbox2/src/bin/addnote.cgi,v $ # $Name: not supported by cvs2svn $ diff --git a/mozilla/webtools/tinderbox2/src/bin/admintree.cgi b/mozilla/webtools/tinderbox2/src/bin/admintree.cgi index c9fd7e52cb0..cc03a5ea954 100755 --- a/mozilla/webtools/tinderbox2/src/bin/admintree.cgi +++ b/mozilla/webtools/tinderbox2/src/bin/admintree.cgi @@ -7,8 +7,8 @@ # columns from being shown on the default pages. -# $Revision: 1.23 $ -# $Date: 2002-05-03 03:29:14 $ +# $Revision: 1.24 $ +# $Date: 2003-08-04 17:14:57 $ # $Author: kestes%walrus.com $ # $Source: /home/befator/cvs/jail/cvsroot/mozilla/webtools/tinderbox2/src/bin/admintree.cgi,v $ # $Name: not supported by cvs2svn $ @@ -65,11 +65,11 @@ use HTMLPopUp; # unexpectedly. Scripting tags that can be embedded in this way # include