Fix (hopefully for good this time) bug 298201, a crash when running on Tiger because NSQuickDrawView has stashed a bad port. r=pinkerton. Only affects camino.

git-svn-id: svn://10.0.0.236/trunk@175710 18797224-902f-48f8-a5cc-f745e15eee43

mozilla/widget/src/cocoa/nsChildView.mm

@@ -2123,10 +2123,6 @@ nsChildView::Idle()
 //
 - (id)initWithFrame:(NSRect)inFrame geckoChild:(nsChildView*)inChild eventSink:(nsIEventSink*)inSink
 {
-  // Set the current GrafPort to a "safe" port before initting the NSQuickDrawView,
-  // so that the NSQuickDrawView stashes a pointer to this known-good port internally.
-  // It will set the port back to this port on destruction.
-  SetPort(NULL);
   if ((self = [super initWithFrame:inFrame]))
   {
     mGeckoChild = inChild;
@@ -2154,8 +2150,10 @@ nsChildView::Idle()
 
 - (void)dealloc
 {
+  NS_ASSERTION(!_savePort || IsValidPort(_savePort), "Bad port");
+
   [super dealloc];    // This sets the current port to _savePort (which should be
-                      // the known-good port).
+                      // a valid port, checked with the assertion above.
   SetPort(NULL);      // Bullet-proof against future changes in NSQDView
 }
 
@@ -2396,6 +2394,8 @@ nsChildView::Idle()
     mGeckoChild->RemovedFromWindow();
   if (mMouseEnterExitTag)
     [self removeTrackingRect:mMouseEnterExitTag];
+
+  [super viewWillMoveToWindow:newWindow];
 }
 
 - (void)viewDidMoveToWindow
@@ -2406,18 +2406,24 @@ nsChildView::Idle()
   mMouseEnterExitTag = [self addTrackingRect:[self bounds] owner:self
                                     userData:nil assumeInside: [[self window]
                                     acceptsMouseMovedEvents]];
+
+  [super viewDidMoveToWindow];
 }
 
 - (void)viewWillStartLiveResize
 {
   if (mGeckoChild && mIsPluginView)
     mGeckoChild->LiveResizeStarted();
+  
+  [super viewWillStartLiveResize];
 }
 
 - (void)viewDidEndLiveResize
 {
   if (mGeckoChild && mIsPluginView)
     mGeckoChild->LiveResizeEnded();
+
+  [super viewDidEndLiveResize];
 }
 
 - (BOOL)mouseDownCanMoveWindow
@@ -2425,6 +2431,15 @@ nsChildView::Idle()
   return NO;
 }
 
+- (void)lockFocus
+{
+  // Set the current GrafPort to a "safe" port before calling [NSQuickDrawView lockFocus],
+  // so that the NSQuickDrawView stashes a pointer to this known-good port internally.
+  // It will set the port back to this port on destruction.
+  SetPort(NULL);
+  [super lockFocus];
+}
+
 //
 // -drawRect:
 //