From 59fcb856a29d85358e2cee6fbbee356e87962ee9 Mon Sep 17 00:00:00 2001
From: "ian%hixie.ch" <ian%hixie.ch@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Tue, 4 Dec 2001 18:06:06 +0000
Subject: [PATCH] Removing a bunch of dump(10, ...) calls. It turns out that
 dump() is actually quite expensive, and calling it 1000+ times just to do
 nothing isn't that useful. In addition, most of these dump()s were used to
 debug the core PLIF code which now works pretty well, so they aren't that
 useful any more.

git-svn-id: svn://10.0.0.236/trunk@109639 18797224-902f-48f8-a5cc-f745e15eee43
---
 mozilla/webtools/PLIF/PLIF.pm            | 11 -----------
 mozilla/webtools/PLIF/PLIF/Controller.pm |  4 ----
 2 files changed, 15 deletions(-)

diff --git a/mozilla/webtools/PLIF/PLIF.pm b/mozilla/webtools/PLIF/PLIF.pm
index 71e155d3a86..03576a6a1f4 100644
--- a/mozilla/webtools/PLIF/PLIF.pm
+++ b/mozilla/webtools/PLIF/PLIF.pm
@@ -66,10 +66,8 @@ my $LOCKED = 0; # set to '1' while we are calling the error reporting code
 sub create {
     my $class = shift;
     if (ref($class)) {
-        $class->dump(10, "Tried to call constructor of already existing object $class, so returning same object");
         return $class; # already created, return self
     } else {
-        $class->dump(10, "Called constructor of class $class, creating object...");
         my $self = $class->bless(@_); # call our real constructor
         $self->serviceInit(@_);
         return $self;
@@ -83,7 +81,6 @@ sub serviceCreate {
     if (ref($class)) {
         $class = ref($class);
     }
-    $class->dump(10, "Called service constructor of class $class, creating object...");
     my $self = $class->bless(@_); # call our real constructor
     $self->serviceInstanceInit(@_);
     return $self;
@@ -109,7 +106,6 @@ sub objectCreate {
     if (ref($class)) {
         $class = ref($class);
     }
-    $class->dump(10, "Called object constructor of class $class, creating object...");
     my $self = $class->bless(@_); # call our real constructor
     $self->objectInit(@_);
     return $self;
@@ -132,20 +128,14 @@ sub AUTOLOAD {
     $name =~ s/^.*://o; # strip fully-qualified portion
     if ($self->propertyImpliedAccessAllowed($name)) {
         if (scalar(@_) == 1) {
-            $self->dump(10, "setting implied property '$name' in '$self'");
             return $self->propertySet($name, @_);
         } elsif (scalar(@_) == 0) {
             if ($self->propertyExists($name)) {
-                $self->dump(10, "getting implied property '$name' in '$self'");
                 return $self->propertyGet($name);
             } else {
-                $self->dump(10, "not getting non-existent implied property '$name' in '$self'");
                 return $self->propertyGetUndefined($name);
             }
         }
-        $self->dump(10, "neither setting nor getting implied property '$name' in '$self'");
-    } else {
-        $self->dump(10, "not treating '$name' in '$self' as an implied property, regardless of its existence");
     }
     $self->methodMissing($name, @_);
 }
@@ -162,7 +152,6 @@ sub propertyExists {
     my $self = shift;
     my($name) = @_;
     $self->assert($name, 0, 'propertyExists() cannot be called without arguments');
-    $self->dump(10, "checking for existence of property '$name' in '$self'");
     return exists($self->{$name});
 }
 
diff --git a/mozilla/webtools/PLIF/PLIF/Controller.pm b/mozilla/webtools/PLIF/PLIF/Controller.pm
index 4ff08f1211a..ea077300127 100644
--- a/mozilla/webtools/PLIF/PLIF/Controller.pm
+++ b/mozilla/webtools/PLIF/PLIF/Controller.pm
@@ -151,8 +151,6 @@ sub getServiceList {
             push(@services, $service);
         }
     }
-    local $" = '\', \'';
-    $self->dump(10, "Created a service list for '$name' containing: '@services'");
     return @services;
 }
 
@@ -167,7 +165,6 @@ sub getObjectList {
             push(@services, $service);
         }
     }
-    $self->dump(10, "Created an object list for '$name' containing: '@services'");
     return @services;
 }
 
@@ -236,7 +233,6 @@ sub dispatchMethod {
     my $self = shift;
     my($service, $prefix, $method, @arguments) = @_;
     # the \u makes the first letter of the $command uppercase
-    $self->dump(10, "dispatching method '$prefix\u$method'...");
     return ($self->getSelectingServiceList($service)->dispatch($self, "$prefix\u$method", @arguments) or 
             $self->getSelectingObjectList($service)->dispatch($self, "$prefix\u$method", @arguments));
 }