From 5dc0998c4e38fe9264dbbcde499a703b123d5de2 Mon Sep 17 00:00:00 2001 From: "roc+%cs.cmu.edu" Date: Tue, 12 Aug 2003 16:00:20 +0000 Subject: [PATCH] Bug 207637. Don't fire onchange for MouseUp events where we didn't see a mousedown. r+sr=dbaron,a=asa git-svn-id: svn://10.0.0.236/trunk@145922 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/layout/forms/nsListControlFrame.cpp | 3 +++ mozilla/layout/html/forms/src/nsListControlFrame.cpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/mozilla/layout/forms/nsListControlFrame.cpp b/mozilla/layout/forms/nsListControlFrame.cpp index dc0cf7d538a..0930c78f138 100644 --- a/mozilla/layout/forms/nsListControlFrame.cpp +++ b/mozilla/layout/forms/nsListControlFrame.cpp @@ -2794,6 +2794,9 @@ nsListControlFrame::MouseUp(nsIDOMEvent* aMouseEvent) CaptureMouseEvents(mPresContext, PR_FALSE); // Notify if (mChangesSinceDragStart) { + // reset this so that future MouseUps without a prior MouseDown + // won't fire onchange + mChangesSinceDragStart = PR_FALSE; FireOnChange(); } #if 0 // XXX - this is a partial fix for Bug 29990 diff --git a/mozilla/layout/html/forms/src/nsListControlFrame.cpp b/mozilla/layout/html/forms/src/nsListControlFrame.cpp index dc0cf7d538a..0930c78f138 100644 --- a/mozilla/layout/html/forms/src/nsListControlFrame.cpp +++ b/mozilla/layout/html/forms/src/nsListControlFrame.cpp @@ -2794,6 +2794,9 @@ nsListControlFrame::MouseUp(nsIDOMEvent* aMouseEvent) CaptureMouseEvents(mPresContext, PR_FALSE); // Notify if (mChangesSinceDragStart) { + // reset this so that future MouseUps without a prior MouseDown + // won't fire onchange + mChangesSinceDragStart = PR_FALSE; FireOnChange(); } #if 0 // XXX - this is a partial fix for Bug 29990