From 60170902aa54f77bf67791fc9f1dc2ed8c732a3b Mon Sep 17 00:00:00 2001 From: "smfr%smfr.org" Date: Wed, 29 Dec 2004 04:33:39 +0000 Subject: [PATCH] Fix bug 168791: add another pixel of padding at the top and bottom of the bookmarks toolbar, and fix a bug where there was no space after the first item on each line of the toolbar after the first. git-svn-id: svn://10.0.0.236/trunk@167082 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/camino/src/bookmarks/BookmarkButton.mm | 1 + mozilla/camino/src/bookmarks/BookmarkToolbar.mm | 11 +++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/mozilla/camino/src/bookmarks/BookmarkButton.mm b/mozilla/camino/src/bookmarks/BookmarkButton.mm index 5b2922be9fb..25fa160c512 100644 --- a/mozilla/camino/src/bookmarks/BookmarkButton.mm +++ b/mozilla/camino/src/bookmarks/BookmarkButton.mm @@ -61,6 +61,7 @@ @implementation BookmarkButton + - (id)initWithFrame:(NSRect)frame { if ( (self = [super initWithFrame:frame]) ) diff --git a/mozilla/camino/src/bookmarks/BookmarkToolbar.mm b/mozilla/camino/src/bookmarks/BookmarkToolbar.mm index 89fbeb7ec6a..b316c7a508b 100644 --- a/mozilla/camino/src/bookmarks/BookmarkToolbar.mm +++ b/mozilla/camino/src/bookmarks/BookmarkToolbar.mm @@ -224,8 +224,9 @@ static const int kBMBarScanningStep = 5; #define kMinBookmarkButtonWidth 16.0 #define kMaxBookmarkButtonWidth 150.0 #define kBookmarkButtonHorizPadding 5.0 +#define kBookmarkToolbarTopPadding 2.0 #define kBookmarkButtonVerticalPadding 1.0 -#define kBookmarkToolbarBottomPadding 1.0 +#define kBookmarkToolbarBottomPadding 2.0 -(void)reflowButtonsStartingAtIndex: (int)aIndex { @@ -236,7 +237,7 @@ static const int kBMBarScanningStep = 5; // to bottom right. float oldHeight = [self frame].size.height; int count = [mButtons count]; - float curRowYOrigin = 0.0; + float curRowYOrigin = kBookmarkToolbarTopPadding; float curX = kBookmarkButtonHorizPadding; for (int i = 0; i < count; i ++) @@ -263,9 +264,11 @@ static const int kBMBarScanningStep = 5; if (NSMaxX(buttonRect) > NSWidth([self bounds])) { + // jump to the next line + curX = kBookmarkButtonHorizPadding; curRowYOrigin += (kBookmarkButtonHeight + 2 * kBookmarkButtonVerticalPadding); - buttonRect = NSMakeRect(kBookmarkButtonHorizPadding, curRowYOrigin + kBookmarkButtonVerticalPadding, width, kBookmarkButtonHeight); - curX = NSWidth(buttonRect); + buttonRect = NSMakeRect(curX, curRowYOrigin + kBookmarkButtonVerticalPadding, width, kBookmarkButtonHeight); + curX += NSWidth(buttonRect) + kBookmarkButtonHorizPadding; } [button setFrame: buttonRect];