diff --git a/mozilla/tools/buildbot/buildbot/changes/bonsaipoller.py b/mozilla/tools/buildbot/buildbot/changes/bonsaipoller.py index 6ecfe8cec56..ab00905c825 100644 --- a/mozilla/tools/buildbot/buildbot/changes/bonsaipoller.py +++ b/mozilla/tools/buildbot/buildbot/changes/bonsaipoller.py @@ -175,12 +175,7 @@ class BonsaiParser: return filename def _getRevision(self): - """Returns the revision of the current node""" - rev = self.currentFileNode.getAttribute("rev") - if rev == "": - raise InvalidResultError("A revision was missing from a file") - - return rev + return self.currentFileNode.getAttribute("rev") class BonsaiPoller(base.ChangeSource): @@ -215,7 +210,8 @@ class BonsaiPoller(base.ChangeSource): @param cvsroot: The cvsroot of the repository. Usually this is '/cvsroot' @type pollInterval: int - @param pollInterval: The time (in seconds) between queries for changes + @param pollInterval: The time (in seconds) between queries for + changes """ self.bonsaiURL = bonsaiURL diff --git a/mozilla/tools/buildbot/buildbot/test/test_bonsaipoller.py b/mozilla/tools/buildbot/buildbot/test/test_bonsaipoller.py index b8ca8115f8c..79cf5298029 100644 --- a/mozilla/tools/buildbot/buildbot/test/test_bonsaipoller.py +++ b/mozilla/tools/buildbot/buildbot/test/test_bonsaipoller.py @@ -74,9 +74,6 @@ badUnparsedResult = badUnparsedResult.replace("", "") invalidDateResult = deepcopy(goodUnparsedResult) invalidDateResult = invalidDateResult.replace(str(date1), "foobar") -missingRevisionResult = deepcopy(goodUnparsedResult) -missingRevisionResult = missingRevisionResult.replace("rev=\""+rev3+"\"", "") - missingFilenameResult = deepcopy(goodUnparsedResult) missingFilenameResult = missingFilenameResult.replace(file2, "") @@ -138,13 +135,6 @@ class TestBonsaiPoller(unittest.TestCase): except InvalidResultError: pass - def testMissingRevisionResult(self): - try: - BonsaiParser(StringIO(missingRevisionResult)) - self.fail(badResultMsgs["missingRevisionResult"]) - except InvalidResultError: - pass - def testMissingFilenameResult(self): try: BonsaiParser(StringIO(missingFilenameResult))