From 63aeaaa67641f44d7a308b5b79c1b13bf0903755 Mon Sep 17 00:00:00 2001 From: "ben%netscape.com" Date: Sat, 20 Oct 2001 11:11:58 +0000 Subject: [PATCH] 75825 - View|Show Columns menuitem is always disabled in bookmarks view menu. Prevent the disabling code from disabling any items outside its range of intended operation. r=pchen, sr=hyatt git-svn-id: svn://10.0.0.236/trunk@105878 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/xpfe/global/resources/content/nsTreeUtils.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mozilla/xpfe/global/resources/content/nsTreeUtils.js b/mozilla/xpfe/global/resources/content/nsTreeUtils.js index 1bdfcbd043a..8c4272e8edb 100644 --- a/mozilla/xpfe/global/resources/content/nsTreeUtils.js +++ b/mozilla/xpfe/global/resources/content/nsTreeUtils.js @@ -230,6 +230,7 @@ function update_sort_menuitems(column, direction) enable_sort_menuitems(); } +// XXX this could be a bit more elegant. function enable_sort_menuitems() { var columns = document.getElementById('theColumns'); var column_node = columns.firstChild; @@ -237,8 +238,8 @@ function enable_sort_menuitems() { var tree_column = head.firstChild; var skip_column = document.getElementById('popupCell'); var menuitem = document.getElementById('fill_after_this_node'); - menuitem = menuitem.nextSibling - while (column_node && menuitem) { + menuitem = menuitem.nextSibling; + while (column_node && menuitem && menuitem.id != 'fill_before_this_node') { if (skip_column != tree_column) { if ("true" == column_node.getAttribute("hidden")) { menuitem.setAttribute("disabled", "true");